[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Yip Ng updated DERBY-883: - Component/s: Documentation Fix Version/s: 10.2.1.6 (was: 10.3.0.0) This feature is integrated into 10.2, so the fix version should be 10.2.1.6

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Daniel John Debrunner updated DERBY-883: Fix Version/s: 10.3.0.0 (was: 10.2.1.0) Change was commited to trunk (10.3) Enhance GROUP BY clause to support

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Mike Matrigali updated DERBY-883: - Affects Version/s: 10.2.1.0 This looks like a good thing to get into 10.2,. Enhance GROUP BY clause to support expressions instead of just column

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch7.txt Synced to rev 434408. Use the new JUnit test case/test setup classes. Passed derbylang. Enhance GROUP BY clause to support

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Daniel John Debrunner updated DERBY-883: Derby Info: (was: [Patch Available]) Patch 883.patch6.txt applied to trunk with changes below as revision 437070. 0) Merged by hand to

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch6.txt svn update to revision 430199. Hopefully this patch will apply cleanly. Enhance GROUP BY clause to support expressions instead

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch6.txt Minor correction to previous patch. Enhance GROUP BY clause to support expressions instead of just column references.

Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

On 7/26/06, Army [EMAIL PROTECTED] wrote: Hi Manish,Thanks for addressing my comments.The patch is looking better now--especiallywith the whitespace issues in version 4. Some follow-up comments below.Manish Khettry wrote: 1) TernarnyOpNode.isEquivalent (): I think we need to check receiver

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch5.txt This patch addresses issues raised by Army and Yip. 1. Flag error for aggregate in group by list. Changes to sqlgrammar.jj,

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch4.txt I found a problem in one of my changes. Also got rid of a lot of white space only diffs. Enhance GROUP BY clause to support

Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

Hi Manish, Thanks for addressing my comments. The patch is looking better now--especially with the whitespace issues in version 4. Some follow-up comments below. Manish Khettry wrote: 1) TernarnyOpNode.isEquivalent(): I think we need to check receiver equivalence as well, in addition to

Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

On 7/24/06, Army [EMAIL PROTECTED] wrote: Hi Manish,I have to be honest and say that I haven't taken the time to fully understandthe guts of this patch--namely, the part where you rewrite the group-by treein GroupByNode.addAggregateColumns ().But I did do some review of the overallpatch and I have

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch3.txt incorporate feedback from code review. Enhance GROUP BY clause to support expressions instead of just column references.

Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

Hi Manish, I have to be honest and say that I haven't taken the time to fully understand the guts of this patch--namely, the part where you rewrite the group-by tree in GroupByNode.addAggregateColumns(). But I did do some review of the overall patch and I have the following comments. If you

Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

Army wrote: Nit-picking: Changes that you don't *have* to do but that might help in cleaning up the patch. A. Unnecessary white-space changes? +1 to avoiding such changes. In SelectNode.java: - VerifyAggregateExpressionsVisitor visitor = - new

Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

Army, Thanks for the feeback. I appreciate it. You've identified atleast one (perhaps 2) bugs with my code changes. On the point of 80 chars per line, I can't help but ask: does a tab count as 4 chars or 8? The conventional wisdom from an earlier discussion was that you set your editor to treat

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch.txt Enhance GROUP BY clause to support expressions instead of just column references.

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Derby Info: [Patch Available] Functionally, this patch supports expressions in the group by list. An expression in the group by list can also be used in the

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Satheesh Bandaram updated DERBY-883: Summary: Enhance GROUP BY clause to support expressions instead of just column references. (was: Date functions are 'syntax error' in group by clause)