[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2076:
---
Attachment: derby-2076-2a-enable_test.diff
Attached patch 2a, which enables the test in suites.All.
Since I haven't gotten any feedback on testing, I've decided to enable the test
and see what happens :)
If you don't have the old releases in the default location, and don't specify
derbyTesting.oldReleasePath, you may see an ALARM statement printed to the
console.
The test doesn't require any specific versions, it will test with whatever old
versions of Derby that are made available. This is different from some other
tests.
Committed patch 2a to trunk with revision 1367428.
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: compiler-level.patch,
> derby-2076-0a-modernized_compat_test_preview.diff,
> derby-2076-0b-modernized_compat_test_preview.diff,
> derby-2076-1a-initial.diff, derby-2076-1b-initial.diff,
> derby-2076-2a-enable_test.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Anders Hatlen updated DERBY-2076:
--
Attachment: compiler-level.patch
The new compatibility test suite fails with a class version error when it runs
on Java 5. Changing the compiler level from ${compilerLevel16} to 1.5 (see
compiler-level.patch) makes it pass.
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: compiler-level.patch,
> derby-2076-0a-modernized_compat_test_preview.diff,
> derby-2076-0b-modernized_compat_test_preview.diff,
> derby-2076-1a-initial.diff, derby-2076-1b-initial.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2076:
---
Attachment: derby-2076-1b-initial.diff
Attaching patch 1b, which is the same as patch 1a except that it is generated
with Subversion and that I factored out moving assertDirectoryDeleted to
DERBY-5836.
Committed patch 1b to trunk with revision 1354960.
The new test is ready for testing. Just run JUnit pointing at _Suite. More
information with derby.tests.trace=true and derby.tests.debug=true.
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: derby-2076-0a-modernized_compat_test_preview.diff,
> derby-2076-0b-modernized_compat_test_preview.diff,
> derby-2076-1a-initial.diff, derby-2076-1b-initial.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2076:
---
Issue & fix info: Patch Available
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: derby-2076-0a-modernized_compat_test_preview.diff,
> derby-2076-0b-modernized_compat_test_preview.diff, derby-2076-1a-initial.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2076:
---
Attachment: derby-2076-1a-initial.diff
Attaching patch 1a, which is the intial check-in of the new modernized
compatibility test.
See the package.html for some description. It may be helpful to generate and
read the Javadocs too.
The actual tests, with some modifications, have been taken from the old
compatibility test. Most of the supporting code, i.e. spawning the server and
the client and the combination generator, is new.
The new version is lacking the ability to run with multiple JVM versions. That
feature can be added after the initial patch has been committed - given that
people feel it is worth keeping. I imagine that feature would only be used in
the more comprehensive test suites, and not as part of the MATS variant run in
suites.All.
I intend to commit this shortly to allow for easier testing of the new test. I
hope to include the MATS variant of the test in suites.All after it has been
sufficiently tested and remaining issues have been addressed.
I do believe that committing the current code is better than reviewing this
large chunk of code because it allows others to easily contribute by running
the tests on their systems, and because this will be opt-in. The current/old
compatibility test will continue to run until the community feel comfortable to
do the switch.
The drawback of having two versions is that two versions have to be maintained,
but there are typically few modifications to the compatibility tests (too
few?). I hope that over the summer we have made enough progress to determine
the final action, which will hopefully be to delete the old test and start
using new one exclusively.
Patch ready for review.
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: derby-2076-0a-modernized_compat_test_preview.diff,
> derby-2076-0b-modernized_compat_test_preview.diff, derby-2076-1a-initial.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
On Mon, Jun 18, 2012 at 6:14 AM, Kristian Waagan (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Kristian Waagan updated DERBY-2076: > --- > > Attachment: derby-2076-0b-modernized_compat_test_preview.diff > > Attaching an updated version of the modernized compatibility test. Here's > what running the MATS looks like (with trace and debug enabled): > [...skip...] > > This is still not ready for commit. > Given this will be enabled by default in suites.All, do people prefer that > the test fails if there are no old releases available, or rather that an > ALARM statement is printed? > I would prefer an ALARM. Myrma
[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2076:
---
Attachment: derby-2076-0b-modernized_compat_test_preview.diff
Attaching an updated version of the modernized compatibility test. Here's what
running the MATS looks like (with trace and debug enabled):
$ java -cp
"..\jars\sane\derbyrun.jar;..\jars\sane\derbyTesting.jar;..\tools\java\junit.jar"
-DderbyTesting.oldReleasePath=$( cygpath --windows
~/winhome/Documents/derby/releases ) -Dderby.tests.trace=true
junit.textui.TestRunner
org.apache.derbyTesting.functionTests.tests.compatibility._Suite
{ReleaseRepository} 19 candidate releases at
C:\Users\kwaagan\Documents\derby\releases
skipped invalid distribution: C:\Users\kwaagan\Documents\derby\releases\10.0.2.1
.
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.10.0.0 used 4134 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.8.2.2 <> server
10.10.0.0 used 2091 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.7.1.1 <> server
10.10.0.0 used 2074 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.6.2.1 <> server
10.10.0.0 used 2075 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.5.3.0 <> server
10.10.0.0 used 1576 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.4.2.0 <> server
10.10.0.0 used 1575 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.3.3.0 <> server
10.10.0.0 used 1576 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.2.2.0 <> server
10.10.0.0 used 1560 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.1.3.1 <> server
10.10.0.0 used 1560 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.8.2.2 used 3634 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.7.1.1 used 3120 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.6.2.1 used 3120 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.5.3.0 used 3104 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.4.2.0 used 3136 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.3.3.0 used 3634 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.2.2.0 used 2605 ms .
(net)compatibility.ClientCompatibilityRunControl.client 10.10.0.0 <> server
10.1.3.1 used 3120 ms
Time: 73,692
OK (17 tests)
This is still not ready for commit.
Given this will be enabled by default in suites.All, do people prefer that the
test fails if there are no old releases available, or rather that an ALARM
statement is printed?
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: derby-2076-0a-modernized_compat_test_preview.diff,
> derby-2076-0b-modernized_compat_test_preview.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-2076) Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit usage
[
https://issues.apache.org/jira/browse/DERBY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2076:
---
Attachment: derby-2076-0a-modernized_compat_test_preview.diff
Attaching patch 0a, which is a preview of the work I'm doing on this issue.
This is just for the curious :) I'll write a proper comment tomorrow, listing
various issues with the compatibility test.
You can run this if you want to. I find it best to use the swingui TestRunner -
there you can see the structure of the suites. To apply the patch, do something
like this:
mkdir java/testing/org/apache/derbyTesting/functionTests/tests/compatibility
svn add ava/testing/org/apache/derbyTesting/functionTests/tests/compatibility
svn copy
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/CompatibilitySuite.java
java/testing/org/apache/derbyTesting/functionTests/tests/compatibility/AbstractCompatibilityTest.java
svn copy
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/JDBCDriverTest.java
java/testing/org/apache/derbyTesting/functionTests/tests/compatibility/
patch -p0 < derby-2076-0a-modernized_compat_test_preview.diff
To run the test you have to specify derbyTesting.oldReleasePath, which should
preferably point to the Derby release JAR repos
(https://svn.apache.org/repos/asf/db/derby/jars), and you have to run off jars:
java -classpath derby_jars:junit.jar
-DderbyTesting.oldReleasePath=release_jars_dir -Dderby.tests.debug=true
-Dderby.tests.trace=true junit.swingui.TestRunner
org.apache.derbyTesting.functionTests.tests.compatibility._Suite
> Rewrite junitTests/derbyNet/CompatibilityTest to conform to current JUnit
> usage
> ---
>
> Key: DERBY-2076
> URL: https://issues.apache.org/jira/browse/DERBY-2076
> Project: Derby
> Issue Type: Improvement
> Components: Test
>Affects Versions: 10.3.1.4
>Reporter: Andrew McIntyre
>Assignee: Kristian Waagan
>Priority: Minor
> Attachments: derby-2076-0a-modernized_compat_test_preview.diff
>
>
> The test
> org.apache.derbyTesting.functionTests.tests.junitTests.DerbyNet.CompatibilityTest
> has been failing in the nightlies because it needs to be run in the old test
> harness, and for some reason the property which grants permission to read
> ${user.home}/junit.properties is not being picked up properly in the old
> harness.
> I am able to resolve the problem by granting permission to read
> ${user.home}/junit.properties to all, but the test should be refactored so
> that it can run with the rest of the junit tests without needing the old
> harness.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
