[jira] Commented: (DERBY-3478) Simple column names specified as part of "AS" clause in a table expression are ignore if the table expression is a view.

2009-08-26 Thread Dag H. Wanvik (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748187#action_12748187
 ] 

Dag H. Wanvik commented on DERBY-3478:
--

Regressions ran ok. Thanks for looking at this Bryan!


> Simple column names specified as part of "AS" clause in a table expression 
> are ignore if the table expression is a view.
> 
>
> Key: DERBY-3478
> URL: https://issues.apache.org/jira/browse/DERBY-3478
> Project: Derby
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 10.0.2.1, 10.1.1.0, 10.1.2.1, 10.1.3.1, 10.2.1.6, 
> 10.2.2.0, 10.3.1.4, 10.3.2.1
>Reporter: A B
>Assignee: Dag H. Wanvik
>Priority: Minor
> Fix For: 10.6.0.0
>
> Attachments: derby-3478.diff, derby-3478.stat
>
>
> Simple repro as follows:
> create table t1 (i int, j int);
> insert into t1 values (1, 1), (1, -1), (2, 2), (3, -3), (4, 4);
> create view v1 as select j, i from t1;
> create view v2 (x,y,z) as select j, i, i+j from t1;
> -- OK: Returns column names specified in AS clause.
> select * from t1 as x(a,b);
> -- OK: Returns column names for the views
> select * from v1;
> select * from v2;
> -- WRONG: Ignores column names specified in AS clause for the views.
> select * from v1 x(a,b);
> select * from v2 as x(a,b,c);
> I observed this as far back as 10.0.2.1, so this is not a regression.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (DERBY-3478) Simple column names specified as part of "AS" clause in a table expression are ignore if the table expression is a view.

2009-08-26 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748059#action_12748059
 ] 

Bryan Pendleton commented on DERBY-3478:


Thanks for picking up the bug, Dag.

I read through the diff and did some simple confirmation:
 - the code change seems reasonable
 - the new test fails as expected without the code change
 - the new test passes as expected with the code change

I think this is a solid fix: +1 to commit from me, assuming no 
surprises arose during your regression run.

> Simple column names specified as part of "AS" clause in a table expression 
> are ignore if the table expression is a view.
> 
>
> Key: DERBY-3478
> URL: https://issues.apache.org/jira/browse/DERBY-3478
> Project: Derby
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 10.0.2.1, 10.1.1.0, 10.1.2.1, 10.1.3.1, 10.2.1.6, 
> 10.2.2.0, 10.3.1.4, 10.3.2.1
>Reporter: A B
>Assignee: Dag H. Wanvik
>Priority: Minor
> Attachments: derby-3478.diff, derby-3478.stat
>
>
> Simple repro as follows:
> create table t1 (i int, j int);
> insert into t1 values (1, 1), (1, -1), (2, 2), (3, -3), (4, 4);
> create view v1 as select j, i from t1;
> create view v2 (x,y,z) as select j, i, i+j from t1;
> -- OK: Returns column names specified in AS clause.
> select * from t1 as x(a,b);
> -- OK: Returns column names for the views
> select * from v1;
> select * from v2;
> -- WRONG: Ignores column names specified in AS clause for the views.
> select * from v1 x(a,b);
> select * from v2 as x(a,b,c);
> I observed this as far back as 10.0.2.1, so this is not a regression.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.