[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728799#action_12728799 ] Kathey Marsden commented on DERBY-3834: --- It looks like this introduced a javadoc warning: Failed with following errors. Check details in docs.txt [javadoc] C:\nightlies\main\src\opensource\java\testing\org\apache\derbyTesting\functionTests\tests\derbynet\RuntimeInfoTest.java:78: warning - @return tag has no arguments. [javadoc] 1 warning Build: OK > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728413#action_12728413 ] Tiago R. Espinha commented on DERBY-3834: - The suites.All suite ran with no failures. I think the patch is ready for commit. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728205#action_12728205 ] Kathey Marsden commented on DERBY-3834: --- I think the problem is related to the vetPing() method of NetworkServerTestSetup looking for an English string? If I change vetPing to just look for "DRDA_NoIO.S:" then it seems to run ok. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727997#action_12727997 ] Tiago R. Espinha commented on DERBY-3834: - Hello Kathey, I'm not sure if that is it. I would think that we have this same situation in other tests, no? They should be independent... I find it weird that it only happens under Linux... makes me think that there is some underlying difference on how the JVM is handling stuff around. Maybe it also has to do with the default locale... or with file permissions somehow. I will have to look at it later today. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727923#action_12727923 ] Kathey Marsden commented on DERBY-3834: --- On my linux machine with and without basePort set running the test on its own I am getting a Connection refused message to the console in German and then a timeout failure for the test. It is at least consistent so I should be able to debug tomorrow. Could it be related to having two clientServerDecorator instances in a single test? > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727911#action_12727911 ] Kathey Marsden commented on DERBY-3834: --- Hi Tiago I ran suites.All with your latest patch and got no failures on Windows XP with derby.tests.basePort=11123. I will do a run on linux with the same setting and if I see no issues will go ahead and commit. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727300#action_12727300 ] Tiago R. Espinha commented on DERBY-3834: - I got failures again: 8< Time: 6,031.741 There were 2 failures: 1) org.apache.derbyTesting.functionTests.tests.derbynet.RuntimeInfoTestjunit.framework.AssertionFailedError: Timed out waiting for network server to start at org.apache.derbyTesting.junit.NetworkServerTestSetup.setUp(NetworkServerTestSetup.java:200) at junit.extensions.TestSetup$1.protect(TestSetup.java:20) at junit.extensions.TestSetup.run(TestSetup.java:25) at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) 2) testStressMulti(org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest)junit.framework.AssertionFailedError: Caused by: java.sql.SQLNonTransientConnectionException: The DDM object 0x1232 is not supported. The connection has been terminated. at org.apache.derby.client.am.SQLExceptionFactory40.getSQLException(SQLExceptionFactory40.java:70) at org.apache.derby.client.am.SqlException.getSQLException(SqlException.java:358) at org.apache.derby.client.am.Connection.createStatement(Connection.java:368) at org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest$StressMultiRunnable.update(StressMultiTest.java:558) at org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest$StressMultiRunnable.run(StressMultiTest.java:402) at java.lang.Thread.run(Thread.java:619) Caused by: org.apache.derby.client.am.SqlException: The DDM object 0x1232 is not supported. The connection has been terminated. at org.apache.derby.client.am.SqlException.copyAsUnchainedSQLException(SqlException.java:505) at org.apache.derby.client.am.Sqlca.chainDeferredExceptionsToAgentOrAsConnectionWarnings(Sqlca.java:342) at org.apache.derby.client.am.Sqlca.getJDBCMessage(Sqlca.java:304) at org.apache.derby.client.am.SqlException.getMessage(SqlException.java:402) at org.apache.derby.client.am.SqlException.getSQLException(SqlException.java:358) at org.apache.derby.client.am.Statement.executeUpdate(Statement.java:509) at org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest$StressMultiRunnable.update(StressMultiTest.java:560) ... 2 more at org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest.handleException(StressMultiTest.java:331) at org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest.access$200(StressMultiTest.java:70) at org.apache.derbyTesting.functionTests.tests.multi.StressMultiTest$StressMultiRunnable.run(StressMultiTest.java:425) at java.lang.Thread.run(Thread.java:619) FAILURES!!! Tests run: 11312, Failures: 2, Errors: 0 8<--- I can't seem to find the reason for these though... > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message i
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727278#action_12727278 ] Tiago R. Espinha commented on DERBY-3834: - I'm still rather unsure about the status of this patch. Last night I got some failures once more - namely failures with beans, which seems to happen every now and then. The failures also had an error message in German, which might raise a red flag. The weird part is that I can consistently run the derbynet suite without any failures... I'm running suites.All tonight once more to see how it pans out. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727125#action_12727125 ] Tiago R. Espinha commented on DERBY-3834: - The said bug with the port is now fixed in DERBY-4217. Still, upon running suites.All I got: --8< Time: 5,827.406 There was 1 failure: 1) org.apache.derbyTesting.functionTests.tests.derbynet.RuntimeInfoTestjunit.framework.AssertionFailedError: Timed out waiting for network server to start at org.apache.derbyTesting.junit.NetworkServerTestSetup.setUp(NetworkServerTestSetup.java:200) at junit.extensions.TestSetup$1.protect(TestSetup.java:20) at junit.extensions.TestSetup.run(TestSetup.java:25) at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) FAILURES!!! Tests run: 11312, Failures: 1, Errors: 0 --8<-- It seems a rather innocent failure and after running the derbynet suite again twice the failure did not pop again. It needs to be said that the suites.All was ran simultaneously with derbyall. Still, I think we can chalk it up to delays in the server response due to the high load. Nonetheless, I will be running suites.All again, this time alone. Test runs permitting, the patch seems to be ready for commit. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726461#action_12726461 ] Tiago R. Espinha commented on DERBY-3834: - We want to hold this patch for now. My suites.All run crashed with some bug related to DERBY-4217 - it seems that when using a basePort with 5 digits (i.e. higher than ), the SysinfoTest will crash. It might be unrelated with this issue in the end but I'm still investigating why this is happening. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725344#action_12725344 ] Kathey Marsden commented on DERBY-3834: --- SysinfoLocaleTest seems to be an embedded tests a and tests derby.ui.locale which is not relevant here. Do you think it will adapt itself well to the network server runtimeinfo testing? I guess I am still leaning toward a locale specific runtimeinfo test. I suppose catching an exception and resetting the locale would work too, but seems a little messier. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725339#action_12725339 ] Tiago R. Espinha commented on DERBY-3834: - I just noticed that we have a SysinfoLocaleTest that tests just the localized output of Sysinfo. Would it be a viable option to have a single LocaleTest where all these outputs are tested? > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725277#action_12725277 ] Tiago R. Espinha commented on DERBY-3834: - Hello Kathey, Well, considering I'm manipulating the server that the test spawns automatically, it should never stay running. I'm not spawning an independent server just to accommodate the locale testing; instead, I just stop the server that the test automatically starts, change the locale and start the server again. The odd case would be if this fixture fails, but a possible solution is to encapsulate this method in a try..catch statement. Since all the fixtures are actually invoked manually because the order in which they are ran matters, I can just catch the exception that this method may throw and set the locale back to normal. I'm just laying this on the table because it seems to me a bit of overkill to create a whole new test with just one fixture that tests the locale. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725264#action_12725264 ] Kathey Marsden commented on DERBY-3834: --- Hi Tiago, I am concerned that if this tests fails we will be left with a network server running or leave the tests set to the German locale, causing subsequent tests to fail. I think it would be better to make a second test LocaleRuntimeInfoTest or some such and then use: public NetworkServerTestSetup ( Test test, String[] systemProperties, String[] startupArgs, boolean serverShouldComeUp ) to spawn the server with the correct locale by setting system properties. It will make sure everything is shutdown and cleaned up regardless of whether the test fails. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, > DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724682#action_12724682 ] Tiago R. Espinha commented on DERBY-3834: - I have been discussing the locale bit with Kathey and we were able to draw some conclusions, but there's still a pending issue. The original test apparently did no verification at all on the locale front. Despite setting the user.country and user.language properties, the output it expects is actually in English, so it doesn't seem like it was expected for it to work properly. Still, we agreed it would be a nice addition to the test, having it check the localized output. The problem arises with the fact that the output of runtimeinfo is dependent on the locale of the server and not of the client (unlike ping, for example). So for this to work, that one single fixture has to shutdown the server and spawn another instance with the changed locale. Does anyone have ideas or comments on this? It is also noteworthy that the test seems to pick up the localization properties if I define them with -D on the command line. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724513#action_12724513 ] Kathey Marsden commented on DERBY-3834: --- Thanks Tiago for reviving this test. I ran the test with IBM 1.6 and it passed and confirmed that it is skipped with weme. You should remove references to the old test in functionTests/suites/ DerbyNetClientRemote.exclude DerbyNetClientUseprocess.exclude DerbyNetRemote.exclude DerbyNetUseprocess.exclude derbynetmats.runall j9derbynetmats.runall and run derbyall to make sure all references to the old test are removed. In the test I think it would be good to comment that a separate database was necessary to ensure consistent output above the call to singleUseDatabaseDecorator. I think x_testRuntimeInfo and x_testRuntimeInfoMethod and related constants could be more descriptively named, like x_testRuntimeInfoWithActiveConn and x_testRuntimeInfoAfterConnClose. I am a bit confused by x_testRuntimeInfoLocale, even in the original test. I would have expected it to test non-English output, but instead runs with: "-Duser.language=err", "-Duser.country=DE", which makes it revert to English I guess. I think it would be better if it tested the localization with user.language=de and then just check the output for some German string. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724412#action_12724412 ] Tiago R. Espinha commented on DERBY-3834: - Ran suites.All and I got a 100% pass. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.1.1 >Reporter: Erlend Birkenes >Assignee: Tiago R. Espinha >Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, > Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622736#action_12622736 ] Myrna van Lunteren commented on DERBY-3834: --- I ran the test, but the first time, it fails for me. If I run it again without cleaning up the dir, it passes. Maybe some of the details regarding sessions and statements are different when you first create a database... So maybe you can wrap the test in a singleUseDecorator and adjust the expected output to what it would be when there are no pre-existing databases. Other comments: - I'd like it better if you could avoid using ExecProcUtil.execCmdDumpResults... - There is a property, derby.tests.debug, which can be set if someone wants to debug a test. I suggest you remove the boolean 'print' and instead, in the method 'print()' use org.apache.derbyTesting.junit.println' rather than System.out.println. That way, no change of the code is needed to debug the test. > Convert derbynet/runtimeinfo to JUnit > - > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.5.0.0 >Reporter: Erlend Birkenes >Assignee: Erlend Birkenes >Priority: Minor > Fix For: 10.5.0.0 > > Attachments: Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
