[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734451#action_12734451 ] Eranda Sooriyabandara commented on DERBY-4248: -- Hi Bryan, Thanks for submitting the patch. I am happy to about the update. I am closing this issue. Thanks Eranda > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: CheckConstraintTest.diff, CheckConstraintTest.diff, > CheckConstraintTest.diff, CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733064#action_12733064 ] Bryan Pendleton commented on DERBY-4248: Hi Eranda, I don't see an updated diff file. Maybe the attachment did not go through? > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: CheckConstraintTest.diff, CheckConstraintTest.diff, > CheckConstraintTest.diff, CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733047#action_12733047 ] Eranda Sooriyabandara commented on DERBY-4248: -- Hi Bryan, I compared CheckContraintTest with the checkConstraint.sql and I didn't find an error in this test and successfully ran in my platform. Here is my final patch file attaching with this. Thanks Eranda > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: CheckConstraintTest.diff, CheckConstraintTest.diff, > CheckConstraintTest.diff, CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722955#action_12722955 ] Bryan Pendleton commented on DERBY-4248: I successfully built and ran CheckConstraintTest, and the test passed. > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: CheckConstraintTest.diff, CheckConstraintTest.diff, > CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722893#action_12722893 ] Bryan Pendleton commented on DERBY-4248: Hi Eranda, I will have a look at your latest version of CheckConstraintTest as soon as I can. > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: CheckConstraintTest.diff, CheckConstraintTest.diff, > CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714766#action_12714766 ] Eranda Sooriyabandara commented on DERBY-4248: -- Hi Bryan, I am sorry I have mistaken and I attached a file belong to the DERBY-4187 file here. Thanks Eranda > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: AlterTableTest.diff, CheckConstraintTest.diff, > CheckConstraintTest.diff, CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[
https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713998#action_12713998
]
Bryan Pendleton commented on DERBY-4248:
Hi Eranda,
The new patch looks good, it seems like the new test is taking shape nicely.
I think that the conversion tool did not handle this section of the script very
well:
prepare p1 as 'insert into t1 values 1';
prepare p2 as 'update t1 set c1 = 3 where c1 = 4';
prepare p3 as 'select * from t1';
-- the insert and update should fail, select should succeed
execute p1;
execute p2;
execute p3;
In the new JUnit test, this seemed to show up as:
+pSt = prepareStatement(
+"insert into t1 values 1");
+
+pSt = prepareStatement(
+"update t1 set c1 = 3 where c1 = 4");
+
+pSt = prepareStatement(
+"select * from t1");
+
+// the insert and update should fail, select should succeed
+
+assertStatementError("23505", pSt);
+
+assertStatementError("23505", pSt);
+
+rs = pSt.executeQuery();
I think that we should not be using the same variable for these 3 prepared
statements,
instead we need to have 3 separate PreparedStatement objects.
> convert checkConstraint.sql to JUnit
>
>
> Key: DERBY-4248
> URL: https://issues.apache.org/jira/browse/DERBY-4248
> Project: Derby
> Issue Type: Test
> Components: Test
>Affects Versions: 10.4.3.0
>Reporter: Eranda Sooriyabandara
>Assignee: Eranda Sooriyabandara
>Priority: Minor
> Fix For: 10.6.0.0
>
> Attachments: CheckConstraintTest.diff, CheckConstraintTest.diff,
> CheckConstraintTest.diff, CheckConstraintTest.java
>
>
> Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4248) convert checkConstraint.sql to JUnit
[ https://issues.apache.org/jira/browse/DERBY-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713133#action_12713133 ] Bryan Pendleton commented on DERBY-4248: Hi Eranda, thanks for attaching the patch proposal. Your diff file also includes the AlterTableTest changes from DERBY-4187. It would be better to keep these separate. Can you construct a separate source tree on your system containing only the CheckConstraint test changes and provide a diff with only those contents? Thanks! > convert checkConstraint.sql to JUnit > > > Key: DERBY-4248 > URL: https://issues.apache.org/jira/browse/DERBY-4248 > Project: Derby > Issue Type: Test > Components: Test >Affects Versions: 10.4.3.0 >Reporter: Eranda Sooriyabandara >Assignee: Eranda Sooriyabandara >Priority: Minor > Fix For: 10.6.0.0 > > Attachments: CheckConstraintTest.diff, CheckConstraintTest.java > > > Converting CheckConstraint.sql to JUnit under supervision of Bryan Pendleton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
