[jira] Commented: (DERBY-4484) Add import/export support for UDTs.
[ https://issues.apache.org/jira/browse/DERBY-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828366#action_12828366 ] Rick Hillegas commented on DERBY-4484: -- Thanks, Knut. The tests ran cleanly for me. Committed derby-4484-02-aa-exceptionHandling.diff at subversion revision 905472. > Add import/export support for UDTs. > --- > > Key: DERBY-4484 > URL: https://issues.apache.org/jira/browse/DERBY-4484 > Project: Derby > Issue Type: Improvement > Components: SQL >Affects Versions: 10.6.0.0 >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4484-01-ac-basicExportImport.diff, > derby-4484-02-aa-exceptionHandling.diff > > > Import/export should work on UDTs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4484) Add import/export support for UDTs.
[ https://issues.apache.org/jira/browse/DERBY-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828180#action_12828180 ] Knut Anders Hatlen commented on DERBY-4484: --- Thanks for making these changes, Rick. I didn't realize that adding a throws declaration to UserDefinedTypeIdImpl's constructor would affect so many files... But the changes look good to me. +1 to commit if the regression tests still pass. > Add import/export support for UDTs. > --- > > Key: DERBY-4484 > URL: https://issues.apache.org/jira/browse/DERBY-4484 > Project: Derby > Issue Type: Improvement > Components: SQL >Affects Versions: 10.6.0.0 >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4484-01-ac-basicExportImport.diff, > derby-4484-02-aa-exceptionHandling.diff > > > Import/export should work on UDTs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4484) Add import/export support for UDTs.
[
https://issues.apache.org/jira/browse/DERBY-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828141#action_12828141
]
Knut Anders Hatlen commented on DERBY-4484:
---
In UserDefinedTypeIdImpl, there's an error handler that looks like this:
+} catch (Exception e) { throw new IllegalArgumentException(
e.getMessage() ); }
Here, the stack trace of the original error is lost, and it's also not obvious
to me that any error happening in that method must be because of an illegal
argument. I'd suggest that this method is declared to throw StandardException
instead (I think that's the only checked exception in the method) and the
try/catch is removed. Alternatively, use iapi.error.PassThroughException
instead of IllegalArgumentException so that the original exception and stack
trace can be unwrapped by higher-level error handlers.
Similarly, I think this error handler in ColumnInfo.getUDTClassName()
+catch (Exception e) { throw new SQLException( e.getMessage() ); }
should throw LoadError.unexpectedError(e) instead (for preservation of stack
trace and SQLState).
> Add import/export support for UDTs.
> ---
>
> Key: DERBY-4484
> URL: https://issues.apache.org/jira/browse/DERBY-4484
> Project: Derby
> Issue Type: Improvement
> Components: SQL
>Affects Versions: 10.6.0.0
>Reporter: Rick Hillegas
>Assignee: Rick Hillegas
> Attachments: derby-4484-01-ac-basicExportImport.diff
>
>
> Import/export should work on UDTs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4484) Add import/export support for UDTs.
[ https://issues.apache.org/jira/browse/DERBY-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828123#action_12828123 ] Rick Hillegas commented on DERBY-4484: -- Committed derby-4484-01-ac-basicExportImport.diff at subversion revision 905289. > Add import/export support for UDTs. > --- > > Key: DERBY-4484 > URL: https://issues.apache.org/jira/browse/DERBY-4484 > Project: Derby > Issue Type: Improvement > Components: SQL >Affects Versions: 10.6.0.0 >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4484-01-ac-basicExportImport.diff > > > Import/export should work on UDTs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4484) Add import/export support for UDTs.
[ https://issues.apache.org/jira/browse/DERBY-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806574#action_12806574 ] Rick Hillegas commented on DERBY-4484: -- Tests passed cleanly for me on derby-4484-01-ac-basicExportImport.diff. > Add import/export support for UDTs. > --- > > Key: DERBY-4484 > URL: https://issues.apache.org/jira/browse/DERBY-4484 > Project: Derby > Issue Type: Improvement > Components: SQL >Affects Versions: 10.6.0.0 >Reporter: Rick Hillegas > Attachments: derby-4484-01-ac-basicExportImport.diff > > > Import/export should work on UDTs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
