[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895573#action_12895573 ] Kristian Waagan commented on DERBY-4715: Thanks, Lily. You only get an email from Hudson if something goes wrong with the build. As you can see here [1], it didn't find any problems with your backport to 10.6. The job is checking the repos hourly, and the job itself is quickly done, so if you introduce a build break (or a JavaDoc warning) you should get an email within one and a half hour or so. Another tip when merging a single revision is to use svn merge -c REV instead of svn merge -r REV-1:REV. [1] http://hudson.zones.apache.org/hudson/job/Derby-branch-10.6/23/ > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-10.5_967304.diff, > DERBY-4715-10.6_967304.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895429#action_12895429 ] Lily Wei commented on DERBY-4715: - Thanks Kristian for reviewing the merge code. After 'ant clobber all buildjars' and 'ant javadoc', suites.All and derbyall test suites are passing. I did some tests against ibm jvm for this merge. I commit the merge to 10.5 and 10.6 branches. I hope Hudson build will pick up the changelist. I did not get emails after commit my code. I hope not receiving emails will not delay me to react to any issue cause by my commit. However, I know you guys are always watching too. Please let me know if there is anything I should pay attention to. The wiki-page is very helpful. Thank you. I shall add any new information as I discover them. The new svn is 982370(10.6) and 982401(10.5). > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-10.5_967304.diff, > DERBY-4715-10.6_967304.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895349#action_12895349 ] Kristian Waagan commented on DERBY-4715: If the fix merged cleanly (svn merge succeeded), and you were able to do a clean build and ran the tests without (new) errors, you can basically commit. I prefer to do a clean build to make sure all changes are picked up; I run 'ant clobber all buildjars'. In some rare cases you can also introduce JavaDoc errors by doing a backport, so it doesn't hurt to run the JavaDoc target either. For the newer branches this will be picked up by the Hudson build jobs, and a mail will be sent to derby-dev (plus the committer(s) who introduced the change(s)). You may have seen this already, but there are some guidelines at http://wiki.apache.org/db-derby/MoveAChangeBetweenBranches >From a quick glance, it seems you can save yourself some time by not posting >patches if the merge is clean :) The wiki-page seems to be rather up to date, but I think there are a few issues there that would benefit from a refresh. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-10.5_967304.diff, > DERBY-4715-10.6_967304.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893091#action_12893091 ] Kristian Waagan commented on DERBY-4715: Yes, I agree that we should not change the indentation for lines we don't touch in a patch. My point was about lines added or changed as part of a patch. Due to better tools this mixing of tabs and spaces isn't such a big deal any more, but still the tools mess up at times (for instance changing the indentation on lines not changed by the fix itself, or when viewing diffs/code in a terminal). For the curious, here's where we stand today: Whitespace characteristics (r967304) == * Files Spaces only : 1056 37.34% Tabs only :0 0.00% Mixed : 1772 62.66% * Lines Spaces only : 597974 52.23% Tabs only : 281128 24.55% Mixed :87550 7.65% Blank : 131378 11.47% No indent :46943 4.00% We can see that even changing just the lines which mix both tabs and spaces would cause a huge amount of noise (and, as you say, make digging in the Derby history more difficult), which is why I'm most comfortable with just letting the situation improve gradually. Then, in a rather distant future... ;) > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892964#action_12892964 ] Lily Wei commented on DERBY-4715: - Thank you for reviewing the patch, Kristian. I will prefer using spaces for indentation as well. However, for file BaseDataFileFactory.java, there are way too many lines changes if I save spaces as tab for indentation using editor/IDE to insert spaces when I press the TAB key. That is why both spaces and tab were using for the patch. I think it is also important to keep history as we introduce insert spaces as tab for indentation going forward. We could have a project that only changes tab to spaces. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892698#action_12892698 ] Kristian Waagan commented on DERBY-4715: Just in case it wasn't a deliberate choice, the commit added both spaces and tabs for indentation. I still don't think the community has agreed formally on this issue, but personally I'm always using spaces for indentation (I configured my editor/IDE to insert spaces when I press the TAB key on my keyboard). > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891036#action_12891036 ] Knut Anders Hatlen commented on DERBY-4715: --- The latest patch looks fine to me. It looks like you'll get your commit privileges very soon now, so I'll leave this one for you to commit yourself. :) > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890937#action_12890937 ] Lily Wei commented on DERBY-4715: - Thanks Kim for looking into this issue. The documentation issue is like DERBY-4601. Once we have a JIRA for that issue, we shall include all the information on there. DERBY-4715-8.diff pass Suites.all and derbyall tests. It is ready to commit. Thanks!!! > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890861#action_12890861 ] Kim Haase commented on DERBY-4715: -- It seems likely that the fix to this issue, like the one for DERBY-4601, will affect the messages shown in the Getting Started guide. Perhaps the documentation issue for that issue can reflect these changes too. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > DERBY-4715-8.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890788#action_12890788 ] Knut Anders Hatlen commented on DERBY-4715: --- Thanks Lily. I think the latest changes look good. I agree that removing the initial space in that message sounds like a good idea. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, DERBY-4715-7.diff, > derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890614#action_12890614 ] Knut Anders Hatlen commented on DERBY-4715: --- Thanks Lily. After the last patch, the message looks like this: Booting Derby version The Apache Software Foundation - Apache Derby - 10.7.0.0 alpha - (1): instance a816c00e-0129-f436-4fd9-0348e710 on database directory /tmp/db Loaded from file:/code/derby/trunk0/classes/ java.vendor=Sun Microsystems Inc. java.runtime.version=1.6.0_21-b06 with class loader sun.misc.launcher$appclassloa...@17182c1 I think it would be better if the "with class loader" part came straight after "on database directory (...)" and not on the java.runtime.version line. Would it make sense to add an extra parameter for jvmVersion? It feels a bit strange to have jvmVersion as a part of the JarClassPath parameter. Or perhaps it's cleaner to move jvmVersion out of that message altogether, and instead add a call to "logMsg(jvmVersion);" after having printed the boot message? > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, DERBY-4715-6.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890230#action_12890230 ] Knut Anders Hatlen commented on DERBY-4715: --- Sorry, I missed one issue when I looked through the patch: In BaseDataFileFactory.java, there's this diff: MessageService.getTextMessage(MessageId.STORE_BOOT_MSG, jbmsVersion, identifier, - dataDirectory + " " + readOnlyMsg, // cast to Object so we get object hash code - (Object) this.getClass().getClassLoader() + (Object) this.getClass().getClassLoader(), + dataDirectory + " " + readOnlyMsg + +"\nLoaded from " + jarCPath + "\n" +jvmVersion )); Since we hard-code English text as an argument to STORE_BOOT_MSG, only parts of the message will be translated in non-English locales. We should instead add extra arguments to the STORE_BOOT_MSG message and make the hard-coded English strings part of the message text in messages.xml. Also, the patch changed the order of the arguments in that call, so now the message looks like this: Booting Derby version The Apache Software Foundation - Apache Derby - 10.7.0.0 alpha - (1): instance a816c00e-0129-ef61-4e78-0348df10 on database directory sun.misc.launcher$appclassloa...@13f5d07 with class loader /tmp/testdb Note that it says that "sun.misc.launcher$appclassloa...@13f5d07" is a database directory and "/tmp/testdb" is a class loader, but it should have been the other way around. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889392#action_12889392 ] Kathey Marsden commented on DERBY-4715: --- Thanks Lily, I will commit first thing Monday if your account does not come through by then. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888412#action_12888412 ] Lily Wei commented on DERBY-4715: - Thank you, Knut. Yeah! Suites.all and derbyall seem to run fine except: 1) ttestSetPortPriority(org.apache.derbyTesting.functionTests.tests.derbynet.Serve rPropertiesTest)junit.framework.AssertionFailedError: Port 1537 exceeeds expected maximum. You may need to update TestConfiguration.MAX_PORTS_USED and the Wiki page at http://wiki.apache.org/db-derby/DerbyJUnitTesting if test runs now require mor e available ports at org.apache.derbyTesting.junit.TestConfiguration.getNextAvailablePort(Te stConfiguration.java:1413) at org.apache.derbyTesting.functionTests.tests.derbynet.ServerPropertiesTe st.ttestSetPortPriority(ServerPropertiesTest.java:445) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja va:48) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso rImpl.java:37) at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:10 9) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) This failure is a known issue by the group. DERBY-4715-5.diff is ready to submit. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888248#action_12888248 ] Knut Anders Hatlen commented on DERBY-4715: --- Thanks, Lily. The latest patch looks fine to me. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, DERBY-4715-5.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887688#action_12887688 ] Knut Anders Hatlen commented on DERBY-4715: --- Thanks for making these improvements, Lily. A couple more comments to the latest patch: - The javadoc for jarClassPath() is a little unclear. I don't understand what's meant by "the path of string" or by "the string of jar file". - The javadoc for buildJvmVersion() should make it clear that it returns values of system properties that identify the JVM. - buildJvmVersion() has a @param tag, but the method has no parameters. - Now that we add a newline character between each property, there's no need to append " " (one space) to each property value. - If jarClassPath() had taken a Class argument instead of a String argument, and we called it like "jarCPath = jarClassPath(getClass());", there would be no need to call Class.forName(), and we could remove the catch block for ClassNotFoundException. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > DERBY-4715-4.diff, derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887286#action_12887286 ] Kristian Waagan commented on DERBY-4715: Regarding the public methods in utility classes, I think it is fine to create (and use them) if they add value, but the utility method should not include the call to doPrivileged. Instead, the calling code (which is hopefully not easily accessible and controllable for external users) should call the utility method inside a doPrivileged-block. The above approach isn't as compact, but Kathey is right that adding public (static) utility methods with doPrivileged-blocks is dangerous. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887221#action_12887221 ] Kathey Marsden commented on DERBY-4715: --- I have not looked at the updated patch yet, but I know that sometimes it is tempting to put methods requiring permissions in public methods of utility classes, but it is generally not a good idea to do so as it allows external users to access those permissions granted to Derby. > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887159#action_12887159 ] Knut Anders Hatlen commented on DERBY-4715: --- A couple comments in addition to what Bryan said: - The methods jarClassPath() and buildJvmVersion() have different indentation than the other methods. - If formatURL() gets an IOException, it returns the string "IOException". Perhaps it should also return the exception's message text? - I don't follow all the logic in formatURL(). Could you add some comments that explain the various transformations? In my environment, just printing what URL.toString() returns gives clear enough information: file:/code/derby/trunk0/classes/ or file:/code/derby/trunk0/jars/sane/derby.jar - For readability, I think it would be better to separate the properties with a newline character instead of a space. - The comments in the policy files say "Add for DERBY-4715". I think it would be better if they said why the permission was needed since we include them as templates in the distribution and refer to them from the documentation[1], so they are expected to be read by users. Perhaps something like "getProtectionDomain is an optional permission needed for printing classpath information to derby.log." - In server.policy and template.policy, the new permission is added in the section that is labeled "These permissions are needed for everyday, embedded Derby usage." My understanding of the patch is that the new permission is optional, and embedded Derby will work fine without it, it just won't print the classpath to derby.log. If it's so, I'd suggest moving it to a less prominent section of the policy files. - Similarly, in AssertFailureTest.policy, the permission is added under the label "These are the ones that matter", but AssertFailureTest runs fine without it. [1] http://db.apache.org/derby/docs/dev/adminguide/tadminnetservcustom.html > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887112#action_12887112 ] Bryan Pendleton commented on DERBY-4715: I think the patch looks good; the format of the message is OK by me. The new utility methods in BaseDataFileFactory seem very useful, but it doesn't seem quite right to place them in BaseDataFileFactory. It seems like maybe they should go into a package like org.apache.derby.iapi.util. Perhaps we need a UriUtil class there? > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4715) Write jvm information and path of derby.jar to derby.log
[ https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887108#action_12887108 ] Lily Wei commented on DERBY-4715: - Thanks Bryan for catching that. Do you see any potential issue with the patch? > Write jvm information and path of derby.jar to derby.log > > > Key: DERBY-4715 > URL: https://issues.apache.org/jira/browse/DERBY-4715 > Project: Derby > Issue Type: Bug > Components: Miscellaneous >Affects Versions: 10.6.1.0 >Reporter: Lily Wei >Assignee: Lily Wei >Priority: Minor > Fix For: 10.7.0.0 > > Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff, > derby.log > > > The bug is part of DERBY-1272. In production environment, derby.jar can be > located different than the derbyclient.jar It can be easier if we have jvm > version information and path of derby.jar are in the derby.log -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
