[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257251#comment-13257251 ] Myrna van Lunteren commented on DERBY-4869: --- Can this issue now be closed? Or is there still more work to be done? Rick, looks like you planned to describe the remaining work as indicated on 2/Sep/11 - was that DERBY-5488 or something else? > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > PSTimeout_execute.java, derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, > derby-4869_Statement_addBatch_execute_etc.dif, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095821#comment-13095821 ] Kristian Waagan commented on DERBY-4869: What's the state of this issue? It has the patch available flag set, but hasn't seen any action for several months. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > PSTimeout_execute.java, derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, > derby-4869_Statement_addBatch_execute_etc.dif, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015508#comment-13015508 ] Lily Wei commented on DERBY-4869: - Thank you so much Knut. I see testAddBatchClarification_jdbc4_1 in StatementJdbc20Test has addBatch test for Jdbc 4.1 I also see tests for execute(String, int), execute(String, int[]), execute(String, String[]), executeUpdate(String, int), executeUpdate(String, int[]), and executeUpdate(String, String[]) are in StatementJdbc20Test. I update wiki page JdbcFourOneTesting http://wiki.apache.org/db-derby/JdbcFourOneTesting to reflect the reality. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > PSTimeout_execute.java, derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, > derby-4869_Statement_addBatch_execute_etc.dif, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015315#comment-13015315 ] Knut Anders Hatlen commented on DERBY-4869: --- Hi Lily, I think this is already covered by the test case testAddBatchClarification_jdbc4_1 that Rick added to StatementJdbc20Test. testaddBatchNotImplemented() in the patch seems to be a subset of that test case. I'm not so familiar with the UnsupportedVetter test, but it looks to me like the patch adds those two methods to the list of methods to exclude from testing, so I don't think that change will increase the test coverage. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > PSTimeout_execute.java, derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, > derby-4869_Statement_addBatch_execute_etc.dif, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011309#comment-13011309 ] Lily Wei commented on DERBY-4869: - Thank you so much for verify Derby behavior is within specification. Nothing gets away from you. :-) > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > PSTimeout_execute.java, derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011282#comment-13011282 ] Knut Anders Hatlen commented on DERBY-4869: --- Hi Lily, The 19 to 21 seconds include a call to execute() and many calls to ResultSet.next(). The SQLTimeoutException isn't thrown until one of these needs more than 5 seconds to complete. When I ran PSTimeout_execute in my environment, the next() call that threw the exception was stopped after 5008 ms. I think this behaviour is within specification. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > PSTimeout_execute.java, derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010611#comment-13010611 ] Knut Anders Hatlen commented on DERBY-4869: --- Hi Lily, I think you're right that the problem you're seeing is the same as DERBY-4863. The PSTimeout class is more or less identical to the repro attached to that issue. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, PSTimeout.java, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-33_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008995#comment-13008995 ] Lily Wei commented on DERBY-4869: - Thanks Knut for removing the compiler warnings. Those lines are meant to throw CNFE so the test will fail. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008993#comment-13008993 ] Knut Anders Hatlen commented on DERBY-4869: --- Committed "fix-compiler-warning.diff" with revision 1083628. I'm wondering, though, if the call to put() on the map returned by getTypeMap() in the new test case is valid. When using the JDBC 3.0 or earlier variants of the Connection class, the returned map is immutable, and put() will throw an exception. With the JDBC 4.0 driver, the map is mutable, but I think that is just an unintended side effect of a hack used to silence a compiler warning. I've logged DERBY-5143 to track this difference between the JDBC 3.0 driver and the JDBC 4.0 driver. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > fix-compiler-warning.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008986#comment-13008986
]
Knut Anders Hatlen commented on DERBY-4869:
---
I didn't quite understand this part of the test:
+Map> map = getConnection().getTypeMap();
+try {
+ map.put("JAVA_UTIL_LIST", Class.forName("java.util.List"));
+} catch (ClassNotFoundException se) {
+se.printStackTrace();
+println("map.put has exception");
+}
Is this code supposed to raise a ClassNotFoundException? If yes, I think there
should be a call to fail() in the try block, and the stack trace shouldn't be
printed. If no, I think the CNFE should be thrown so that the test fails.
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
>Assignee: Rick Hillegas
> Attachments: Drv41.java, JDBC_4.1_Changes.html,
> derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff,
> derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff,
> derby-4869-04-aa-rs-getObject-simplification.diff,
> derby-4869-05-aa-rs-getObject-exception.diff,
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff,
> derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff,
> derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff,
> derby-4869-11-aa-abortHidePrivates.diff,
> derby-4869-12-aa-xaAndPooledAborts.diff,
> derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff,
> derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff,
> derby-4869-16-aa-clarifyStatementSpec.diff,
> derby-4869-17-aa-statementTimeoutException.diff,
> derby-4869-18-aa-getSetSchema.diff,
> derby-4869-19-aa-getSetNetworkTimeout.diff,
> derby-4869-20-aa-setSchemaFastPath.diff,
> derby-4869-21-aa-implicitlyClosedResultSets.diff,
> derby-4869-21-ab-implicitlyClosedResultSets.diff,
> derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff,
> derby-4869-24-ab-getParentLogger.diff,
> derby-4869-25-aa-removeClosureCheck.diff,
> derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff,
> derby-4869-28-ab-autoloadExceptionFactory.diff,
> derby-4869-29-aa-fixAutoloadTest.diff,
> derby-4869-30-aa-unstableStatementTest.diff,
> derby-4869-31-aa-unstableStatementTest.diff,
> derby-4869-31-ab-unstableStatementTest.diff,
> derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff,
> derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008630#comment-13008630 ] Lily Wei commented on DERBY-4869: - Thanks Rick!!! Sure, I will add the extra information and note that CallableStatement.getObject(String,Class) raises an unsupported feature exception just like the String overloads of the other getXXX() methods. And, I will also add to Connection.setTypeMap(map) for extra testing added and be the owner for that entry. If there is no objection, I will checkin the best before today. Thanks! > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008560#comment-13008560 ] Rick Hillegas commented on DERBY-4869: -- Thanks for supplying the extra test, Lily. I think it would be appropriate to add the following information to the wiki page (you are welcome to add it): 1) It would be helpful if the entry for CallableStatement.getObject(String,Class) noted that that overload raises an unsupported feature exception just like the String overloads of the other getXXX() methods. You could also note on the Connection.setTypeMap() entry that you have added a test which was missed during the JDBC 4.0 effort. You're welcome to add yourself as the owner of that entry. Thanks. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-32_add_CallableStatement_Connection_getTypeMap_test.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996025#comment-12996025 ] Kathey Marsden commented on DERBY-4869: --- Thank you Rick. I will look into that property. Maybe it can help me turn off my least favorite feature, the Autoloader at user sites if it overrides the manifest. Perhaps the deregister attribute will be helpful in the phone environment you describe or somethng else new, but I do not think that we can forget that there are lots of production systems using derby in app servers with isolated class loaders where the unloading is critical and we can't regress the unloading again. Tracking down class loader leaks is just too painful. I wonder if now that DERBY-2905 is fixed if the permgen errors we have been seeing on some platforms are fixed now. I should try on my mac again and file a test issue to have formal test to make Derby is fully garbage collected after shutdown. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995973#comment-12995973 ] Rick Hillegas commented on DERBY-4869: -- I believe that we support the property-based autoloading now. There is a lot of trickiness in here. The JRE's autoloading contract is tricky and Derby's boot/shutdown logic is tricky. We are probably not out of the woods yet. I have misgivings about the original Derby design which makes ComponentUnloading an artifact of OrderlyShutdown. The reverse order makes more sense to me, particularly for smartphones. In that environment, a resource-intensive service like a database may be swapped out frequently in order to make the device responsive. I think that it is tricky to make both orders work. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995962#comment-12995962 ] Kathey Marsden commented on DERBY-4869: --- Thank you Rick. That does clarify things alot. I did not know there was any autoloader capability in JDK 1.4. Do we support that property now? I think where things have gotten hairy with the Autoloader is that, if I am not mistaken, the AutoloadedDriver loads even with the DataSources and that is why DERBY-2905 became such an issue for Tomcat users and other app servers that don't use DriverManager at all and then since DriverManager only loads it the first time, there is some sort of odd incongruity that I can't quite put into words. I think that the behavior and the interfaces we have now are good, but hope with some thought we can find a way to make the code simpler and more intuitive per Dan's comment here: https://issues.apache.org/jira/browse/DERBY-2905?focusedCommentId=12537404&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12537404 I really appreciate the clarification of the current model. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995957#comment-12995957 ] Lily Wei commented on DERBY-4869: - Thanks Rick. These are very important information. May I suggest to add them in the comments on AutoloadedDriver and AutoloadedDriver40. If the autoloading part is confusing for us, maybe we can add comment for this to ease the future confusion. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995945#comment-12995945 ] Rick Hillegas commented on DERBY-4869: -- For two reasons: I) We simply followed the pattern described in (c) above: JDBC 4.0 did not introduce any methods into java.sql.Driver that prevented implementations from being compiled on JDK 1.4. There was therefore no reason for DriverManager.getDriver() to return 2 different classes, one for Java 5 and lower and another for Java 6 and higher. Now, of course, there is a reason to do that. 2) Driver autoloading actually goes back to JDK 1.4. It's just that Java 6 introduced a new kind of driver autoloading. And Derby was out of compliance by not supporting the JDK 1.4 version of autoloading. The JDK 1.4 version of autoloading involves setting a system property which is a list of Drivers which should be autoloaded. The property is set when you boot the VM. It is described here: http://download.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/drivermanager.html Hope this helps, -Rick > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995914#comment-12995914 ] Kathey Marsden commented on DERBY-4869: --- I think where I am fundamentally confused why is AutoloadedDriver needed for Java 5 when the Autoloaded Driver feature was not introduced until Java 6? > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995895#comment-12995895 ] Rick Hillegas commented on DERBY-4869: -- a) AutoloadedDriver is needed for Java 5 and lower. It can't contain the getParentLogger() method because that method raises an exception which is only present in Java 6 and up. b) AutoloadedDriver40 is needed for Java 7 and up. On Java 7, the driver returned by DriverManager.getDriver( "jdbc:derby" ) must implement getParentLogger(). c) The remaining question is: which class do we use on Java 6? We have followed the existing pattern in the code by running the most capable class possible. Since the signature of getParentLogger() can be compiled on Java 6, we use the more capable version on that platform. Does one of the above statements not make sense? Thanks, -Rick > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995889#comment-12995889 ] Kathey Marsden commented on DERBY-4869: --- Why are two needed? AutoloadedDriver and AutoloadedDriver40. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995825#comment-12995825 ] Knut Anders Hatlen commented on DERBY-4869: --- That's a good point. We could probably make the manifest reference AutoloadedDriver40 directly to remove one level of indirection now, but that's doesn't sound very important. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995800#comment-12995800 ] Rick Hillegas commented on DERBY-4869: -- I don't think the name is so bad: AutoloadedDriver is the driver which is cited in the jar manifest--that gives it a good claim to the name. No argument that there is a lot of confusion in this part of the code though. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995741#comment-12995741 ] Knut Anders Hatlen commented on DERBY-4869: --- I guess the confusion here is that AutoloadedDriver isn't necessarily auto-loaded and so the name was a bit misleading from the beginning. With the introduction of the AutoloadedDriver40 class, the name becomes even more misleading, since AutoloadedDriver won't ever be auto-loaded. On platforms that do support auto-loading, it's AutoloadedDriver40 that will be picked, if I've understood correctly. So perhaps we should rename AutoloadedDriver to ManuallyLoadedDriver? :P > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995305#comment-12995305 ] Rick Hillegas commented on DERBY-4869: -- Hi Kathey, Those are good questions. Before answering them, let me first list a couple facts: 1) The AutoloadedDriver is the embedded driver which is registered with the DriverManager. When it was introduced, it is what was registered with DriverManager regardless of what VM you were using. It was used for JDK 1.4 on up. 2) The new getParentLogger() method raises a SQLFeatureNotSupportedException. This exception was introduced in Java 6. A method which raises this exception can't be compiled on Java 5 or lower. 3) As part of satisfying the JDBC 4.1 contract, when running on Java 7 or higher, the new getParentLogger() method must be found in the driver returned by DriverManager.getDriver( "jdbc:derby" ). Two options occurred: i) Put getParentLogger() in AutoloadedDriver but don't raise SQLFeatureNotSupportedException. This would mean actually implementing the Logger idiom for writing error messages and diagnostics. I have created DERBY-5007 to track this enhancement. It is an attractive feature but it is a mini-project and not part of JDBC 4.1. If we do get around to implementing DERBY-5007, then getParentLogger() will no longer have to raise SQLFeatureNotSupportedException. We can then move it down to AutoloadedDriver and remove the AutoloadedDriver40 class. ii) The other option was to add a new AutoloadedDriver subclass to hold the new getParentLogger() method. This is the option I chose. The new subclass is called AutoloadedDriver40 because it is used if you are running on Java 6 on up (that is at JDBC level 4.0 or greater). This follows the general pattern of our JDBC implementation: When a new rev of the JDBC spec adds a method which COULD run on older VMs, we try to put the new method in the lowest level driver for which it can be compiled. You will notice that a great deal of our JDBC 3 and JDBC 4 functionality was actually pushed down into our JDBC 2 drivers. I hope this makes sense. Please ask more questions if it doesn't. Thanks, -Rick > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995104#comment-12995104 ] Kathey Marsden commented on DERBY-4869: --- I have a question about AutoLoadedDriver vs AutoLoadedDriver40. I think the autoloaded driver concept was new with JDBC 4.0, so I was curious about why a new AutoLoadedDriver40 was created last week in revision 1067954 [1] in addition to the existing AutoloadedDriver for the getParentLogger() functionality (JDBC 4.1). Isn't any AutoloadedDriver JDBC 4.x? Why do we need two or if we do need two, why isn't the new one AutoLoadedDriver41? Thanks Kathey [1] http://svn.apache.org/viewvc?view=revision&revision=1067954 > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994310#comment-12994310 ] Rick Hillegas commented on DERBY-4869: -- Thanks for test-driving the patch, Knut. I have checked it in at subversion revision 1070504. Crossing my fingers and whistling a happy tune. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994305#comment-12994305 ] Knut Anders Hatlen commented on DERBY-4869: --- I'm still having difficulties reproducing the test failure after modifying the test to fail if it doesn't get a timeout on the first attempt. On the bright side, I'm having the same difficulties reproducing it with the patch, so at least there's no indication that the patch makes it any worse. It's probably worth checking it in to see if it improves the stability in the nightly runs. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-31-ab-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993439#comment-12993439 ] Knut Anders Hatlen commented on DERBY-4869: --- Hi Rick, On a machine that has shown this failure in the nightly tests (the SUSE box), I ran the test 100 times successfully without your fix, so I'm not sure how to reproduce it easily. I'm not sure, though, if the essence of the comment is that the query should return more than one row. My understanding is that the MOD function is used to force one next() call to consider multiple rows before it returns. The MOD function in that query makes next() have to consider three rows because only every third row qualifies. It may also be significant that the second argument to the delay function is a reference to a column, so that the function has to be invoked for every row. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-31-aa-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992716#comment-12992716 ] Knut Anders Hatlen commented on DERBY-4869: --- Maybe this comment in SetQueryTimeoutTest gives a hint as to how we can stabilize the test? /** * The reason for using the mod function here is to force * at least one invocation of ResultSet.next() to read * more than one row from the table before returning. * This is necessary since timeout is checked only when * reading rows from base tables, and when the first row * is read, the query still has not exceeded the timeout. */ return "select a from " + tablePrefix + "_orig where mod(DELAY(1,a),3)=0"; > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, > derby-4869-30-aa-unstableStatementTest.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992232#comment-12992232 ] Knut Anders Hatlen commented on DERBY-4869: --- The query timeout test has failed in the last two test cycles on both Solaris 10 x86 and Windows 2003. In the last test cycle it also failed on SUSE and Solaris 10 SPARC. So I don't think the frequency of the failures has gone down much. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992177#comment-12992177 ] Rick Hillegas commented on DERBY-4869: -- Hi Knut: Concerning the query timeout failures on Solaris, has the frequency of the failures gone down? Thanks. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-26-aa-signatureTests.diff, derby-4869-27-aa-driver40.diff, > derby-4869-28-ab-autoloadExceptionFactory.diff, > derby-4869-29-aa-fixAutoloadTest.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991602#comment-12991602 ] Rick Hillegas commented on DERBY-4869: -- The second issue raised by Knut (AbstractMethodError thrown after reloading the engine) is fixed by my previous submission (the addition of getParentLogger() to Driver40). It seems that the work on DERBY-2905 has resulted in a Driver40 being registered when you reload the engine. Before the work on DERBY-2905, the engine reload would re-register AutoloadedDriver. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, derby-4869-27-aa-driver40.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991476#comment-12991476 ] Knut Anders Hatlen commented on DERBY-4869: --- The fix for the instability in StatementTest.test_jdbc4_1_queryTimeoutException() doesn't seem to be quite enough. It's still failing sometimes in the nightly tests: http://dbtg.foundry.sun.com/derby/test/Daily/jvm1.6/testing/testlog/sol32/1067702-suitesAll_diff.txt > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991444#comment-12991444 ] Rick Hillegas commented on DERBY-4869: -- Thanks, Knut. I will take a look at those issues. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: Drv41.java, JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, > derby-4869-25-aa-removeClosureCheck.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991426#comment-12991426
]
Knut Anders Hatlen commented on DERBY-4869:
---
Hi Rick,
The following code causes a ClassCastException in my environment:
Driver d1 = DriverManager.getDriver("jdbc:derby:db");
System.out.println(d1);
try {
d1.getParentLogger();
System.out.println("what?!?");
} catch (SQLFeatureNotSupportedException ex) {
// expected
}
Exception in thread "main" java.lang.ClassCastException:
org.apache.derby.impl.jdbc.EmbedSQLException cannot be cast to
java.sql.SQLFeatureNotSupportedException
at
org.apache.derby.jdbc.AutoloadedDriver40.getParentLogger(AutoloadedDriver40.java:48)
at Drv41.main(Drv41.java:7)
It does not fail if I add Class.forName("org.apache.derby.jdbc.EmbeddedDriver")
before the call to DriverManager.getDriver(), only when I use the auto-loaded
driver.
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
>Assignee: Rick Hillegas
> Attachments: JDBC_4.1_Changes.html,
> derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff,
> derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff,
> derby-4869-04-aa-rs-getObject-simplification.diff,
> derby-4869-05-aa-rs-getObject-exception.diff,
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff,
> derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff,
> derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff,
> derby-4869-11-aa-abortHidePrivates.diff,
> derby-4869-12-aa-xaAndPooledAborts.diff,
> derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff,
> derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff,
> derby-4869-16-aa-clarifyStatementSpec.diff,
> derby-4869-17-aa-statementTimeoutException.diff,
> derby-4869-18-aa-getSetSchema.diff,
> derby-4869-19-aa-getSetNetworkTimeout.diff,
> derby-4869-20-aa-setSchemaFastPath.diff,
> derby-4869-21-aa-implicitlyClosedResultSets.diff,
> derby-4869-21-ab-implicitlyClosedResultSets.diff,
> derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff,
> derby-4869-24-ab-getParentLogger.diff, derby-4869-exp-01-aa-noTryCatch.diff,
> disable-tests.diff, timezone.diff
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991402#comment-12991402 ] Rick Hillegas commented on DERBY-4869: -- Committed derby-4869-24-ab-getParentLogger.diff at subversion revision 1067954. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990879#comment-12990879 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-24-ab-getParentLogger.diff except for known heisenbugs in testPing and InvalidLDAPServerAuthenticationTest. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-24-ab-getParentLogger.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989652#comment-12989652 ] Rick Hillegas commented on DERBY-4869: -- Thanks, Knut. I will confirm with Lance Andersen about whether the Derby behavior for the other methods is acceptable. If so, then I agree that consistency is a good idea. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989651#comment-12989651 ] Knut Anders Hatlen commented on DERBY-4869: --- The set/getNetworkTimeout patch makes the new unsupported methods throw different exceptions depending on whether or not the connection is closed. Other methods that we don't implement throw SQLFeatureNotSupportedException unconditionally, see for example createArrayOf(), createNClob(), createSQLXML() and createStruct() in the Connection classes. For consistency, we should probably make setNetworkTimeout() and getNetworkTimeout() do the same. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989369#comment-12989369 ] Dag H. Wanvik commented on DERBY-4869: -- Thanks, Rick! Looks like a good solution to me. +1 Nit: some lines >Â 80 columns. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989315#comment-12989315 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-21-ab-implicitlyClosedResultSets.diff. Committed at subversion revision 1066127. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-21-ab-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988826#comment-12988826 ] Dag H. Wanvik commented on DERBY-4869: -- Right, sorry I forgot to specify holdability, you are correct of course. I think we need somehow to move to let statement be driven from the actual rs/cursor being closed as you tried initially..? > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988807#comment-12988807 ] Rick Hillegas commented on DERBY-4869: -- Thanks for that problem case, Dag. I am able to reproduce your results when I direct the Connection to close cursors at commit time: conn.setHoldability( ResultSet.CLOSE_CURSORS_AT_COMMIT ); Without that directive, the cursors and the statement remain open (that seems correct). I agree that the client/server behavior looks wrong when CLOSE_CURSORS_AT_COMMIT is set. Thanks. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: JDBC_4.1_Changes.html, > derby-4869-01-ac-rs-getObject.diff, derby-4869-01-ad-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988267#action_12988267 ] Dag H. Wanvik commented on DERBY-4869: -- Am I correct that this test code should work as well? It does work on embedded, but fails in c/s.. conn.setAutoCommit( false ); ps = conn.prepareStatement( "values ( 1 )" ); println( "Testing implicit closure on a " + ps.getClass().getName() + " with autocommit==false"); wrapper = new Wrapper41Statement( ps ); wrapper.closeOnCompletion(); rs = ps.executeQuery(); rs.next(); rs.next(); assertFalse( rs.isClosed() ); assertFalse( ps.isClosed() ); < FAILS in C/S mode conn.commit(); assertTrue( rs.isClosed() ); assertTrue( ps.isClosed() ); > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988224#action_12988224 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on the JDBC 4.1 changes to DatabaseMetaData. Committed derby-4869-23-aa-dbmd.diff at subversion revision 1064868. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988222#action_12988222 ] Dag H. Wanvik commented on DERBY-4869: -- Right, indirect call then. So net layer is calling up into am in reply to a client commit request which was acknowledged by the server (case CodePoint.RDBCMM:), so the client needs to mark its result set closed, too. Sounds like a typical "callback" action to me. Not sure how you could avoid that as long as state is kept on the am level, too. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988200#action_12988200 ] Rick Hillegas commented on DERBY-4869: -- Thanks for helping me puzzle through this, Dag. Here is the stack trace I saw: at java.lang.Thread.dumpStack(Thread.java:1230) at org.apache.derby.client.am.ResultSet.markClosed(ResultSet.java:4420) at org.apache.derby.client.am.ResultSet.markClosed(ResultSet.java:4408) at org.apache.derby.client.am.ResultSet.completeLocalCommit(ResultSet.java:4365) at org.apache.derby.client.am.Connection.completeLocalCommit(Connection.java:2026) at org.apache.derby.client.net.NetConnectionReply.parseENDUOWRM(NetConnectionReply.java:789) at org.apache.derby.client.net.NetConnectionReply.parseRDBCMMreply(NetConnectionReply.java:198) at org.apache.derby.client.net.NetConnectionReply.readLocalCommit(NetConnectionReply.java:135) at org.apache.derby.client.net.ConnectionReply.readLocalCommit(ConnectionReply.java:43) at org.apache.derby.client.net.NetConnection.readLocalCommit_(NetConnection.java:1507) at org.apache.derby.client.am.Connection.readCommit(Connection.java:640) at org.apache.derby.client.am.Connection.flowCommit(Connection.java:589) at org.apache.derby.client.am.Connection.flowAutoCommit(Connection.java:598) at org.apache.derby.client.am.Statement.resultSetCommitting(Statement.java:3009) at org.apache.derby.client.am.Statement.resultSetCommitting(Statement.java:2969) at org.apache.derby.client.am.ResultSet.nextX(ResultSet.java:361) at org.apache.derby.client.am.ResultSet.next(ResultSet.java:282) > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988194#action_12988194 ] Dag H. Wanvik commented on DERBY-4869: -- >I have misgivings about the change to the network ResultSet. I think that the >Statement-closing trigger should be placed in the markClosed() method. >However, when I put the trigger there, I see protocol errors. It seems that >that method is called from inside the network protocol itself. How does markClosed get called from inside the network layer? I searched for usages there, but I didn't see any.. I found usages from Connection, ResultSet, Statement and PrepareStatement (all on am level).. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-20-aa-setSchemaFastPath.diff, > derby-4869-21-aa-implicitlyClosedResultSets.diff, > derby-4869-22-aa-unstableStatementTest.diff, derby-4869-23-aa-dbmd.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987156#action_12987156 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-19-aa-getSetNetworkTimeout.diff. Committed at subversion revision 1063822. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, > derby-4869-19-aa-getSetNetworkTimeout.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987079#action_12987079 ] Rick Hillegas commented on DERBY-4869: -- Thanks, Knut. Those sound like good improvements to me. I will address them in a follow-on patch. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987026#action_12987026 ] Knut Anders Hatlen commented on DERBY-4869: --- On the client side, the connection has the current schema cached in most cases. Would it make sense to let the client version of setSchema() check the cached value if it exists and do nothing if the new schema is the same as the old one? The use case I'm thinking about is applications that start each chunk of work with setting the schema. And some nits: - The try-finally-close code in the setSchema() methods could be simplified by moving the call to prepareStatement() out of the try block and up to the declaration of the ps variable. Then the ps could be closed unconditionally in the finally block. - The new methods are indented with a mix of tabs and blanks. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987011#action_12987011 ] Rick Hillegas commented on DERBY-4869: -- Committed derby-4869-18-aa-getSetSchema.diff at subversion revision 1063723. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986669#action_12986669 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me derby-4869-18-aa-getSetSchema.diff except for the Heisenbug in InvalidLDAPServerAuthenticationTest. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-18-aa-getSetSchema.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986398#action_12986398 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-17-aa-statementTimeoutException.diff except for Heisenbugs in testPing and InvalidLDAPServerAuthenticationTest. Committed at subversion revision 1063295. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-17-aa-statementTimeoutException.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985742#action_12985742 ] Dag H. Wanvik commented on DERBY-4869: -- Looked at the spec vs derby-4869-16-aa-clarifyStatementSpec.diff. Looks good to me. +1 > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-16-aa-clarifyStatementSpec.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984887#action_12984887 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-15-aa-autoGenKeys.diff. Committed at subversion revision 1061977. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas >Assignee: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984755#action_12984755 ] Rick Hillegas commented on DERBY-4869: -- The tests ran cleanly for me except for 3 errors. 2 of the errors were familiar heisenbugs in testPing and ManagementMBeanTest. The third error I have not seen before: 2) testInvalidLDAPServerConnectionError(org.apache.derbyTesting.functionTests.tests.jdbcapi.InvalidLDAPServerAuthenticationTest)junit.framework.AssertionFailedError at org.apache.derbyTesting.functionTests.tests.jdbcapi.InvalidLDAPServerAuthenticationTest.testInvalidLDAPServerConnectionError(InvalidLDAPServerAuthenticationTest.java:122) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:110) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) This error seems very far away from the code I touched. The test ran cleanly when I ran it standalone. I am inclined to regard this as another heisenbug in the tests. Committed derby-4869-14-ac-closeOnCompletion.diff at subversion revision 1061824. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, > derby-4869-11-aa-abortHidePrivates.diff, > derby-4869-12-aa-xaAndPooledAborts.diff, > derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, > derby-4869-14-ac-closeOnCompletion.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983277#action_12983277 ] Rick Hillegas commented on DERBY-4869: -- Thanks for noticing that Knut. I'll give some thought to hiding that behavior. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983271#action_12983271 ] Knut Anders Hatlen commented on DERBY-4869: --- With the public run() and beginAborting() methods, couldn't malicious code bypass the SQLPermission check by doing something like ((EmbedConnection) conn).beginAborting(); executor.execute((Runnable) conn); ? > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983231#action_12983231 ] Rick Hillegas commented on DERBY-4869: -- Tests ran cleanly for me. Committed derby-4869-09-ac-abort.diff at subversion revision 1060422. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-09-ac-abort.diff, derby-4869-exp-01-aa-noTryCatch.diff, > disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981889#action_12981889 ] Rick Hillegas commented on DERBY-4869: -- All righty then. My previous comment was a little muddled. This is the shape of something that actually works: 1) SQLPermission( "callAbort" ) must be granted to derby.jar and to derbyclient.jar. Note, however, that Derby's implementations of abort(Executor) are not wrapped in doPrivileged blocks. That means that outer (application) code domains are NOT absolved of the need to be granted this permission also. The application designer controls who can call this method by only granting this permission to tools used by superusers. 2) Our JDBC documentation in the Reference Guide should explain the need to grant this permission both to Derby and to the superuser tools. 3) We will need to make similar statements in the Developer's Guide in the section titled "Running Derby under a security manager". > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
+1 On Jan 13, 2011, at 3:20 PM, Rick Hillegas (JIRA) wrote: > >[ > https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981458#action_12981458 > ] > > Rick Hillegas commented on DERBY-4869: > -- > > JDBC 4.1 adds a new method to Connecton: abort(Executor). This method > attempts to terminate the Connection and release its resources. If a > SecurityManager is in place, the new method expects that SQLPermission( > "callAbort" ) ) will have been granted to the abort() method. I believe that > the motivation for this permission is to prevent an ordinary user of a pooled > connection from accidentally destroying the underlying physical connection to > the database, since that is one of the consequences of calling abort(). Only > privileged code would be allowed to intervene and abort runaway connections. > > I think that we should document how to grant this permission, probably in the > JDBC section of the Reference Guide. > > I also think that our default and template security policies should not grant > this permission to any of the Derby code domains. My sense right now is that > the permission should be granted to an outer application code domain only > accessed by superusers. > > Other or concurring opinions? > > Thanks, > -Rick > > >> Implement JDBC 4.1, the api increment introduced by Java 7 >> -- >> >>Key: DERBY-4869 >>URL: https://issues.apache.org/jira/browse/DERBY-4869 >>Project: Derby >> Issue Type: Improvement >> Components: JDBC >> Reporter: Rick Hillegas >>Attachments: derby-4869-01-ac-rs-getObject.diff, >> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, >> derby-4869-02-ab-cs-ps-addBatch.diff, >> derby-4869-03-aa-rs-getObject-errorCleanup.diff, >> derby-4869-04-aa-rs-getObject-simplification.diff, >> derby-4869-05-aa-rs-getObject-exception.diff, >> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, >> derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, >> derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, >> JDBC_4.1_Changes.html, timezone.diff >> >> >> This is a master issue logged to track our work implementing JDBC 4.1, the >> changes to the java.sql and javax.sql packages introduced by Java 7. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] Oracle is committed to developing practices and products that help protect the environment
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981458#action_12981458 ] Rick Hillegas commented on DERBY-4869: -- JDBC 4.1 adds a new method to Connecton: abort(Executor). This method attempts to terminate the Connection and release its resources. If a SecurityManager is in place, the new method expects that SQLPermission( "callAbort" ) ) will have been granted to the abort() method. I believe that the motivation for this permission is to prevent an ordinary user of a pooled connection from accidentally destroying the underlying physical connection to the database, since that is one of the consequences of calling abort(). Only privileged code would be allowed to intervene and abort runaway connections. I think that we should document how to grant this permission, probably in the JDBC section of the Reference Guide. I also think that our default and template security policies should not grant this permission to any of the Derby code domains. My sense right now is that the permission should be granted to an outer application code domain only accessed by superusers. Other or concurring opinions? Thanks, -Rick > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981249#action_12981249 ] Rick Hillegas commented on DERBY-4869: -- Thanks, Knut. ResultSetTest and CallableStatementTest pass cleanly now. Committed derby-4869-exp-01-aa-noTryCatch.diff at subversion revision 1058554. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981200#action_12981200 ] Knut Anders Hatlen commented on DERBY-4869: --- Now that DERBY-4970 has been fixed I don't see any failures with the noTryCatch patch, so I think it would be fine to check it in. Thanks. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980762#action_12980762 ] Knut Anders Hatlen commented on DERBY-4869: --- Thanks for trying it out, Rick. It sounds like a bug that a getXXX() method throws a ClassCastException instead of an SQLException, so I filed DERBY-4970 to track it. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, > derby-4869-exp-01-aa-noTryCatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1298#action_1298
]
Knut Anders Hatlen commented on DERBY-4869:
---
The null-handling patch looks fine to me. Thanks, Rick!
Two tiny nits:
- In the catch-all case where we call getObject(int), we now have a redundant
call to Class.cast()
- Since there's only one place where we do a cast now, the try/catch that
ignores ClassCastException could be narrowed down to enclose that single line
only. And probably a little comment explaining why we ignore the exception is
in order. Alternatively, the intention of the code may be clearer if we remove
the try/catch altogether and instead do an explicit check, something like
if (retval == null || type.isInstance(retval)) {
return type.cast(retval);
}
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
> Attachments: derby-4869-01-ac-rs-getObject.diff,
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff,
> derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff,
> derby-4869-04-aa-rs-getObject-simplification.diff,
> derby-4869-05-aa-rs-getObject-exception.diff,
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff,
> derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff,
> disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977271#action_12977271 ] Rick Hillegas commented on DERBY-4869: -- Thanks for the comments and the test-tweaking, Knut. I agree that the treatment of nulls looks wrong. I will try your suggestion for suppressing the suppression annotation too. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > derby-4869-07-aa-timedisplacement.diff, disable-tests.diff, > JDBC_4.1_Changes.html, timezone.diff > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976970#action_12976970
]
Knut Anders Hatlen commented on DERBY-4869:
---
All the new getObject() methods are annotated with
@SuppressWarnings("unchecked"), presumably because they contain unchecked casts
like this:
if ( String.class.equals( type ) ) { return (T) getString(
parameterIndex ); }
I'm wondering if it might be worthwhile to restructure the methods slightly and
make the casts checked, so that we don't need to suppress warnings. Something
like this would silence the warnings, I think:
Object ret;
if (String.class.equals(type)) {
ret = getString(parameterIndex);
} else if (Integer.class.equals(type)) {
ret = getInt(parameterIndex);
} else if () {
} else {
ret = getObject(parameterIndex);
}
return type.cast(ret);
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
> Attachments: derby-4869-01-ac-rs-getObject.diff,
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff,
> derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff,
> derby-4869-04-aa-rs-getObject-simplification.diff,
> derby-4869-05-aa-rs-getObject-exception.diff,
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff,
> derby-4869-07-aa-timedisplacement.diff, disable-tests.diff,
> JDBC_4.1_Changes.html
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976964#action_12976964
]
Knut Anders Hatlen commented on DERBY-4869:
---
The getObject() methods don't seem to handle NULL values correctly. Take this
code:
ResultSet rs = s.executeQuery("values cast(null as integer)");
rs.next();
System.out.println(rs.getObject(1, Integer.class));
It prints "0", but I think it should have printed "null".
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
> Attachments: derby-4869-01-ac-rs-getObject.diff,
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff,
> derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff,
> derby-4869-04-aa-rs-getObject-simplification.diff,
> derby-4869-05-aa-rs-getObject-exception.diff,
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff,
> derby-4869-07-aa-timedisplacement.diff, disable-tests.diff,
> JDBC_4.1_Changes.html
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976869#action_12976869 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me except for the heisenbug in NetworkServerMBeanTest. Committed derby-4869-06-ab-cs-getObject.diff at subversion revision 1054706. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, > derby-4869-04-aa-rs-getObject-simplification.diff, > derby-4869-05-aa-rs-getObject-exception.diff, > derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, > disable-tests.diff, JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974474#action_12974474 ] Rick Hillegas commented on DERBY-4869: -- Thanks for pointing that out, Knut. I guess that means that I'll have to fix DERBY-4949 before I declare victory on this one. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974448#action_12974448
]
Knut Anders Hatlen commented on DERBY-4869:
---
Thanks, Rick. I agree that the ClassCastException doesn't provide much
additional information here.
One more issue: The catch clause in NetResultSet40 now catches all exceptions,
not only ClassCastException, which means it will handle all errors in the
getters as conversion errors. Take this example:
ResultSet rs = s.executeQuery("values cast ('abc' as clob)");
while (rs.next()) {
rs.getObject(1, Clob.class);
rs.getObject(1, Clob.class);
}
Here, the problem is that getClob() is called twice on the same column, but the
error reported is:
java.sql.SQLDataException: An attempt was made to get a data value of type
'java.sql.Clob' from a data value of type 'CLOB'.
The real problem is also reported, but that's hidden further down in the
exception chain:
...
Caused by: org.apache.derby.client.am.SqlException: An attempt was made to get
a data value of type 'java.sql.Clob' from a data value of type 'CLOB'.
...
Caused by: java.sql.SQLException: Stream or LOB value cannot be retrieved more
than once
...
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
> Attachments: derby-4869-01-ac-rs-getObject.diff,
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff,
> derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff, disable-tests.diff,
> JDBC_4.1_Changes.html
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974395#action_12974395 ] Rick Hillegas commented on DERBY-4869: -- I will try the simplification you recommend. In the network case, it was easy to pass the error from the getter to the factory method which makes the SQLException. In the embedded case, this would involve adding some new overloads of the corresponding factory methods. Those overloads didn't seem justified by this use case: the information in the swallowed ClassCastException seemed pretty vacuous. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, > derby-4869-03-aa-rs-getObject-errorCleanup.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974384#action_12974384
]
Knut Anders Hatlen commented on DERBY-4869:
---
In the last patch, NetResultSet40 preserves the ClassCastException whereas
EmbedResultSet40 doesn't. Any reason for this difference?
The following code...
+Object result = getObject( columnIndex );
+if ( !type.isInstance( result ) ) { throw new
ClassCastException( type.getName() ); }
+return (T) result;
...could be simplified to:
return type.cast(getObject(columnIndex));
The latter variant will also give a clearer error message (example: "Cannot
cast java.lang.Boolean to java.lang.Integer" vs just "java.lang.Integer").
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
> Attachments: derby-4869-01-ac-rs-getObject.diff,
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff,
> derby-4869-02-ab-cs-ps-addBatch.diff,
> derby-4869-03-aa-rs-getObject-errorCleanup.diff, disable-tests.diff,
> JDBC_4.1_Changes.html
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974253#action_12974253 ] Knut Anders Hatlen commented on DERBY-4869: --- Not only to get the correct subclass, by the way, but also to get the correct message text. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974250#action_12974250 ] Knut Anders Hatlen commented on DERBY-4869: --- Hi Rick, In the latest getObject() patch, SQLExceptions are created by calling the SQLException constructor directly. Shouldn't we use SQLExceptionFactory to get the correct subclass of SQLException? > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974242#action_12974242 ] Rick Hillegas commented on DERBY-4869: -- Compiler warning suppressed at subversion revision 1051947. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, > derby-4869-02-ab-cs-ps-addBatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
Hi Knut, Rick,
On Dec 22, 2010, at 6:02 AM, Knut Anders Hatlen (JIRA) wrote:
>
>[
> https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974148#action_12974148
> ]
>
> Knut Anders Hatlen commented on DERBY-4869:
> ---
>
> Hi Rick,
>
> I looked at the getObject() patch. Some possible improvements:
>
> - For byte[], instead of doing a Class.forName("[B"), I think you
> could check (type.isArray() && type.getComponentType().equals(byte.class)),
> which would remove the need for catching/ignoring ClassNotFoundException.
>
> - Would it make sense to try getObject() unconditionally if no other
> types match? Then the following code would work (I think) for most
> numeric column types:
>
>Number num = rs.getObject("VALUE", Number.class);
>
> - The API javadoc explicitly mentions that type==null should result in
> an SQLException. For completeness, add a test case for that?
Agree
>
> - The API javadoc for Boolean, Byte, Short, Integer, Long, Float and
> Double recommend the use of valueOf() instead of the constructor, as
> valueOf() "is likely to yield significantly better space and time
> performance".
This change should definitely be made as there is a big performance improvement
using valueOf
>
> - If the type conversion is not supported, an
> SQLFeatureNotSupportedException is thrown. As far as I understand
> the javadoc, this exception is reserved for the situation where the
> method is not supported by the JDBC driver, which is not the case
> here.
If the conversion is not supported, a SQLException should be thrown:
Throws:
SQLException - if conversion is not supported, type is null or another error
occurs. The getCause() method of the exception may provide a more detailed
exception, for example, if a conversion error occurs
SQLFeatureNotSupportedException - if the JDBC driver does not support this
method
>
> - The client implementation makes closeCloseFilterInputStream()
> non-private in order to call it from the new method. I think all the
> getters called from the new getObject() method will call
> closeCloseFilterInputStream(), so this code is probably not
> necessary.
>
>> Implement JDBC 4.1, the api increment introduced by Java 7
>> --
>>
>>Key: DERBY-4869
>>URL: https://issues.apache.org/jira/browse/DERBY-4869
>>Project: Derby
>> Issue Type: Improvement
>> Components: JDBC
>> Reporter: Rick Hillegas
>>Attachments: derby-4869-01-ac-rs-getObject.diff,
>> derby-4869-02-aa-cs-ps-addBatch.diff, disable-tests.diff,
>> JDBC_4.1_Changes.html
>>
>>
>> This is a master issue logged to track our work implementing JDBC 4.1, the
>> changes to the java.sql and javax.sql packages introduced by Java 7.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
Oracle is committed to developing practices and products that help
protect the environment
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974158#action_12974158 ] Knut Anders Hatlen commented on DERBY-4869: --- The addBatch() patch looks fine to me. One minor nit: The test could use the helper methods in prepareStatement() and prepareCall() in BaseJDBCTestCase. That would remove the need for calls to getConnection() and close(). > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974148#action_12974148
]
Knut Anders Hatlen commented on DERBY-4869:
---
Hi Rick,
I looked at the getObject() patch. Some possible improvements:
- For byte[], instead of doing a Class.forName("[B"), I think you
could check (type.isArray() && type.getComponentType().equals(byte.class)),
which would remove the need for catching/ignoring ClassNotFoundException.
- Would it make sense to try getObject() unconditionally if no other
types match? Then the following code would work (I think) for most
numeric column types:
Number num = rs.getObject("VALUE", Number.class);
- The API javadoc explicitly mentions that type==null should result in
an SQLException. For completeness, add a test case for that?
- The API javadoc for Boolean, Byte, Short, Integer, Long, Float and
Double recommend the use of valueOf() instead of the constructor, as
valueOf() "is likely to yield significantly better space and time
performance".
- If the type conversion is not supported, an
SQLFeatureNotSupportedException is thrown. As far as I understand
the javadoc, this exception is reserved for the situation where the
method is not supported by the JDBC driver, which is not the case
here.
- The client implementation makes closeCloseFilterInputStream()
non-private in order to call it from the new method. I think all the
getters called from the new getObject() method will call
closeCloseFilterInputStream(), so this code is probably not
necessary.
> Implement JDBC 4.1, the api increment introduced by Java 7
> --
>
> Key: DERBY-4869
> URL: https://issues.apache.org/jira/browse/DERBY-4869
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
>Reporter: Rick Hillegas
> Attachments: derby-4869-01-ac-rs-getObject.diff,
> derby-4869-02-aa-cs-ps-addBatch.diff, disable-tests.diff,
> JDBC_4.1_Changes.html
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the
> changes to the java.sql and javax.sql packages introduced by Java 7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973976#action_12973976 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-02-aa-cs-ps-addBatch.diff except for the testPing heisenbug. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, > derby-4869-02-aa-cs-ps-addBatch.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973856#action_12973856 ] Rick Hillegas commented on DERBY-4869: -- ResultSetTest passed cleanly for me on JDK 7 (build 122) on 64-bit x86 Solaris. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973807#action_12973807 ] Rick Hillegas commented on DERBY-4869: -- Tests passed cleanly for me on derby-4869-01-ac-rs-getObject.diff. > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: derby-4869-01-ac-rs-getObject.diff, disable-tests.diff, > JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972200#action_12972200 ] Rick Hillegas commented on DERBY-4869: -- The following wiki page tracks the progress of this master task: http://wiki.apache.org/db-derby/JdbcFourOne > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: disable-tests.diff, JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7
[ https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926286#action_12926286 ] Knut Anders Hatlen commented on DERBY-4869: --- I ran suites.All with 1.7.0-ea-b115 and saw that the following tests failed because they couldn't find implementations of all the methods in the java.sql.* interfaces: org.apache.derbyTesting.functionTests.tests.jdbc4.UnsupportedVetter org.apache.derbyTesting.functionTests.tests.jdbc4.VerifySignatures org.apache.derbyTesting.functionTests.tests.jdbcapi.ClosedObjectTest > Implement JDBC 4.1, the api increment introduced by Java 7 > -- > > Key: DERBY-4869 > URL: https://issues.apache.org/jira/browse/DERBY-4869 > Project: Derby > Issue Type: Improvement > Components: JDBC >Reporter: Rick Hillegas > Attachments: JDBC_4.1_Changes.html > > > This is a master issue logged to track our work implementing JDBC 4.1, the > changes to the java.sql and javax.sql packages introduced by Java 7. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
