[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-07-01 Thread Dag H. Wanvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dag H. Wanvik updated DERBY-4230:
-

Issue & fix info: [High Value Fix, Patch Available, Release Note Needed]  
(was: [Release Note Needed, Patch Available])

> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Fix For: 10.3.3.1, 10.4.2.1, 10.5.1.2, 10.6.0.0
>
> Attachments: create.sql, DERBY-4230_diff.txt, derby-4230_diff2.txt, 
> DERBY-4230_preview_diff.txt, releaseNote.html, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-30 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Attachment: releaseNote.html

Attaching release note.

> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Fix For: 10.3.3.1, 10.4.2.1, 10.5.1.2, 10.6.0.0
>
> Attachments: create.sql, DERBY-4230_diff.txt, derby-4230_diff2.txt, 
> DERBY-4230_preview_diff.txt, releaseNote.html, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-27 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Fix Version/s: 10.6.0.0

Committed to trunk  revision 779319.  I will leave open while I backport to 
10.5,10.4, and 10.3.



> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Fix For: 10.6.0.0
>
> Attachments: create.sql, DERBY-4230_diff.txt, derby-4230_diff2.txt, 
> DERBY-4230_preview_diff.txt, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-22 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Attachment: derby-4230_diff2.txt

Here is a follow up patch for this issue .  derby-4230_diff2.txt. It uses 
colInfos.length for the loop  as Knut orignally suggested, making the 
assumption that the generated columns come at the end.  Added a comment and an 
assertion if we are wrong in this assumption and hit a generated column in the 
expected visible range.

I ran lang.ViewsTest but haven't run the full regression suite yet.


> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Attachments: create.sql, DERBY-4230_diff.txt, derby-4230_diff2.txt, 
> DERBY-4230_preview_diff.txt, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-19 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Derby Info: [Patch Available, Regression, Release Note Needed]  (was: 
[Regression])

Marking patch available and release note needed since users will have to drop 
and recreate their  impacted view if it was created with a version of Derby 
with the bug.  I will attach a release note soon.


> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Attachments: create.sql, DERBY-4230_diff.txt, 
> DERBY-4230_preview_diff.txt, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-19 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Attachment: DERBY-4230_diff.txt

Attached is a patch for this issue (DERBY-4230_diff.txt) It is the same as the 
preview patch, but also has a test added.  I ran suites.All and derbyall which 
passed except for known intermittent issues.

Please review!



> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Attachments: create.sql, DERBY-4230_diff.txt, 
> DERBY-4230_preview_diff.txt, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-19 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Attachment: DERBY-4230_preview_diff.txt

Here is my initial attempt at a fix for this issue. 
DERBY-4230_preview_diff.txt.  This is *not* for commit as I still need to add a 
regression test and run tests.  I just thought I would put it out there to make 
sure I am on the right track.

The code that defines the columns for insert in to SYS.SYSCOLUMNS was including 
the generated columns. I changed it so that it no longer includes the generated 
columns and the test case passes.  Are the SYS.SYSCOLUMN entries for views only 
used for DatabaseMetaData.getColumns()  or is there some other use that might 
need the generated columns to be there?

Thanks

Kathey


> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
>Assignee: Kathey Marsden
> Attachments: create.sql, DERBY-4230_preview_diff.txt, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (DERBY-4230) DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

2009-05-14 Thread Kathey Marsden (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-4230:
--

Attachment: create.sql
ViewTest.java

> DatabaseMetaData.getColumns() returns extra column from view with group by 
> and  expression in SELECT list
> -
>
> Key: DERBY-4230
> URL: https://issues.apache.org/jira/browse/DERBY-4230
> Project: Derby
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 10.3.2.1
>Reporter: Kathey Marsden
> Attachments: create.sql, ViewTest.java
>
>
> DatabaseMetaData.getColumns() returns an extra column for a view with a group 
> by and an expression in the select list.  I will attach the reproduction. Run 
> the script create.sql and then the program ViewTest.
> This is a regression in version 10.3, It ran ok on latest on the 10.1 and 
> 10.2 branches.
> The ResultSetMetaData appears to return the correct number of columns  when 
> you select from the view, but it would be nice to add a regression test for 
> that too.
> See discussion on derby-dev.
> http://www.nabble.com/extra-column-in-DatabaseMetaData.getColumns()-with-group-by-in-view-td23545576.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.