[Bug 740506]

2016-03-05 Thread Carlos Garcia Campos
\o/ Great job guys! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to:

[Bug 1085526]

2016-03-05 Thread Carlos Garcia Campos
\o/ Great job guys! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go

[Bug 33288]

2016-02-20 Thread Carlos Garcia Campos
Comment on attachment 121848 Cache result of inner loop in visitDepthFirst Looks good to me, pushed. Thanks! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/33288 Title: Evince

[Bug 1242678]

2016-01-16 Thread Carlos Garcia Campos
As far as I remember the fix only worked for some versions of GS. Anyway, I'll try to find some time too look at this in detail again. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu.

[Bug 116453]

2015-01-27 Thread Carlos Garcia Campos
(In reply to Jason Crain from comment #6) I suppose if I add an option to findText, I should also add a flag (POPPLER_FIND_IGNORE_COMBINING?) to PopplerFindFlags, for the glib front end's poppler_page_find_text_with_options(). It would be nice if someone could confirm that evince would

[Bug 1242678]

2014-11-20 Thread Carlos Garcia Campos
(In reply to Pacho Ramos from comment #36) (In reply to Carlos Garcia Campos from comment #35) I've reverted the patch in master for now, until we find a proper solution. Do you know when a new tarball is planned including this and other fixes? Thanks No plans, but I can make a new release

[Bug 1242678]

2014-09-04 Thread Carlos Garcia Campos
Still doesn't work here, it seems to rotate the first page only of a multipage document. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS

[Bug 1242678]

2014-09-04 Thread Carlos Garcia Campos
I've reverted the patch in master for now, until we find a proper solution. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To

[Bug 1242678]

2014-08-14 Thread Carlos Garcia Campos
(In reply to comment #27) (In reply to comment #25) Created attachment 101589 [details] [review] [review] Change direction of rotation The promised patch. I'm not sure this should be done here or in evince. Libspectre should do what the PS spec says, if evince wants the opposite,

[Bug 1242678]

2014-08-14 Thread Carlos Garcia Campos
(In reply to comment #25) Created attachment 101589 [details] [review] Change direction of rotation The promised patch. I'm not sure this should be done here or in evince. Libspectre should do what the PS spec says, if evince wants the opposite, evince should do the conversion. Or am I

[Bug 1242678]

2014-08-14 Thread Carlos Garcia Campos
we can discuss them here, if this patch has caused regressions we might revert it if we don't find a new solution for the regressions. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu.

[Bug 1242678]

2014-06-25 Thread Carlos Garcia Campos
(In reply to comment #22) (In reply to comment #20) (In reply to comment #19) Thanks Marek! Do you still plan to look at the evince side as well (since the rotation seems to still be wrong when using it, as mentioned in previous comments) Hi Sebastien, thank you for

[Bug 1242678]

2014-06-18 Thread Carlos Garcia Campos
I've been trying this and I'm getting the opposite results, the attached ps file is rotated without the patch but nothing is rendered when rotated with the patch. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu.

[Bug 1242678]

2014-06-11 Thread Carlos Garcia Campos
(In reply to comment #17) Created attachment 100723 [details] [review] Rotate documents correctly Hi, I'm sorry for my late response, I was super busy with something else. No problem! (In reply to comment #15) Comment on attachment 99331 [details] [review] [review] Rotate documents

[Bug 1242678]

2014-06-04 Thread Carlos Garcia Campos
Comment on attachment 99331 Rotate documents correctly Review of attachment 99331: - This looks good to me, except the confusing NONE/LANDSCAPE thing. Adrian, does the PostScript part looks good to you? :::

[Bug 1242678]

2014-05-21 Thread Carlos Garcia Campos
I'm not a PostScript expert either. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to:

[Bug 1242678]

2014-05-21 Thread Carlos Garcia Campos
(In reply to comment #12) Yes, you can replace setpagedevice with pop. It is not clear to me how your patch is doing this. Something like /setpagedevice { pop } bind def should work. Thanks Adrian. It seems Marek submitted the same patch again instead of the updated one. -- You received this

[Bug 1242678]

2014-05-15 Thread Carlos Garcia Campos
Comment on attachment 96165 Rotate documents correctly Review of attachment 96165: - Thanks for the patch! ::: libspectre/spectre-device.c @@ +206,5 @@ return SPECTRE_STATUS_RENDER_ERROR; } +

[Bug 33288]

2013-11-26 Thread Carlos Garcia Campos
While working on bug #71160 I've found another regression introduced by this fix. In some cases, additional lines are added to the selection. For example, open the hig document and go to the first page. Start selecting the second line, but dragging from the margin, and you will see that the first

[Bug 667752]

2012-11-26 Thread Carlos Garcia Campos
The problem with the patch is that in some cases it's clear that it improves the output, but in some others I have doubts whether the output is better or worse, I'll attach some examples found while running my tests. -- You received this bug notification because you are a member of Ubuntu

[Bug 667752]

2012-11-26 Thread Carlos Garcia Campos
Created attachment 70366 Test results examples Let me know if you want me to send the PDFs to you -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/667752 Title: Non-embedded

[Bug 740506]

2012-09-17 Thread Carlos Garcia Campos
(In reply to comment #26) What's missing in gnutls is a way to parse all the relevant components of the PKCS#7 object as present in a PDF signature. It seems that in gnutls they assume those objects can only contain certificates and CRLs as you can confirm if you go through the functions

[Bug 740506]

2012-09-17 Thread Carlos Garcia Campos
(In reply to comment #30) (In reply to comment #26) What's missing in gnutls is a way to parse all the relevant components of the PKCS#7 object as present in a PDF signature. It seems that in gnutls they assume those objects can only contain certificates and CRLs as you can

[Bug 39890]

2012-09-17 Thread Carlos Garcia Campos
(In reply to comment #49) Oh, wait, didn't realize the functions it's adding new parameters are private, ignore my breaks API part. No problem :-) but please, ask me before committing any change that might break the public glib API even in master. -- You received this bug notification because

[Bug 39890]

2012-09-17 Thread Carlos Garcia Campos
(In reply to comment #47) I've commited this patch to master (what will be 0.22) and not to 0.20 since it breaks the public glib api Really? why? I agree with not committing it to the stable branch, but I don't think the patch breaks the API, or am I missing something? Breaking the API should

[Bug 33288]

2012-09-10 Thread Carlos Garcia Campos
(In reply to comment #42) Created an attachment (id=31406) [details] 3/5 reading order (bug fixed) It seems this bug introduced an important performance regression, see the detailed analysis in poppler mailing list: http://lists.freedesktop.org/archives/poppler/2010-October/006566.html --

[Bug 39890]

2012-08-22 Thread Carlos Garcia Campos
(In reply to comment #29) Note i have *not* verified it fixes the problem mentioned in this bug. Carlos can you do that part? it's weird, I don't see any difference with and without the patch with poppler-glib-demo and the minimal example attached to this bug. -- You received this bug

[Bug 39890]

2012-08-15 Thread Carlos Garcia Campos
(In reply to comment #25) Created attachment 65449 [details] [review] Allow multiple fonts in a TextWord This patch modifies TextWord so that each character can be a different font. Function poppler_page_get_text_attributes is updated to allow for attributes to change mid-word. Thanks

[Bug 39890]

2012-08-15 Thread Carlos Garcia Campos
Sure, no hurry, thanks! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/39890 Title: characters change when selecting text To manage notifications about this bug go to:

[Bug 711300]

2012-01-23 Thread Carlos Garcia Campos
Comment on attachment 55629 fix ctm when painting groups Review of attachment 55629: - Patch looks good to me and it doesn't introduce regressions in my tests, so please, push it to both branches. Thanks! -- You received this bug

[Bug 193927]

2012-01-21 Thread Carlos Garcia Campos
Comment on attachment 55785 Fix-test-for-rotation.patch Review of attachment 55785: - Pushed to git master, thanks! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee.