Correct, sorry, I forgot to change the theme.
Thanks, it works now. I'm going to upload this. Will you propose a merge
for the theme change?
(As this is a new feature, I grant the FFe for it)
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
** Branch linked: lp:~ubuntu-desktop/gtk/ubuntu
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow toolbar dragging
To manage notifications about
** Changed in: gtk+2.0 (Ubuntu)
Status: Confirmed = Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow toolbar dragging
To
This bug was fixed in the package gtk+2.0 - 2.24.24-0ubuntu3
---
gtk+2.0 (2.24.24-0ubuntu3) utopic; urgency=medium
* Apply patch from Adam Smith, backported from gtk+3.0, to allow windows to
be dragged using blank spaces in the toolbar as well as the menubar. (LP:
#1332721)
Thanks Iain! Did you want me to raise bugs against the various theme
packages or just add them to this bug?
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add
On Thu, Oct 09, 2014 at 08:56:50PM -, Adam Smith wrote:
Thanks Iain! Did you want me to raise bugs against the various theme
packages or just add them to this bug?
You can use this one. For the Ubuntu theme we use Launchpad merge
proposals, that'd be the easiest way to get your change
Hi Iain, I'm sorry it didn't work. As noted in comment 3, you also have
to edit your gtk2 theme - did you do this?
I can't give you a debdiff at the mo, but all you just need to do is
remove the 062_dnd_menubar.patch and replace it with my patch.
--
You received this bug notification because
On Mon, Sep 29, 2014 at 07:33:39PM -, Adam Smith wrote:
Hi Iain, I use it with the Mate desktop, so try something like
caja..but I can compile it myself, I'm not sure if the versions in
the Ubuntu repo uses GTK2 or 3I'm guessing it will still be 2.
It is, and I'm afraid I can't get
** Changed in: gtk+2.0 (Ubuntu)
Assignee: (unassigned) = Iain Lane (laney)
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow toolbar dragging
s/gtk/gimp/ oops :)
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow toolbar dragging
To manage notifications about this bug go to:
Hi Adam, I looked at uploading this today,but I couldn't confirm it
works. Can you give me an example application in the archive that I can
check it out on?
I tried gtk and pinta.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to
pcmanfm?
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow toolbar dragging
To manage notifications about this bug go to:
Hi Iain, I use it with the Mate desktop, so try something like
caja..but I can compile it myself, I'm not sure if the versions in
the Ubuntu repo uses GTK2 or 3I'm guessing it will still be 2.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
oopsnot sure why that 'can' is in post 15!
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow toolbar dragging
To manage notifications about
Can you also provide an updated changelog entry for your patch? That would help
in sponsoring this patch. You could also upload a 'debdiff' which shows this
patch in the proper location for packaging along with the changelog diff.
Thanks!
--
You received this bug notification because you are a
Iain, thanks for the comment. Was it the gtkmenushell.c hunk causing
the problem? I just copied and pasted that from the 062_dnd_menubar
patch, but I see now that has been refreshed. Attached should be a
patch that applies cleanlyI hope! It does the job of the
062_dnd_menubar patch and
** Patch removed: menubar-toolbar-drag-v2.patch
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/1332721/+attachment/4177838/+files/menubar-toolbar-drag-v2.patch
** Patch added: menubar-toolbar-drag-v3.patch
Adam,
I tried to apply this with a view to uploading but it looks as if the
patch doesn't apply cleanly on top of .24 - could you please rebase on
the current utopic version?
A quick ping on upstream bug #611313 would be appreciated but I wouldn't
block uploading this patch on that
cheers!
--
You can use their bugzilla or their mailing list,
https://mail.gnome.org/archives/gtk-devel-list
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow
Do you know how I should contact upstream? For example, is there an
appropriate mailing list?
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1332721
Title:
Add patch to allow
@Sebastian - I haven't contacted upstream since I thought they weren't
accepting new features for gtk+2? If they wanted it adding they could
of done in in 2010 when the patch was written (
https://bugzilla.gnome.org/show_bug.cgi?id=611313 ).
** Bug watch added: GNOME Bug Tracker #611313
That's not really a new feature, it's an improvement and they have been
adding changes to that serie, see
http://git.gnome.org/browse/gtk+/log/?h=gtk-2-24
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu.
Thank you for your bug report. Do you know if a request has been made
upstream to have that change commited to the gtk-2-24 serie?
** Changed in: gtk+2.0 (Ubuntu)
Importance: Undecided = Wishlist
** Changed in: gtk+2.0 (Ubuntu)
Status: New = Confirmed
--
You received this bug
To enable the toolbar dragging in your chosen theme, open the gtkrc file
e.g.
/usr/share/themes/Ambiance/gtk-2.0/gtkrc
Find the line
GtkMenuBar::window-dragging = 1
and either change it to
GtkWidget::window-dragging = 1
or add a new line
GtkToolbar::window-dragging = 1
--
You received
The attachment Allow toolbars to be dragged too! seems to be a patch.
If it isn't, please remove the patch flag from the attachment, remove
the patch tag, and if you are a member of the ~ubuntu-reviewers,
unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by
25 matches
Mail list logo
