Confirmed this is now working, thanks!
** Changed in: gnome-software (Ubuntu)
Status: Triaged => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
** Changed in: rnr-server
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own reviews
To
** Tags removed: trello-import
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own reviews
To manage notifications about this bug go to:
** Tags added: trello-import
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own reviews
To manage notifications about this bug go to:
** Also affects: ubuntu-release-notes
Importance: Undecided
Status: New
** Changed in: ubuntu-release-notes
Status: New => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
** Tags added: xenial
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own reviews
To manage notifications about this bug go to:
** Changed in: rnr-server
Status: New => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own reviews
To manage
** Branch linked: lp:~michael.nelson/rnr-server/1564209-return-openid-
for-username
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own
@noodles: A long time ago, RnR started using SSO v2[0]. Prior to that,
through the v1 SSO API, the LP username was *sometimes* available and it
was used when it was. Since SSO v2 API account details doesn't really
provide a possible username, for new reviewers the consumer_key is
what's being used
In GNOME Software we have the consumer key and matching the click
behaviour (only returning consumer key in reviewer_username) is ideal.
At dobeys suggestion we'll make GNOME Software match reviewer_username
== consumer_key which will work for the majority of users and a later
server side fix will
Also option 2 (adding a consumer_key to the JSON) is acceptable - up to
you which one is easier.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't
@fgallina or @kelvin: Can you check the background for these decisions.
I'm not 100% but from memory RnR used to use the SSO (well, LP) username
when it has one for the user (as SSO users don't always have a username,
it depends whether they have an LP account), so I don't know that we can
provide
It sounds like changing reviewer_username to always be the consumer_key
value, as we have for click reviews, would be the best route, and would
not really break software-center (which is already somewhat broken in
how it does this anyway).
With this suggested change, a fairly small change could
Most SSO users won't have a username as they are only generated by
Launchpad.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1564209
Title:
Doesn't recognise own reviews
For click packages we compare consumer_key == reviewer_username. It
seems the old API however returns LP usernames for some people, which of
course won't match the consumer_key.
If we could change the old API on the server to also always return
consumer_key in the reviewer_username field, then
Once you can match the username it's just a matter of:
gs_review_set_flags (review, GS_REVIEW_FLAG_SELF)
And GNOME Software will handle the UI for everything.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
This requires us to know the username associated with the Ubuntu One
account. This is not the same as the consumer_key from OAuth.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-software in Ubuntu.
17 matches
Mail list logo
