I hope I am not reviving an old bug unnecessarily. On my Ubuntu 11.04
Beta (fresh install of Beta 1, now all packages updated to newest
version), Empathy shows one notification per message, which means the
next message gets shown no sooner than when the notification for the
previous one timeouts.
** Changed in: empathy
Importance: Unknown = Wishlist
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
desktop-bugs mailing
** Changed in: empathy
Status: Unknown = Fix Released
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
desktop-bugs
Should we open another bug for the missing notifications?
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
desktop-bugs mailing
Nicolò, you mean when the status icon is being used instead of the
messaging menu? If I understood correctly, your patch already fixes the
missing notifications when the messaging menu is being used, right?
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You
No, my patch fixes only the bug description, so the notifications from
users different from the first one are still missed.
I'm sure that the problem can be fixed in empathy-status-icon.c but
patch 35_check_actions_notifications.patch needs some additional work.
I'm sorry but I can't do this,
Ah, I see. Then I guess a new bug report would be adequate, in my
opinion.
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
Please let me know if you report it, so I can confirm it (just tested
it).
(I could report it myself, but I don't know if you are going to and
don't want to risk reporting a duplicate)
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug
Can you do the report? I'm very busy in these days, sorry.
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
desktop-bugs mailing
Bug #552543 reported. Please check if everything is okay over there.
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
Nicolò, the Ubuntu version of Empathy shows the old status icon if the
option use message indicators is unchecked. Does everything work
properly when it is unchecked?
Maybe it could be possible to eat the notifications only when this
option is unchecked, but I don't know how hard would this be to
Sorry, I don't know how to fix this, eating the messages is not a
problem introduced by my patch.
Can someone file a bug upstream?
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop
But I think this bug is only downstream, as this eating does not occur
with a vanilla Empathy. The solution probably relies on fixing the
Ubuntu patch that adds support for the Messaging Menu and disables the
status icon.
--
Notifications use append instead of replace
No, the problem is also downstream, since the notifications are eaten
until you click on the status icon. This is completely a bug in my
opinion: all the notifications should appear always.
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this
I talked with upstream. They don't want to remove this behavior until
they have a way to selectively open chat windows (ubuntu has this).
The code logic is in empathy-status-icon.c
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug
Ken, you should TRY if it works for you. (I forgot a word, sorry)
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
desktop-bugs
This patch should disable notifications eating (only).
Ken, you should if it works for you
** Patch added: never_inhibit_notifications.patch
http://launchpadlibrarian.net/42515635/never_inhibit_notifications.patch
--
Notifications use append instead of replace
To tell the truth patch 35_check_actions_notifications.patch already
does a similar thing, so it's strange that notifications are eaten (anyway I
removed the previous patch since it was useless)...
Anyway this is the new version of my patch, which applies to ubuntu
modifications.
** Patch
I did a mess, this should be the correct patch
** Patch added: 32_append_notifications.patch
http://launchpadlibrarian.net/42519745/32_append_notifications.patch
** Patch removed: 32_append_notifications.patch
http://launchpadlibrarian.net/42519373/32_append_notifications.patch
--
This bug was fixed in the package empathy - 2.30.0-0ubuntu3
---
empathy (2.30.0-0ubuntu3) lucid; urgency=low
* debian/patches/32_append_notifications.patch
- Fix appending/merging of notifications (Nicolò Chieffo) (LP: #476662)
*
** Changed in: hundredpapercuts
Status: Triaged = Fix Released
** Changed in: hundredpapercuts
Assignee: (unassigned) = Ken VanDine (ken-vandine)
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are
** Also affects: empathy via
https://bugzilla.gnome.org/show_bug.cgi?id=607446
Importance: Unknown
Status: Unknown
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop
** Changed in: empathy (Ubuntu)
Importance: Undecided = Low
** Changed in: empathy (Ubuntu)
Status: Confirmed = Triaged
** Changed in: hundredpapercuts
Status: Fix Released = Triaged
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You
** Patch added: 32_append_notifications.patch
http://launchpadlibrarian.net/42156067/32_append_notifications.patch
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which
Hi back again, I did some further tests about the missing notifications.
Ken VanDine, I've tested the problem you were reporting using a vanilla
version of empathy git (without my patches). It's a normal behavior of
empathy: the missing notifications will appear as soon as you click on
empathy
Hi again, this is another version of the patch which addresses all comments
made upstream.
Since it was done with upstream it doesn't apply to ubuntu, because it
conflicts with another patch, but I can't undersstand which one.
** Patch added: 32_append_notifications.patch
Hi, I'm glad you already reviewed the patch!
1) We do need the same logic applied to empathy-status-icon.c, without
it we don't get notifications when the chat window isn't open. Can you
apply the same logic there?
I'll try to do this
2) It works well for IMs from one person, but if you have
Well the problem could be caused by calling g_object_unref too early...
I'll also try to postpone the call
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed
I also have a question: do I need to g_object_unref a notification
that has been shown, or is it automatic?
I think I have to unref it, so the closed event is raised. I
couldn't find this in the notify_notification doc.
--
Notifications use append instead of replace
New patch, I changed also empathy-status-icon.c in the same way.
To try to fix the second problem I removed the g_object_unref before
creating a new notification. I think it should only be called in the
closed callback.
Please test it again
** Patch added: 32_append_notifications.patch
After talking with upstream the mutex is not needed because there is
only 1 thread.
** Patch added: 32_append_notifications.patch
http://launchpadlibrarian.net/41827718/32_append_notifications.patch
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You
Much better, and it no longer eats notifications for the second contact
when the chat window is open. However it is still eating them when the
chat window is not open.
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification
Are you sure it works as you expect, without the patch?
I never close the notifications so I can't understand why they are
eaten. It might be an already existing problem...
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification
The patch 32_append_notifications.patch does not fix the problem
I'll attach a debdiff that fixes it
** Changed in: empathy (Ubuntu)
Status: Fix Released = Confirmed
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification
** Attachment added: append_hint.debdiff
http://launchpadlibrarian.net/41742208/append_hint.debdiff
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to
** Patch added: 32_append_notifications.patch
http://launchpadlibrarian.net/41742492/32_append_notifications.patch
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which
Thanks for the patch!
Two things:
1) We do need the same logic applied to empathy-status-icon.c, without it we
don't get notifications when the chat window isn't open. Can you apply the
same logic there?
2) It works well for IMs from one person, but if you have incoming IMs within
the
** Tags added: patch
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to empathy in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
I would like to reopen this bug for Lucid Beta 1. Empathy notifications
from the same user are not merging.
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
Adding papercut task and milestones from dup.
** Also affects: hundredpapercuts
Importance: Undecided
Status: New
** Changed in: hundredpapercuts
Importance: Undecided = Low
** Changed in: hundredpapercuts
Status: New = Fix Released
** Changed in: hundredpapercuts
@Conscious User : when you are duping a bug , you need to carry over the
other tasks as-well. Thanks for duping it though
--
Notifications use append instead of replace
https://bugs.launchpad.net/bugs/476662
You received this bug notification because you are a member of Ubuntu
Desktop Bugs,
Upstream bug https://bugzilla.gnome.org/show_bug.cgi?id=607446
** Summary changed:
- Notifications use replace instead of append
+ Notifications use append instead of replace
** Bug watch added: GNOME Bug Tracker #607446
https://bugzilla.gnome.org/show_bug.cgi?id=607446
--
Notifications
42 matches
Mail list logo
