** Changed in: brasero
Status: New => Expired
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in Ubuntu.
https://bugs.launchpad.net/bugs/497853
Title:
Support application indicators
To manage notifications about
** Changed in: brasero
Status: Unknown = New
** Changed in: brasero
Importance: Unknown = Wishlist
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to
Thanks Travis! Looks great now, I'll upload this now. Please still
forward it upstream.
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in ubuntu.
--
This bug was fixed in the package brasero - 2.29.91-0ubuntu2
---
brasero (2.29.91-0ubuntu2) lucid; urgency=low
* Add 012_appindicator.patch: Support application indicator, patch by Travis
B. Hartwell. (LP: #497853)
* debian/control.in: Add libappindicator build dependency.
** Branch linked: lp:ubuntu/brasero
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
To address Martin's concerns, I discussed with mpt what the
appropriate user interaction here should be. I did the following:
- I reverted the cancel menu item back to using GTK_STOCK_CANCEL so it
will be translated and then did some additional work to remove the
icon from being displayed.
-
** Changed in: brasero (Ubuntu Lucid)
Status: Incomplete = In Progress
** Changed in: brasero (Ubuntu Lucid)
Assignee: Travis B. Hartwell (nafai) = Martin Pitt (pitti)
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because
** Changed in: brasero (Ubuntu Lucid)
Assignee: Canonical Desktop Team (canonical-desktop-team) = Martin Pitt
(pitti)
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
I reviewed the translated strings in the patch. Many are already
present, but Close is new. Is it possible to use e. g. a stock button
for that, or drop it entirely? The help string is also just Close,
it's not really obvious what it does -- close the menu, close the
application, cancel the burn?
Please forward this patch to the upstream bug as well.
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in ubuntu.
--
desktop-bugs mailing list
Also, I don't even see the Close in the menu. Instead, I only see an
untranslated Cancel (but that string is upstream as well, German
translation is just missing).
Otherwise this is working fine. I'll wait with the upload until the
string question is settled and the patch gets forwarded upstream.
** Branch linked: lp:~ubuntu-desktop/brasero/ubuntu
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in ubuntu.
--
desktop-bugs mailing list
** Changed in: brasero (Ubuntu Lucid)
Assignee: Martin Pitt (pitti) = Travis B. Hartwell (nafai)
** Changed in: brasero (Ubuntu Lucid)
Status: In Progress = Incomplete
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because
Change to proper state, per seb128.
** Changed in: brasero (Ubuntu Lucid)
Status: Fix Committed = In Progress
** Changed in: brasero (Ubuntu Lucid)
Assignee: Ken VanDine (ken-vandine) = Travis B. Hartwell (nafai)
--
Support application indicators
This patch fixes a bug found by Ken by changing the cancel menu item
to close to emulate the behavior of the old GtkStatusIcon. It also
removes the icons from the menu items to make the menu formatting look
correct.
** Patch added: Updated patch to add support for app indicators
Ready for re-review. Note that this change is as invasive as the change
to vino, bug #497883, and perhaps should first be vetted upstream as
Martin suggested for vino.
** Changed in: brasero (Ubuntu Lucid)
Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team
I made some changes to what you had in configure.in
* Follow naming conventions already used by upstream
- APPINDICATOR_REQUIRED instead of APPINDICATOR_REQS
- enable_appindicator instead of have_app_indicator
* Make it an enable arg like you suggested, default to yes
** Patch added:
Not sure how to best remove the code duplication, so pending any other
suggestions from Ken, likely ready for upstream review.
** Patch added: Updated patch with configure.in changes suggested by Ken
http://launchpadlibrarian.net/38928367/app-indicators-take-2.patch
--
Support application
Patch was made against upstream git tag BRASERO_2_29_6, matching the
version in Lucid, and I have verified patch both cleanly applies against
the original tarball acquired via apt-get source -d brasero (using patch
-p0) and against git HEAD (via git rebase).
Feature complete with the following
Will attach patch to upstream bug after Ken has had a chance to review
it.
** Changed in: brasero (Ubuntu Lucid)
Status: In Progress = Fix Committed
** Changed in: brasero (Ubuntu Lucid)
Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine)
--
Support application
** Tags added: patch
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
** Changed in: brasero (Ubuntu Lucid)
Status: Triaged = In Progress
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to brasero in ubuntu.
--
desktop-bugs
** Changed in: brasero (Ubuntu Lucid)
Assignee: Canonical Desktop Experience Team (canonical-dx-team) = Travis
B. Hartwell (nafai)
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop Bugs,
** Changed in: brasero (Ubuntu Lucid)
Importance: Undecided = Wishlist
** Changed in: brasero (Ubuntu Lucid)
Status: New = Triaged
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
Desktop
** Bug watch added: GNOME Bug Tracker #606420
https://bugzilla.gnome.org/show_bug.cgi?id=606420
** Also affects: brasero via
https://bugzilla.gnome.org/show_bug.cgi?id=606420
Importance: Unknown
Status: Unknown
--
Support application indicators
** Also affects: brasero (Ubuntu Lucid)
Importance: Undecided
Assignee: Canonical Desktop Experience Team (canonical-dx-team)
Status: New
--
Support application indicators
https://bugs.launchpad.net/bugs/497853
You received this bug notification because you are a member of Ubuntu
26 matches
Mail list logo
