[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
My English is bad. So can I e-mail you details in Russian? Ok, but I am far away from playing with Xorg now. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
Just my 0.02 cents. Why not to introduce transaction concept for key presses? You just go too far. Xorg developers don't apply the patch because _any_ such events should be sent on press, not on release. Because X specifications tell so and they will be broken down otherwise. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
And if X specifications are broken down then some applications may be potentionally broken down. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
Denis, What do you mean that key-on-release behavior is unreliable while typing? Please describe. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812]
(In reply to comment #115) It shouldn't work like that - I've tested the Ubuntu built X.org (with Ilya's patch) and it worked properly when using CTRL+ALT as the keyboard switching. It was immediately after the patch got accepted (at 11.04) but as ALT+SHIFT still works fine, I don't see a reason everything shouldn't continue to work (though I don't have access to an Ubuntu machine ATM to test). Oded Arbel, I repeat: Ctrl OR Alt. OR, not AND. I use right Alt for layout switching so I can't use it for any other purpose. Hi, Actually, the patch works for key shortcuts with two or more buttons (like ALT+SHIFT, but not Alt or Ctrl alone). It is not done intentionally. Despite the fact that there is a possibility to improve current patch behaviour for needs like yours I don't think it should be improved for all possible cases - there are many other things to be done to make the world a better place. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812]
(In reply to comment #67) Ilya, did you debug the problem with the led as you described in #64? Also, Daniel (the responsible for the patches to get accepted if I understood correctly) raised some concerns on #59. Do you think you could address them? I believe after that the patch will get accepted. What do you think? I didn't debug #64; I don't see something wrong with #59. I think the opposite,- as I understand from a few conversations Daniel do not accept the patch because of some policy. So improvements don't make sense, and I am somewhat disappointed. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812]
(In reply to comment #80)
Ok, I try to answer here, but I should note that I don't remember full details
(because it was more than half a year ago).
The following comments were made by Peter Hutterer (an X.org input developer)
on the corresponding bug in RedHat bugzilla (
https://bugzilla.redhat.com/show_bug.cgi?id=660254 ):
(In reply to comment #6)
implementing this behaviour requires guesswork that I'm not sure is safe in
a
number of setups.
...
afaict, the desired behaviour for a ctrl+shift groupchange is:
ctrl down → set Control modifier
shift down → set Shift modifier
if (other key pressed)
send event Contrl+Shift+other key
else if (ctrl || shift released)
change group
The XKB map for left control in this case is:
key LCTL { [ Control_L, ISO_Next_Group ] };
So whenever ISO_Next_Group is pressed, you still need to know which
modifier to
set in case the group action isn't executed. The XkbSA_SetMod,
XkbSA_LockMod,
etc. actions provide the modifiers set for a given key, hence why it works
currently. This information comes from the client when the xkb map is loaded
and is used to trigger the modifier flags for a given key. The
XkbSA_LockGroup
behaviour (which is triggered at ISO_Next_Group) does not have this field
(adding it would break ABI), so you need to guess which modifiers to set if
you
didn't trigger this action. This is the main stumbling point that I found
and
if you look at Ilya's patch that's where he needs the big hack that I'm not
comfortable at all with it.
I do not agree. You do not need to know/guess which modifiers to set - whenever
ISO_Next_Group is pressed I just don't execute it immediately but delay it till
a key release (by the means of _XkbNextFreeFilter()/_XkbApplyFilters() ). Btw,
that trick was suggested by Daniel Stone (somewhere on the mail list).
And I want to note that where I comment :KLUDGE: I mean a different
thing: in theory that branch of code should do the same thing as the
switch in XkbHandleActions() ; but, in practice I see (and want) only
XkbSA_SetMods action (so kludge here is copy-n-paste from
XkbHandleActions() ).
Now, I don't know if there are layouts where the modifier mask would be
different on the second level as opposed to the first (and Ilya's hack or a
similar attempt would fail completely) but there's so many layouts that
it'll
take a while to get through them all.
(do not understand properly the above, sorry) The only situation the patch fails
(just behaves old way, and nothing more!) is when switching is set up as just
one key like Right Alt. That is because of the line
fake_state.mods = 0;
, mods here is 0 anyway = we can't block XkbSA_LockGroup .
Anyway, nobody wants more,- but only (de facto standard) Ctrl+Shift and
Alt+Shift on release. I think this is the situation where the practice
begins and the theory ends.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/36812
Title:
Keyboard layout change on hotkeys press instead of release and do not
work well with shortcuts
To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812]
The patch has been applied in Ubuntu, just now. Today is a good day. :) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812]
(In reply to comment #88) (In reply to comment #86) Already proven to break the XKB specification, yes. Hi Daniel. I've seen this comment about breaking the XKB specification in several places and - I'm really not trying to be contrary - I looked at the protocol specs here http://www.x.org/releases/current/doc/kbproto/xkbproto.html and I can't understand how this behavior change contradicts the spec. Now - I'm not a trained X11 developer, and I'm not even that good at reading specs, so I would really appreciate it if you can point me at the section relevant to the breakage you discuss, so I can be more informed about the issue. Thanks in advance. Hi Oded, It is not in XKBproto but in XKBlib spec. You can see the only assertion against changing layout on release in general (and the patch in particular) in ftp://ftp.x.org/pub/X11R7.0/doc/PDF/XKBlib.pdf, Table 16.4 Group Action Types, the last item XkbSA_LockGroup, citing: 1. If the XkbSA_GroupAbsolute is set in the flags field, key press events set the locked keyboard group to the group specified by the group_XXX field. Otherwise, key press events add the group specified by the group_XXX field to the locked keyboard group. In either case, the resulting locked and effective keyboard groups are brought back into range depending on the value of the groups_wrap field of the con-trols structure. 2. A key release has no effect. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/36812 Title: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/36812/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
Hi, Alexander! daniels i'm inclined to not apply it, as it directly contradicts the xkb spec, and is also apparently buggy (see the upstream bug report with some people complaining that it breaks occasionally) The patch is not buggy, the only issue complained was my own (see more at http://bugs.freedesktop.org/show_bug.cgi?id=865 ). And the reason is known - LED's highlighting confilcts with the patch, 1) it can be safely avoided, 2) it is just a little tech problem which can be done. daniels well, we could write the spec better for xkb2 ;) daniels yeah, i'm not personally affected by it as i only use US layout daniels i can see that it sucks, but otoh i don't like contradicting the spec for no good reason I start to think it is a discrimination. No xkb2 writing is required! My first suggestion was to add my patch as configuration option; so the default installation of Xorg works as expected, and there is no spec contradiction. If a user wishes he(she) turned that option on/off as one of many others you can see in Keyboard Preferences. xkb2 waiting is just 'when pigs fly' excuse. -- Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts https://bugs.launchpad.net/bugs/36812 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a direct subscriber. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
Nick, I talked with Peter Hutterer, maintainer of X Server, a few days ago and he promised to review the patch (and to apply it to upstream if it's good). P.S. He can be found on Freenode IRC, #xorg-devel, as whot. I hope this is not a private information. :) -- Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts https://bugs.launchpad.net/bugs/36812 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a direct subscriber. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
Oded, No, my patch doesn't block anything on release: keyboard layout is switched *along* with SCIM triggering (for David Fraser). So I assume everything is ok untill David states clearly that he has troubles with the patch. -- Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts https://bugs.launchpad.net/bugs/36812 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a direct subscriber. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 36812] Re: Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts
David, How to reproduce your situation, what DE? I have never used SCIM dialogs, how to turn them on? -- Keyboard layout change on hotkeys press instead of release and do not work well with shortcuts https://bugs.launchpad.net/bugs/36812 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a direct subscriber. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
