[Bug 1748147] Re: Upgrading systemd sets incorrect permissions on /var/log/

[Seyeong Kim]

** No longer affects: systemd (Ubuntu)

** No longer affects: rsyslog (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1748147

Title:
  Upgrading systemd sets incorrect permissions on /var/log/

To manage notifications about this bug go to:
https://bugs.launchpad.net/debhelper/+bug/1748147/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1748147] Re: Upgrading systemd sets incorrect permissions on /var/log/

[Seyeong Kim]

** Bug watch added: Debian Bug tracker #894510
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894510

** Also affects: systemd via
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894510
   Importance: Unknown
   Status: Unknown

** Project changed: systemd => debhelper

** Also affects: debhelper (Ubuntu)
   Importance: Undecided
   Status: New

** Tags added: sts

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1748147

Title:
  Upgrading systemd sets incorrect permissions on /var/log/

To manage notifications about this bug go to:
https://bugs.launchpad.net/debhelper/+bug/1748147/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1750741] Re: Memory leak in g_dbus_proxy_new_for_bus_sync()

[Seyeong Kim]

@ddstreet

After analyzing code.

I don't think this fix is possible without any big changes for trusty.

and glib2.0 affects many pkgs it seems.

it is quite dangerous to fix this with large commits.

so lets focus on pacemaker instead of glib2.0

how about this ddstreet?

Thanks

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1750741

Title:
  Memory leak in g_dbus_proxy_new_for_bus_sync()

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1750741] Re: Memory leak in g_dbus_proxy_new_for_bus_sync()

[Seyeong Kim]

Hello ddstreet

yep, it is tricky..

In the beginning, I added only one line but build failed.

3 commits for building, only one line is related to memroy leak
directly.

I retried it and attaching build link on lp

Thanks

https://launchpad.net/~xtrusia/+archive/ubuntu/sf160627-glib/+build/14383194/+files
/buildlog_ubuntu-trusty-
amd64.glib2.0_2.40.2-0ubuntu1+sf160627v20180222.0_BUILDING.txt.gz

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1750741

Title:
  Memory leak in g_dbus_proxy_new_for_bus_sync()

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Description changed:

  [Impact]
  lrmd daemon with upstart resource has memory leak in Trusty
  
  affected to pacemaker 1.1.10.
- affected to glib2.0 2.40.2-0ubuntu1
+ affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [3]
  
  Please note that patch for pacemaker is created myself.
  
  [Test Case]
  
- 1. deploy 3 trusty instance.
- 2. install corosync, pacemaker, mysql.
- 3. setting with below info
- 3.1 corosync.conf, proper setting for 3 node
- 3.2 crm configure < setup.crm ( which has upstart:mysql setting )
- 3.3 monitor lrmd daemon's memory usage
+ https://pastebin.ubuntu.com/p/fqK6Cx3SKK/
+ you can check memory leak with this script
  
  [Regression]
- Restarting daemon after upgrading this pkg will be needed. this patch added 
NULL check for several parts. prior commit[1] changed file structure. and This 
change makes user changes usage of upstart:mysql to lsb:mysql. So I added free 
function myself. This might affect to system.
- For glib2.0, commit [1] is critical, but [2],[3],[4] is needed for building 
it.
+ Restarting daemon after upgrading this pkg will be needed. this patch adds 
free for non-freed dynamic allocated memory. so it solves memory leak. 
  
  [Others]
  
- Related commits.
+ this patch is from my self with testing.
  
- [1] commit a7b61e276120184c7586a3217ed3571a982f5017
- Author: Andrew Beekhof 
- Date:   Fri Aug 23 16:25:35 2013 +1000
- 
- Refactor: attrd: Move to its own directory and create a stub for
- attrd-ng
- 
- --
- $ git describe --contains a1a6922e43dfe80b23887a88401cbb93fe3645c0
- Pacemaker-1.1.11-rc3
- 
- $ git describe --contains a7b61e276120184c7586a3217ed3571a982f5017
- Pacemaker-1.1.11-rc1~168
- 
- $ rmadison pacemaker
-  pacemaker | 1.1.10+git20130802-1ubuntu2   | trusty
-  pacemaker | 1.1.10+git20130802-1ubuntu2.4 | trusty-security
-  pacemaker | 1.1.10+git20130802-1ubuntu2.4 | trusty-updates
- 
-  pacemaker | 1.1.14-2ubuntu1   | xenial
-  pacemaker | 1.1.14-2ubuntu1.3 | xenial-security
-  pacemaker | 1.1.14-2ubuntu1.3 | xenial-update
-  pacemaker | 1.1.16-1ubuntu1   | zesty
-  pacemaker | 1.1.16-1ubuntu1   | artful
-  pacemaker | 1.1.18~rc3-1ubuntu1   | bionic
- --
- 
- For glib
- [1] 
https://github.com/GNOME/glib/commit/db641e32920ee8b553ab6f2d318aafa156e4390c
- [2] 
https://github.com/GNOME/glib/commit/8792609e15394967cab526838b83f90acb401663
- [3] 
https://github.com/GNOME/glib/commit/ec02a1875f29ecb8e46c0d8c1403cd00a0b3a9e4
- [4] 
https://github.com/GNOME/glib/commit/f10b6550ff2ce55d06b92d6dc3e443fc007b2f7a
+ Please review carefully if it is ok.
  
  [Original Description]
  
  I'm running Pacemaker 1.1.10+git20130802-1ubuntu1 on Ubuntu Saucy
  (13.10) and have encountered a memory leak in lrmd.
  
  The details of the bug are covered here in this thread
  (http://oss.clusterlabs.org/pipermail/pacemaker/2014-May/021689.html)
  but to summarise, the Pacemaker developers believe the leak is caused by
  the g_dbus API, the use of which was removed in Pacemaker 1.11.
  
  I've also attached the Valgrind output from the run that exposed the
  issue.
  
  Given that this issue affects production stability (a periodic restart
  of Pacemaker is required), will a version of 1.11 be released for
  Trusty? (I'm happy to upgrade the OS to Trusty to get it).
  
  If not, can you advise which version of the OS will be the first to take
  1.11 please?

** Description changed:

  [Impact]
  lrmd daemon with upstart resource has memory leak in Trusty
  
  affected to pacemaker 1.1.10.
- affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [3]
+ affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [1]
  
  Please note that patch for pacemaker is created myself.
  
  [Test Case]
  
  https://pastebin.ubuntu.com/p/fqK6Cx3SKK/
  you can check memory leak with this script
  
  [Regression]
- Restarting daemon after upgrading this pkg will be needed. this patch adds 
free for non-freed dynamic allocated memory. so it solves memory leak. 
+ Restarting daemon after upgrading this pkg will be needed. this patch adds 
free for non-freed dynamic allocated memory. so it solves memory leak.
  
  [Others]
  
  this patch is from my self with testing.
  
  Please review carefully if it is ok.
+ 
+ [1] https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741
  
  [Original Description]
  
  I'm running Pacemaker 1.1.10+git20130802-1ubuntu1 on Ubuntu Saucy
  (13.10) and have encountered a memory leak in lrmd.
  
  The details of the bug are covered here in this thread
  (http://oss.clusterlabs.org/pipermail/pacemaker/2014-May/021689.html)
  but to summarise, the Pacemaker developers believe the leak is caused by
  the g_dbus API, the use of which was removed in Pacemaker 1.11.
  
  I've also attached the Valgrind 

[Bug 1750741] Re: Memory leak in g_dbus_proxy_new_for_bus_sync()

[Seyeong Kim]

** Patch added: "lp1750741_trusty_glib2.0.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741/+attachment/5059468/+files/lp1750741_trusty_glib2.0.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1750741

Title:
  Memory leak in g_dbus_proxy_new_for_bus_sync()

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1750741] [NEW] Memory leak in g_dbus_proxy_new_for_bus_sync()

[Seyeong Kim]

Public bug reported:

[Impact]

This issue is found while debugging pacemaker lrmd memory leak

glib2.0 gio function g_dbus_proxy_new_for_bus_sync has leak as [1] said

this is affected to Trusty

[Test Case]

https://pastebin.ubuntu.com/p/fqK6Cx3SKK/
you can check memory leak with this script

[Regression]
This patch is affected to library pkg. so related daemon should be restarted 
after patching. patch itself is very simple and old. it seems verified for few 
years.

[Others]

original commit

https://gitlab.gnome.org/GNOME/glib/commit/db641e32920ee8b553ab6f2d318aafa156e4390c

** Affects: glib2.0 (Ubuntu)
 Importance: Undecided
 Status: Fix Released


** Tags: sts sts-sru-needed

** Tags added: sts sts-sru-needed

** Also affects: glib2.0 (Ubuntu)
   Importance: Undecided
   Status: New

** No longer affects: pacemaker (Ubuntu)

** Changed in: glib2.0 (Ubuntu)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1750741

Title:
  Memory leak in g_dbus_proxy_new_for_bus_sync()

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

Hello ddstreet

I confirmed that glib2.0 patch is needed.

I installed patched_pacemaker only on my system and running just 1 hour.

it started with 4700(RES) but now it is 8000(RES).

after installing glib2.0

it started with 4612, now is is 4688

Thanks

[1] is script to reproduce this issue. need to adjust some code but just
uploading

[1] https://pastebin.ubuntu.com/p/CGrGhjdr4g/

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

sure, no problem

Thanks eric

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

Hello Eric, ddstreet

#1740892 seems starting to fix

Could you guys can sponsor this issue as well?

Thanks a lot

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

@ddstreet

Could you please review V3 again?

Thanks in advance!

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

For V3.

It seems that g_variant_unref(value); part is needed.

Added it again and no memory leaks.

in g_variant_lookup_value, it calls g_variant_get_child_value

so as you said. it need to be unref value as well i think.

Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Patch added: "lp1316970_trusty_pacemaker_v3.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5048947/+files/lp1316970_trusty_pacemaker_v3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

hmm, this has leak more than before..

testing..

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Patch added: "lp1316970_trusty_pacemaker_v2.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5047782/+files/lp1316970_trusty_pacemaker_v2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

Hello ddstreet

Thanks for the review.

I changed some code for pacemaker. ( char -> gchar for matching type,
with g_free)

and glib2.0 patch is needed in my test.

without it, memory leak is there. 4kB leak every 10 second at least.

Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

ty to get it).
  
  If not, can you advise which version of the OS will be the first to take
  1.11 please?

** Changed in: glib2.0 (Ubuntu Trusty)
     Assignee: (unassigned) => Seyeong Kim (xtrusia)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Attachment added: "valgrind-afterpatch"
   
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047145/+files/valgrind-afterpatch

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Patch added: "lp1316970_trusty_pacemaker.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047146/+files/lp1316970_trusty_pacemaker.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Attachment added: "valgrind-beforepatch"
   
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047144/+files/valgrind-beforepatch

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Patch added: "lp1316970_trusty_glib2.0.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047147/+files/lp1316970_trusty_glib2.0.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1316970] Re: g_dbus memory leak in lrmd

[Seyeong Kim]

** Also affects: glib2.0 (Ubuntu)
   Importance: Undecided
   Status: New

** Patch removed: "lp1316970_trusty.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5031302/+files/lp1316970_trusty.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970

Title:
  g_dbus memory leak in lrmd

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs