[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator

2010-04-28 Thread Travis B. Hartwell
Cody's above patch for gtk+ (#16) fixes the reported bug. He mentioned that he is going to rework it to make it more acceptable to upstream and then, if I understand correctly, include it in a gtk+ SRU. -- bluetooth devices menu item not working in bluetooth indicator

[Bug 497897] Re: Support Application Indicators

2010-04-06 Thread Travis B. Hartwell
Unassigned myself as I didn't get to this in time for Lucid and my responsibilities are now different. ** Changed in: epiphany-browser (Ubuntu) Assignee: Travis B. Hartwell (nafai) = (unassigned) -- Support Application Indicators https://bugs.launchpad.net/bugs/497897 You received this bug

[Bug 533775] Re: No icon for volume or typing break after upgrade to lucid

2010-04-05 Thread Travis B. Hartwell
I can reproduce the situation the bug reporter describes (indicator applet removed from panel in Karmic, gnome typing monitor enabled, and then upgrade to Lucid, no icon shown. The failback is working in so much that a status icon is shown because there is no indicator applet, but an incorrect

[Bug 548891] Re: keyboard input broken at gnome login prompt after package updates

2010-04-03 Thread Travis B. Hartwell
I've looked into it a bit, but could not reproduce under this configuration: VMware Player version 3.0.1 build-227600 Host is 64-bit Lucid system up to date as of today Guest is 64-bit Lucid system up to date as of today Tried both with and without VMware Tools installed. VMware Tools version

[Bug 497853] Re: Support application indicators

2010-03-03 Thread Travis B. Hartwell
To address Martin's concerns, I discussed with mpt what the appropriate user interaction here should be. I did the following: - I reverted the cancel menu item back to using GTK_STOCK_CANCEL so it will be translated and then did some additional work to remove the icon from being displayed. -

[Bug 497853] Re: Support application indicators

2010-03-03 Thread Travis B. Hartwell
** Changed in: brasero (Ubuntu Lucid) Status: Incomplete = In Progress ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Martin Pitt (pitti) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because

[Bug 497853] Re: Support application indicators

2010-03-01 Thread Travis B. Hartwell
Change to proper state, per seb128. ** Changed in: brasero (Ubuntu Lucid) Status: Fix Committed = In Progress ** Changed in: brasero (Ubuntu Lucid) Assignee: Ken VanDine (ken-vandine) = Travis B. Hartwell (nafai) -- Support application indicators https://bugs.launchpad.net/bugs

[Bug 497853] Re: Support application indicators

2010-03-01 Thread Travis B. Hartwell
This patch fixes a bug found by Ken by changing the cancel menu item to close to emulate the behavior of the old GtkStatusIcon. It also removes the icons from the menu items to make the menu formatting look correct. ** Patch added: Updated patch to add support for app indicators

[Bug 497853] Re: Support application indicators

2010-03-01 Thread Travis B. Hartwell
Ready for re-review. Note that this change is as invasive as the change to vino, bug #497883, and perhaps should first be vetted upstream as Martin suggested for vino. ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop

[Bug 497897] Re: Support Application Indicators

2010-02-15 Thread Travis B. Hartwell
** Changed in: epiphany-browser (Ubuntu) Assignee: (unassigned) = Travis B. Hartwell (nafai) -- Support Application Indicators https://bugs.launchpad.net/bugs/497897 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser

[Bug 497857] Re: Support application indicators

2010-02-10 Thread Travis B. Hartwell
Thank you for your work there, some comment: GtkStatusIcon *icon; - Why the blank line change? These were probably all unintentional, I have since found a parameter with git diff that allows me to ignore whitespace changes when creating diffs that I will use. They partly came from calling M-x

[Bug 497857] Re: Support application indicators

2010-02-10 Thread Travis B. Hartwell
Attached is an updated patch: 1) following recommendations from Sebastien above 2) updating the configure.ac with the latest suggestions from Ken ** Patch added: Patch for app indicators, take 2 http://launchpadlibrarian.net/39031554/app-indicators-take2.patch -- Support application

[Bug 497857] Re: Support application indicators

2010-02-10 Thread Travis B. Hartwell
Hopefully final changes, based on what Sebastien pointed out on IRC, and another thing I noticed: 1) preprocessed out the code to blink completely in the case of using app indicators 2) the #ifdef/#endif's sometimes were separated by a bit, so I added a comment on each #endif to be #endif /*

[Bug 497853] Re: Support application indicators

2010-02-09 Thread Travis B. Hartwell
Not sure how to best remove the code duplication, so pending any other suggestions from Ken, likely ready for upstream review. ** Patch added: Updated patch with configure.in changes suggested by Ken http://launchpadlibrarian.net/38928367/app-indicators-take-2.patch -- Support application

[Bug 497857] Re: Support application indicators

2010-02-09 Thread Travis B. Hartwell
for application indicators http://launchpadlibrarian.net/38931559/app-indicators.patch ** Changed in: gnome-control-center (Ubuntu) Status: In Progress = Fix Committed ** Changed in: gnome-control-center (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine

[Bug 497853] Re: Support application indicators

2010-02-08 Thread Travis B. Hartwell
Patch was made against upstream git tag BRASERO_2_29_6, matching the version in Lucid, and I have verified patch both cleanly applies against the original tarball acquired via apt-get source -d brasero (using patch -p0) and against git HEAD (via git rebase). Feature complete with the following

[Bug 497853] Re: Support application indicators

2010-02-08 Thread Travis B. Hartwell
Will attach patch to upstream bug after Ken has had a chance to review it. ** Changed in: brasero (Ubuntu Lucid) Status: In Progress = Fix Committed ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine) -- Support application

[Bug 497853] Re: Support application indicators

2010-02-04 Thread Travis B. Hartwell
** Changed in: brasero (Ubuntu Lucid) Status: Triaged = In Progress -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs

[Bug 497857] Re: Support application indicators

2010-02-01 Thread Travis B. Hartwell
** Changed in: gnome-control-center (Ubuntu) Status: Triaged = In Progress -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in ubuntu.