[Bug 131145]

2011-06-02 Thread Ventnor-bugzilla
(In reply to comment #62) We have some automated tests for drag-and-drop, why can't we automate a test here? Because of GetFiles(). It blocks us getting the files if the original event of the transferData was not drop, but the way we make a dataTransfer in script is to synthesise a dragstart

[Bug 131145]

2011-06-02 Thread Ventnor-bugzilla
That would require exposing something very sensitive to script, I thought. I did look into it while I was trying to write a test, and the only place this field is written to is the constructor and copy- constructor, so I assumed the field was kept private for security reasons. -- You received

[Bug 131145]

2011-06-01 Thread Ventnor-bugzilla
http://hg.mozilla.org/mozilla-central/rev/5c6d107ede5a -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in Ubuntu. https://bugs.launchpad.net/bugs/131145 Title: Dragging icon from Nautilus to HTML File Input box

[Bug 131145]

2011-06-01 Thread Ventnor-bugzilla
This will be in Firefox 7 at the earliest. As there is problems with automatically testing this bug, we'd need a litmus test. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in Ubuntu.

[Bug 131145]

2011-05-27 Thread Ventnor-bugzilla
(In reply to comment #54) Comment on attachment 534375 [details] [review] Patch 2 Review of attachment 534375 [details] [review]: - f=mounir with the nits fixed. Moving the review of the dragover/drop events handling to

[Bug 131145]

2011-05-23 Thread Ventnor-bugzilla
Created attachment 534375 Patch 2 Sorry roc and jst but I won't be able to write a test for this. This is due to this line here under nsDomDataTransfer::GetFiles: if (mEventType != NS_DRAGDROP_DROP mEventType != NS_DRAGDROP_DRAGDROP) return NS_OK; The way we handle a dataTransfer in test

[Bug 131145]

2011-05-20 Thread Ventnor-bugzilla
I've decided to work on this, and have spent most of the day implementing a patch. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in Ubuntu. https://bugs.launchpad.net/bugs/131145 Title: Dragging icon from

[Bug 131145]

2011-05-20 Thread Ventnor-bugzilla
Created attachment 533900 Patch Dragged this patch to the file upload control ;) jst, I think you're the most appropriate person for this? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in Ubuntu.