Launchpad has imported 47 comments from the remote bug at
https://bugzilla.gnome.org/show_bug.cgi?id=733210.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
On 2014-07-15T15:21:24+00:00 Rishi-is wrote:
In gtk+ 3.13.x GtkScrolledWindow animates the scrolling motion. See:
commit 3dcd0a24b1871c71e667df180334b4b861fbbc52
Author: Matthias Clasen
Date: Mon Jun 30 18:12:39 2014 -0400
GtkScrolledWindow: Enable animated scrolling
We use gtk_adjustment_enable_animation to enable animated
updates of the adjustments. Currently, this is enabled
unconditionally, and with a duration that is hardcoded.
https://bugzilla.gnome.org/show_bug.cgi?id=732376
Touch or thumb scrolling also comes for free with GtkScrolledWindow.
Let's put the VteTerminal widget in a GtkScrolledWindow instead of
creating our own vertical GtkScrollbar, so that we don't have to write
our own code for these.
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/0
On 2014-07-15T15:44:15+00:00 Rishi-is wrote:
Created attachment 280733
screen-container: Support animated and touch scrolling
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/1
On 2014-08-16T17:12:36+00:00 Chpe wrote:
Comment on attachment 280733
screen-container: Support animated and touch scrolling
I don't like this approach. GtkScrolledWindow is for use when your
content can adapt to size changes, which doesn't work with vteterminal.
Abusing it by hiding its scrollbar behind its back is too hacky.
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/2
On 2015-02-26T13:26:12+00:00 Rishi-is wrote:
(In reply to Christian Persch from comment #2)
> I don't like this approach. GtkScrolledWindow is for use when your content
> can adapt to size changes, which doesn't work with vteterminal.
These days VteTerminal can rewrap the content. Or were you talking about
something else?
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/3
On 2015-02-26T16:00:37+00:00 Rishi-is wrote:
Created attachment 297999
screen-container: Remove undefined public method
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/4
On 2015-02-26T16:01:07+00:00 Rishi-is wrote:
Created attachment 298000
screen-container: Remove wrong compiler attribute
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/5
On 2015-02-26T16:01:35+00:00 Rishi-is wrote:
Created attachment 298001
screen-container: Support animated and touch scrolling
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/6
On 2015-03-02T19:05:29+00:00 Matthias Clasen wrote:
Review of attachment 298001:
Looks good to me, otherwise. Great that the EXTERNAL policy found an
actual use case!
::: src/terminal-screen-container.c
@@ +107,3 @@
+ GTK_POLICY_NEVER,
+ GTK_POLICY_ALWAYS);
+ gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));
it would be more idiomatic to say
gtk_scrolled_window_new (NULL, NULL);
gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));
and have the two deal with their adjustments internally...
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/7
On 2015-03-02T19:06:21+00:00 Matthias Clasen wrote:
Review of attachment 298001:
Looks good to me, otherwise. Great that the EXTERNAL policy found an
actual use case!
::: src/terminal-screen-container.c
@@ +107,3 @@
+ GTK_POLICY_NEVER,
+ GTK_POLICY_ALWAYS);
+ gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));
it would be more idiomatic to say
gtk_scrolled_window_new (NULL, NULL);
gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));
and have the two deal with their adjustments internally...
Reply at: https://bugs.launchpad.net/ubuntu/+source/gnome-
terminal/+bug/1451924/comments/8
-
