[Bug 1715722] Re: Allow safe override of GDM3 theme

2019-02-17 Thread Jean-Pierre van Riel
I've noticed in 18.04.2 (upgraded from 16.04 LTS), with gnome-shell 3.28.3-0ubuntu0.18.04.4 and ubuntu-session 3.28.1-0ubuntu3, the *lock* screen is still pinning to /usr/share/gnome-shell/theme/ubuntu.css. Note, the login session screen is using the correct theme. This is related:

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-11-25 Thread mif
The version could be confirmed. I apologize for my misunderstanding. I was lack of a skill. When I replaced a css file simply, a lock screen didn't change. I'm thinking its cause is here separately. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-11-21 Thread mif
Thank you for checking source cord. Simply, I made gdm3.css and ubuntu.css a different file. So I noticed. But I noticed the version of GDM3 being old. It's 3.26.1-3ubuntu3 on Ubuntu 17.10 and POP! OS. I apologize for the confusion. Is a problem corrected by future's upgrade? -- You received

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-11-20 Thread Jeremy Soller
I tried looking for ubuntu.css in gnome-shell 3.26.1-0ubuntu5, but I did not find it. Where do you see this issue mifjpn? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-11-20 Thread Jeremy Soller
Yes mif, that will probably be an issue. I will write a patch. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722 Title: Allow safe override of GDM3 theme To manage

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-11-20 Thread mif
Setting of GDM was GDM3.css. But setting of screen lock is still ubuntu.css. I found it. Is it OK? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722 Title: Allow safe

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-11 Thread Jeremy Soller
Thanks very much! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722 Title: Allow safe override of GDM3 theme To manage notifications about this bug go to:

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-11 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-shell - 3.25.91-0ubuntu4 --- gnome-shell (3.25.91-0ubuntu4) artful; urgency=medium [ Jeremy Soller ] * Change path of gdm3 stylesheet (LP: #1715722) * Add alternatives for gdm3 stylesheet, setting ubuntu.css as the default [ Didier

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-11 Thread Daniel van Vugt
** Changed in: gnome-shell (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722 Title: Allow safe override of GDM3 theme To

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-11 Thread Didier Roche
Thanks for reporting the bug upstream! I tried to add some more context to the upstream bug report from our vendor perspective. The fix looks good, thanks! I'm currently testing it more. Also, I'm adding gnome-session to it: we can provide the same experience for people wanting to go really full

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-09 Thread Bug Watch Updater
** Changed in: gnome-shell Status: Unknown => Won't Fix ** Changed in: gnome-shell Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
The build finished, and I installed Ubuntu, Pop, and GNOME sessions side-by-side. All three worked, and the GDM theme changed based on the alternative selected. I believe the second patch version works as expected. -- You received this bug notification because you are a member of Ubuntu Desktop

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Ubuntu Foundations Team Bug Bot
The attachment "ubuntu_gdm_alternatives.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch"

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
Linking to an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=787454 ** Also affects: gnome-shell via https://bugzilla.gnome.org/show_bug.cgi?id=787454 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Desktop

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
11:01 Laney goodnight! 11:01 jackpot51 Ok, good night Laney 11:12 didrocksjackpot51: mind toning a little bit done please? 11:12 didrocksjackpot51: you are quite offensive in that bug report 11:13 didrocksand proposing a patch that you even didn't test it

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Didier Roche
Jeremy, you seem quite not listening to the advice we are giving to you, which is a maintainable solution to us. We told you multiple times we were happy to integrate what we think is a good solution from our perspective but you are not listening to those and seem like forcing your patch on us.

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
10:57 Laney hmm, I guess actually we could use this in Ubuntu to let people use the default gdm theme 11:00 Laney maybe not, that's the built in one isn't it? 11:00 Laney jackpot51: please attach it, I think it's worth considering -- You received this bug notification because you

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
What is even worse, is that most of these changes that hard-code Ubuntu's theme happened on the edge of the Feature Freeze period, meaning any attempts to revert them or improve them are impaired by bureaucracy. Please try to see why this is a problem, and learn from this in the future. -- You

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
didrocks, I will also work on an upstreamable solution, but I am not very satisfied with your unwillingness to see things from my perspective. You have essentially broken GDM3 for all Ubuntu derivatives, forcing your theme upon them, and then having no desire to work on any solution to remove this

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
Here is a new patch fixing the alternatives path. I am waiting on a launchpad build to test this fully: https://launchpad.net/~system76/+archive/ubuntu/pop- staging/+build/13352379 ** Patch added: "ubuntu_gdm_alternatives.debdiff"

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
** Patch removed: "ubuntu_gdm_alternatives.debdiff" https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1715722/+attachment/4946604/+files/ubuntu_gdm_alternatives.debdiff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Didier Roche
As told on IRC, I doubt this patch was tested. There is no reference of ubuntu.css in the postinst, and so, the alternatives is basically referencing itself. In general, I'm really not a fan of that approach as told many times and would prefer an upstreamable solution. However, if anyone else

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
didrocks, here is a debdiff for implementing the alternatives method. It did not require much code. Please let me know what you think! ** Patch added: "ubuntu_gdm_alternatives.debdiff"

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Didier Roche
Quoting from #ubuntu-devel on IRC: jackpot51 | didrocks: I am going to work on https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1715722 with the method I described first, having alternatives for a gdm.css file that is the stylesheet of GDM jackpot51 | It is critical to our Beta

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
didrocks, I am going to do what I described above as it is a clean and quick method to having both of our systems ready for a 17.10 Beta release. Is that ok? ** Changed in: gnome-shell (Ubuntu) Assignee: (unassigned) => Jeremy Soller (jackpot51) -- You received this bug notification

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-08 Thread Jeremy Soller
It is critical to our Beta release that we have a reliable method of overriding the GDM theme, so the alternatives method seems to be the best way to go. We can talk about further improvement and upstreaming after 17.10 -- You received this bug notification because you are a member of Ubuntu

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-07 Thread Didier Roche
Unassigning for now as I don't know if I'll have time to get that done for 17.10. However, I'll take any good patch from system76 implementing that feature (even better, I really think it should be pushed upstream). The best implementation IMHO is to not hardcode any css files with alternatives,

[Bug 1715722] Re: Allow safe override of GDM3 theme

2017-09-07 Thread Daniel van Vugt
** Changed in: gnome-shell (Ubuntu) Assignee: (unassigned) => Didier Roche (didrocks) ** Tags added: gnome-17.10 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1715722