[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
Denis, Please propose your fix to the developers here: https://gitlab.gnome.org/GNOME/gnome-shell-extensions ** Package changed: gnome-shell (Ubuntu) => gnome-shell-extensions (Ubuntu) ** Changed in: gnome-shell-extensions (Ubuntu) Status: New => In Progress ** Changed in: gnome-shell-extensions (Ubuntu) Assignee: (unassigned) => Denis Gorodnichev (d-g) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
The attachment "hotcorner.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
** Patch added: "hotcorner.patch" https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1725941/+attachment/5215275/+files/hotcorner.patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
introduced by optional-hot-corner.patch
fix:
diff --git a/extensions/apps-menu/extension.js
b/extensions/apps-menu/extension.js
index adc77a4..939a07c 100644
--- a/extensions/apps-menu/extension.js
+++ b/extensions/apps-menu/extension.js
@@ -240,17 +240,21 @@ class ApplicationsMenu extends PopupMenu.PopupMenu {
}
open(animate) {
-this._button.hotCorner.setBarrierSize(0);
-if (this._button.hotCorner.actor) // fallback corner
-this._button.hotCorner.actor.hide();
-super.open(animate);
+if (this._button.hotCorner) {
+this._button.hotCorner.setBarrierSize(0);
+if (this._button.hotCorner.actor) // fallback corner
+this._button.hotCorner.actor.hide();
+super.open(animate);
+}
}
close(animate) {
let size = Main.layoutManager.panelBox.height;
-this._button.hotCorner.setBarrierSize(size);
-if (this._button.hotCorner.actor) // fallback corner
-this._button.hotCorner.actor.show();
+if (this._button.hotCorner) {
+this._button.hotCorner.setBarrierSize(size);
+if (this._button.hotCorner.actor) // fallback corner
+this._button.hotCorner.actor.show();
+}
super.close(animate);
}
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-shell in Ubuntu.
https://bugs.launchpad.net/bugs/1725941
Title:
hotCorner modification breaks official apps-menu extension
To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
** Changed in: gnome-shell Status: Confirmed => Expired -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
Someone could always attempt a proper fix and propose it upstream. If upstream don't have to do the work then they might be more accepting of a fix. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
The issue appears to stem from the Main.layoutManager.hotCorners[] array being empty when hot corners are disabled: https://git.gnome.org/browse/gnome-shell-extensions/tree/extensions/apps-menu/extension.js?id=01893ca0485806f181d0401b7a6347a4adaa71de#n483 Would it be possible to leave the Main.layoutManager.hotCorners[] array defined and disable the activity overview by substituting no-op functions for actions? This is how the "No Topleft Hot Corner" extension works: https://github.com/HROMANO/nohotcorner/blob/f02c0398fe59202ba01b35ae04f8fe1fb46008e1/extension.js#L7 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
In fact, I'm not sure if this is this a bug with gnome-shell or with gnome-tweak-tool and the method it uses to disable hot corners. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
Unsure what we can do if upstream is not wanting to update their extension to handle that case well just to make a point, maybe somebody should create a new one including the suggested change? ** Changed in: gnome-shell (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
** Changed in: gnome-shell Status: Unknown => Confirmed ** Changed in: gnome-shell Importance: Unknown => Low -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1725941] Re: hotCorner modification breaks official apps-menu extension
** Bug watch added: GNOME Bug Tracker #712625 https://bugzilla.gnome.org/show_bug.cgi?id=712625 ** Also affects: gnome-shell via https://bugzilla.gnome.org/show_bug.cgi?id=712625 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1725941 Title: hotCorner modification breaks official apps-menu extension To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1725941/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
