[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-25 Thread Gunnar Hjalmarsson
New issue, though - bug #1758684 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of snapd are not translatable To manage notifications about this bug go

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-25 Thread Gunnar Hjalmarsson
This was finally fixed through the build of snapd 2.32+18.04. ** Changed in: snapd (Ubuntu) Status: In Progress => Fix Released ** Changed in: ubuntu-translations Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs,

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-20 Thread Gunnar Hjalmarsson
I know. New PR: https://github.com/snapcore/snapd/pull/4885 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of snapd are not translatable To manage

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-20 Thread AsciiWolf
The snapd-2.32+18.04~pre5 package is now available in Ubuntu 18.04, but it looks like the polkit strings are still not available for translation on Launchpad. :-( -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report.

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-15 Thread Gunnar Hjalmarsson
Sebastien let me know that a separate 2.32 PR is needed, so here it is: https://github.com/snapcore/snapd/pull/4855 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title:

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-03 Thread Gunnar Hjalmarsson
Don't know. I have assumed/hoped that 2.32 including those commits will make it into Ubuntu before the 18.04 release. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title:

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-03 Thread AsciiWolf
Ah, thanks for clarifying this. By the way, I see that the commits from your PR were merged only to the master branch, not to the 2.31 or 2.32 branches. Is this ok? I hope that the translated strings will be available in Ubuntu 18.04. -- You received this bug notification because you are a

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-02 Thread Gunnar Hjalmarsson
I digged a bit more about importing translations, and AFAICT it's a non- issue. Reason: LP *is* upstream. The .po files in upstream git consist of exported files from LP, and the latest sync happened last October. https://github.com/snapcore/snapd/pull/4053/commits/f884b3ba -- You received this

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-02 Thread AsciiWolf
As noted in the GitHub PR: It looks like that the translation sync with Launchpad is broken and the actual translations were last updated 5 months ago. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report.

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-03-02 Thread Gunnar Hjalmarsson
@AsciiWolf: Second thoughts on your note here: https://github.com/snapcore/snapd/pull/4723#issuecomment-369923663 Are there actually so many new translations in the upstream source to be imported? I see that the template in LP is dated 2018-02-20, which is fine. -- You received this bug

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-22 Thread Gunnar Hjalmarsson
Done. https://github.com/snapcore/snapd/pull/4723 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of snapd are not translatable To manage notifications

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-21 Thread Sebastien Bacher
Gunnar, do you think you could put a pull request on github for that change? That's where the snappy team is doing reviews, https://github.com/snapcore/snapd (feel free to ask on IRC if you need help with git or github) -- You received this bug notification because you are a member of Ubuntu

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-21 Thread AsciiWolf
Thanks for your great work! Feel free to let me know if you need help with something (testing etc.). -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-17 Thread Gunnar Hjalmarsson
xgettext() needs an applicable "rule" file to be able to extract strings from .policy files. The smoothest way to achieve that is to include policykit-1 in Build-Depends (not there currently AFAIK). policykit-1 provides /usr/share/gettext/its/polkit.{its,loc}. -- You received this bug

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-13 Thread Gunnar Hjalmarsson
Submitting a second variant which makes use of xgettext(), but also this one is basically untested. I simply don't know how to build the thing. :( ** Patch added: "0002-Translate-polkit-strings.patch"

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-12 Thread Gunnar Hjalmarsson
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of snapd are not translatable To manage notifications about this bug go to:

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-12 Thread Gunnar Hjalmarsson
I would think that the attached patch is what's needed to fix this. Caveat: This is untested. The regular xgettext() would extract those .policy file strings fine, but I don't know if xgettext-go() does. If not, a slightly different solution is needed. ** Patch added:

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-12 Thread AsciiWolf
The xml file should be also probably added to something like POTFILES.in. (Or maybe not, I am not an expert on Launchpad.) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title:

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-09 Thread AsciiWolf
For example Gufw (GUI for UFW firewall) has this in the polkit xml file: Authentication is required to run the Firewall Configuration -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report.

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-04 Thread AsciiWolf
Sorry, I don't know. Maybe someone from the Canonical desktop team will have more info about this. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-04 Thread John Lenton
How do other polkit-using projects do the translation? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of snapd are not translatable To manage

[Bug 1747272] Re: Polkit dialogs of snapd are not translatable

2018-02-04 Thread AsciiWolf
** Also affects: ubuntu-translations Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1747272 Title: Polkit dialogs of snapd are not