[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
Hereby requesting a review of the FFE request. The gtk support patch is up for review at: https://bugs.launchpad.net /ayatana-scrollbar/+bug/740276 (see comment #2) along with an updated branch supporting whitelist, blacklist, and environment variable to control when the feature should be active. A public testing campaign was run during the past weeks, with application compatibility results captured at: https://wiki.ubuntu.com/Ayatana/ScrollBars The code for the feature and the gtk patch have been code reviewed per our standard development practices. A very significant performance improvement was also made recently that suppresses slow downs noticed on particular apps (evolution for example). See https://bugs.launchpad.net/ayatana-scrollbar/+bug/728418 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
Sorry for the confusion, please consider the patch as of comment #3 here https://bugs.launchpad.net/ayatana-scrollbar/+bug/740276/comments/3 It's been tested and validated with rev. 172 of the library (http://bazaar.launchpad.net/~ayatana-scrollbar-team/ayatana- scrollbar/trunk/revision/172) which we are submitting for upload into Natty as well. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in Ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
still it seems that's not something natty will make use so what is the rational to justify spending work on that now rather than spending those efforts working on natty? it also seems that using a ppa would give extra flexibility to people working on the scrollbars and allow updates after natty is frozen -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
Cimi: That's not an issue, the series (major-minor number) is not going to be bumped for that cycle, so the GTK+ patch doesn't need to be updated for each release in the 0.1 series. Sébastien: From a technical point of view, I think that the clean way, which makes it potentially acceptable upstream, is to add that new widget directly inside GTK+ and add new symbols in GtkScrolledWindow to choose the scrollbar type to be used. But we've done that using a dynamically loaded module for this cycle because it reduces the GTK+ library size making it easier to fit on the CD, and it simplifies updating the ayatana-scrollbar library without implying a GTK+ update. Depending on the feedback, it will be easy to convert it to the clean way for Natty+1. I'll update the patch adding the ubuntu prefix. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
FFe wise, is that really something that we need to squeeze into natty, given our limited resources which we should better spend fixing bugs, regressions, missing features (a11y, accessibility, keyboard navigation), and performance of Unity? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
The main resource (Cimi) can't really help with the rest of the unity issues. Cimi is dedicated to toolkit, theme and theme engine improvements for Natty. I understand however that bugs triggered by this optional module should not impact the rest of the release. So we could update the gtk apport hook to add an 'overlay-scrollbar' tag to issues reported on applications where the LIBOVERLAY_SCROLLBAR env. variable was set. And put those outside of the release showstoppers list. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
the _gtk_scrolled_window_init() should be namespaced ubuntu since that's an ubuntu specific addition, the patch doesn't seem to be a real issue but doesn't seem ** Changed in: gtk+2.0 (Ubuntu) Importance: Undecided = Wishlist -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
please note that, from the patch above, we need to update the patch for each ayatana scrollbar release. do we want this? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 730740] Re: Provide support for dynamically loading the new overlay scrollbar feature
(sorry clicked enter by error) ...but doesn't seem a clean way to add a such feature as well but rather a setup for demo, do we really need to that hack in natty? ** Changed in: gtk+2.0 (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. https://bugs.launchpad.net/bugs/730740 Title: Provide support for dynamically loading the new overlay scrollbar feature -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs