Re: Continuous Builds in GNOME

2016-06-06 Thread Milan Crha
On Mon, 2016-06-06 at 20:32 +, Sriram Ramkrishna wrote: > I think that is the point of the try server, right?  You push it to > the try server and make sure that it builds correctly for everyone... Hi, if you mean that "jhbuild" is a synonym for "everyone", then you surely didn't open

Re: Continuous Builds in GNOME

2016-06-06 Thread Milan Crha
On Mon, 2016-06-06 at 22:21 +0200, Sébastien Wilmet wrote: > On Mon, Jun 06, 2016 at 10:10:58PM +0200, Sébastien Wilmet wrote: > > > > There is a solution: bump the major version of Camel or EDS each time an > > API or ABI break is unavoidable, making the new major version > >

Re: Continuous Builds in GNOME

2016-06-06 Thread Christian Hergert
On 06/06/2016 01:35 PM, Sriram Ramkrishna wrote: > I would think the docs team would be also interested. I wonder if we > could create coverage maps using this.. Generally the docs team doesn't write API documentation, but I certainly wouldn't turn anyone away that wants to write API docs for

Re: Continuous Builds in GNOME

2016-06-06 Thread Sriram Ramkrishna
On Mon, Jun 6, 2016 at 1:03 PM Christian Hergert wrote: > On 06/06/2016 12:48 PM, Michael Catanzaro wrote: > > I agree with you that when landing a big API change, if you don't want > > to use side branches, then a revert is less preferable to tagging in > > Continuous and

Re: Continuous Builds in GNOME

2016-06-06 Thread Sriram Ramkrishna
Hi Milan! On Mon, Jun 6, 2016 at 10:05 AM Milan Crha wrote: > On Mon, 2016-06-06 at 09:49 -0500, Michael Catanzaro wrote: > > A revert is not supposed to be "punishment" in any way... rather, > > consider it as assistance to make sure GNOME stays buildable. :) > > Hi,

Re: Continuous Builds in GNOME

2016-06-06 Thread Sébastien Wilmet
On Mon, Jun 06, 2016 at 10:10:58PM +0200, Sébastien Wilmet wrote: > There is a solution: bump the major version of Camel or EDS each time an > API or ABI break is unavoidable, making the new major version > parallel-installable with the previous ones. And that, every 6 months if > needed (or one

Re: Continuous Builds in GNOME

2016-06-06 Thread Christian Hergert
On 06/06/2016 01:02 PM, Christian Hergert wrote: > A couple weeks ago I wrote a quick hack to parse Continuous build logs > and extract CFLAGS for the built files. It can use this to then go > perform static analysis on the module with clang and extract/resolve all > function calls. And the

Re: Continuous Builds in GNOME

2016-06-06 Thread Christian Hergert
On 06/06/2016 12:48 PM, Michael Catanzaro wrote: > I agree with you that when landing a big API change, if you don't want > to use side branches, then a revert is less preferable to tagging in > Continuous and branching in jhbuild. (In such cases, it'd be great if > you could handle that before

Re: Continuous Builds in GNOME

2016-06-06 Thread Michael Catanzaro
On Mon, 2016-06-06 at 19:05 +0200, Milan Crha wrote: > Right, it's unrealistic in some cases to land all of that at one > time. > Side branches is a nice idea, but it won't work, because you do not > have any influence on the other project maintainers usually, thus > even > a bugzilla requests can

Re: Continuous Builds in GNOME

2016-06-06 Thread Milan Crha
On Mon, 2016-06-06 at 09:49 -0500, Michael Catanzaro wrote: > A revert is not supposed to be "punishment" in any way... rather, > consider it as assistance to make sure GNOME stays buildable. :) Hi, maybe it's not supposed to be, but it is in my eyes. I try my best to not break builds,

Re: Continuous Builds in GNOME

2016-06-06 Thread Michael Catanzaro
Hi, A revert is not supposed to be "punishment" in any way... rather, consider it as assistance to make sure GNOME stays buildable. :) But if you really don't like it and don't want other folks reverting your commits when you're not around, we can create a list of maintainers who don't want this;

Re: Continuous Builds in GNOME

2016-06-06 Thread Alberto Mardegan
On 03/06/2016 17:26, Sriram Ramkrishna wrote: > Yes, but it highlights the value something like GitHub provides. What > about GitLab? (BTW I'm not advocating we move, just looking to see > alternatives) GitLab while open source, does not seem to open source > its CI work that I can tell.

Re: Continuous Builds in GNOME

2016-06-06 Thread Carlos Soriano Sanchez
Hey Milan, | The proposal about random reverts makes me feel that you want to flip | the positions. While I agree that the maintainers point of view is | broken, the position flip just means (for me): "the GNOME | infrastructure/jhbuild environment is the only good build environment | and if the

Re: Enabling builddir != srcdir by default in jhbuild

2016-06-06 Thread Emmanuele Bassi
Hi; On 6 June 2016 at 12:23, Bastien Nocera wrote: > The "srcdir != builddir" implemented in jhbuild isn't the same one as > the one implemented in Continuous[1]. I know, that's why I wrote: """ The main change is that jhbuild runs the autogen script from within the build

Re: Enabling builddir != srcdir by default in jhbuild

2016-06-06 Thread Bastien Nocera
On Fri, 2016-06-03 at 13:11 +0200, Bastien Nocera wrote: > On Thu, 2016-06-02 at 23:50 +0100, Emmanuele Bassi wrote: > > [ Picking this up again ] > > > > I've been spending the last couple of days fixing modules on > > git.gnome.org (you may have noticed a commit or two from me on your > >

Re: Continuous Builds in GNOME

2016-06-06 Thread Milan Crha
On Fri, 2016-06-03 at 08:28 -0500, Michael Catanzaro wrote: > I expect module maintainers to be understanding when reverts happen. > It's not the end of the world; you can land your change again as soon > as you figure out why it was broken. We can all live with a few > revert commits in our git