Re: GtkTable is deprecated

2011-09-29 Thread Johannes Schmid
Hi!

 GtkGrid should be pretty much a drop-in replacement for GtkTable. Keep
 in mind that GtkGrid uses the align and expand flags of
 GtkWidget[2][3][4][5] instead of having expand and fill child
 properties.

 As always, should you have any questions, don't hesitate to ask.

This is a massive change to existing GtkBuilder .ui files so I would
suggest that somebody able to do xml and/or sed/grep magic would write a
script that just replaces GtkTable with GtkGrid in existing .ui files. If
that is included in gtk+ it would a lot of peoples lives easier.

(Or of course, Javier could fix all modules in GNOME Git but I somehow
doubt that he has the time...)

Regards,
Johannes

___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: GtkTable is deprecated

2011-09-29 Thread Matthias Clasen
On Thu, Sep 29, 2011 at 12:30 PM, Johannes Schmid j...@jsschmid.de wrote:
 Hi!

 GtkGrid should be pretty much a drop-in replacement for GtkTable. Keep
 in mind that GtkGrid uses the align and expand flags of
 GtkWidget[2][3][4][5] instead of having expand and fill child
 properties.

 As always, should you have any questions, don't hesitate to ask.

 This is a massive change to existing GtkBuilder .ui files so I would
 suggest that somebody able to do xml and/or sed/grep magic would write a
 script that just replaces GtkTable with GtkGrid in existing .ui files. If
 that is included in gtk+ it would a lot of peoples lives easier.

 (Or of course, Javier could fix all modules in GNOME Git but I somehow
 doubt that he has the time...)

deprecated != gone.

There is no super-urgent need to rid the world of GtkTables - unless
you want your module to compile with disabled deprecations.
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: GtkTable is deprecated

2011-09-29 Thread Johannes Schmid
Hi!

 deprecated != gone.

 There is no super-urgent need to rid the world of GtkTables - unless
 you want your module to compile with disabled deprecations.

Sure, but you know how picky some people are about deprecations...

Regards,
Johannes


___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: GtkTable is deprecated

2011-09-29 Thread Jasper St. Pierre
If GtkTable and GtkGrid were replaceable by a sed expression, I don't
think we would have bothered breaking API.

On Thu, Sep 29, 2011 at 1:11 PM, Johannes Schmid j...@jsschmid.de wrote:
 Hi!

 deprecated != gone.

 There is no super-urgent need to rid the world of GtkTables - unless
 you want your module to compile with disabled deprecations.

 Sure, but you know how picky some people are about deprecations...

 Regards,
 Johannes


 ___
 desktop-devel-list mailing list
 desktop-devel-list@gnome.org
 http://mail.gnome.org/mailman/listinfo/desktop-devel-list




-- 
  Jasper
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: GtkTable is deprecated

2011-09-29 Thread Benjamin Otte
On Thu, Sep 29, 2011 at 6:30 PM, Johannes Schmid j...@jsschmid.de wrote:
 This is a massive change to existing GtkBuilder .ui files so I would
 suggest that somebody able to do xml and/or sed/grep magic would write a
 script that just replaces GtkTable with GtkGrid in existing .ui files. If
 that is included in gtk+ it would a lot of peoples lives easier.

I am not sure that a simple script - and it'd probably be easy enough
to get a simple one going with some XSLT - because you need to fix the
expand and align flags of your widgets, and that means setting flags
on completely different widgets in the widget tree.
That transition is a thing I'd love to have seen tackled more by app
authors btw, but so far it wasn't necessary, so nobody bothered.
GtkBox and GtkTable didn't lose these flags in the transition to GTK3
after all.

Also, keep in mind that UI files won't cause deprecation warnings
during compilation. So unless you have code that live-edits tables,
your code will still continue to compile and run fine for the time
being.

Benjamin
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


GtkTable is deprecated

2011-09-28 Thread Benjamin Otte
Hey everyone,

So now with GNOME 3.2 out, it's time to make GTK break builds again.
So I deprecated GtkTable in GTK master[1]. GtkTable is turned more and
more problematic as GTK 3 evolves and the implementations of
height-for-width improved, which GtkTable does not support. So we were
ending up with more and more bugs about tables allocating way too much
space for widgets (feel free to ask the Empathy guys about it ;)).

GtkGrid should be pretty much a drop-in replacement for GtkTable. Keep
in mind that GtkGrid uses the align and expand flags of
GtkWidget[2][3][4][5] instead of having expand and fill child
properties.

As always, should you have any questions, don't hesitate to ask.

Happy hacking,
Benjamin


1: 
http://git.gnome.org/browse/gtk+/commit/?id=08d578dfcbbbc4769d8c26de4ea0de4f76e1b2de
2: 
http://developer.gnome.org/gtk3/unstable/GtkWidget.html#gtk-widget-set-hexpand
3: 
http://developer.gnome.org/gtk3/unstable/GtkWidget.html#gtk-widget-set-vexpand
4: http://developer.gnome.org/gtk3/unstable/GtkWidget.html#gtk-widget-set-halign
5: http://developer.gnome.org/gtk3/unstable/GtkWidget.html#gtk-widget-set-valign
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list