(In reply to Martin Stránský from comment #53)
The screensaver should not be inhibited by cpu and high-priority wake
locks. It looks like those are used to inhibit GC or disable power save (see
Bug 872430).
This isn't an issue with wake lock code, it's an issue with wake locks
being used
Created attachment 8424975
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8424975
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Addressed One. Last. Review. Comment.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5885f4bebdb
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status
Created attachment 8424521
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
(In reply to Karl Tomlinson (needinfo?:karlt) from comment #41)
+WakeLockTopic::UninhibitScreensaver()
+{
+ if (!mShouldInhibit) {
+// Screensaver isn't inhibited. Nothing to do here.
+return NS_OK;
Could this instead assert that this path is not reached, as in
Created attachment 8419908
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8419908
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Addressed review comments.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Comment on attachment 8415668
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Review of attachment 8415668:
-
::: widget/gtk/WakeLockListener.cpp
@@ +154,5 @@
+}
+ case Unsupported:
+
Created attachment 8415668
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
(In reply to Karl Tomlinson (:karlt) from comment #30)
+LOCAL_INCLUDES += $(MOZ_DBUS_CFLAGS)
+CFLAGS += $(MOZ_DBUS_GLIB_CFLAGS)
+CXXFLAGS+= $(MOZ_DBUS_GLIB_CFLAGS) -DHAVE_PTHREADS
Which parts of previous reviews have not been addressed and why not?
Oops, totally missed
Created attachment 8404228
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
(In reply to Chris Pearce (:cpearce) from comment #29)
@@ +391,1 @@
return nsBaseAppShell::Init();
You should probably remove the listener during shutdown too.
Shouldn't be neccessary. The WakeLockListener doesn't depend on anything
else being alive, and as jlebar noted, it will be
Created attachment 8404230
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Created attachment 8401684
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5225fd5622
https://hg.mozilla.org/integration/mozilla-inbound/rev/7426038bcac2
https://hg.mozilla.org/integration/mozilla-inbound/rev/dda6f2aa5225
--
You received this bug notification because you are a member of Desktop
Packages, which is
Created attachment 765640
Add gstreamer packages to mach bootstrap scripts
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status
Created attachment 765205
Better error message
A polite, friendly error message, with a clear call to action.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build
Created attachment 764414
Enable gstreamer by default, preffed off v3
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status in
https://hg.mozilla.org/integration/mozilla-inbound/rev/a73bc11da471
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status in The
Created attachment 763342
Enable gstreamer by default, preffed off v2
Addressed comment 64 and moved flag to build on desktop firefox only for
now (i.e. not desktop b2g yet) since those build slaves don't yet have
the right gstreamer packages.
--
You received this bug notification because you
All green: https://tbpl.mozilla.org/?tree=Tryrev=1539685e2272
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox with GStreamer support
Status in The
Created attachment 763014
Enable gstreamer by default, preffed off
Green on try:
https://tbpl.mozilla.org/?tree=Tryrev=5dc42fa92b2d
Some red due to buildbot config; just waiting on releng to get that
fixed up and we're golden.
--
You received this bug notification because you are a member of
23 matches
Mail list logo
