[Desktop-packages] [Bug 1654480]

2020-02-06 Thread Fisch-jeanpaul
Firefox is an essential project. I am so god damn happy that this has been fixed. omg. a basic feature built into youtube/audible, any major media distributor has built in speed controls expecting functional browser implementation. especially in the era of chromium based browser monopoly this is

[Desktop-packages] [Bug 1654480]

2020-02-06 Thread Padenot
Clearly something that we can do yes. I'm going to think about it today. Thanks for your kind message! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1654480 Title: HTML5 sound

[Desktop-packages] [Bug 1654480]

2020-01-07 Thread Ryanvm
Added to the Beta73 relnotes, thanks for flagging this. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1654480 Title: HTML5 sound choppy when played at 4x Status in Mozilla Firefox:

[Desktop-packages] [Bug 1654480]

2020-01-07 Thread Redox1337
Not sure whether this is considered inappropriate here, however I just wanted to say thank you tackling this issue. The latest Firefox nightly sounds nearly identical to Chrome for me now. So this is a huge improvement! I'm not sure whether this would be worth the effort, however I might see use

[Desktop-packages] [Bug 1654480]

2020-01-07 Thread Padenot
Release Note Request (optional, but appreciated) [Why is this notable]: Vastly improved audio quality when changing the audio playback rate during media playback. This was requested for years, and brings Firefox closer perceptually to other browsers [Affects Firefox for Android]: yes [Suggested

[Desktop-packages] [Bug 1654480] Re: HTML5 sound choppy when played at 4x

2019-12-19 Thread Bug Watch Updater
** Changed in: firefox Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1654480 Title: HTML5 sound choppy when played at 4x Status in Mozilla

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
Thanks. The patch is a significant improvement! At 4x with 10ms window, it's easy to comprehend speech. There is some slightly noticeable choppiness in some videos. I'm not an audio expert, but I tried to do some analysis using Audacity + Gimp. I plotted both track as Mel Spectrograms, took a

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
>From the author: https://www.surina.net/article/time-and-pitch- scaling.html -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1654480 Title: HTML5 sound choppy when played at 4x

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
I started digging into the SoundTouch library and confirmed my suspicion. https://hg.mozilla.org/mozilla- central/file/tip/media/libsoundtouch/src/TDStretch.cpp#l637 Author says it's implemented using "WSOLA-like method". Waveform- similarity-based synchronized overlap-add. Maybe based on this

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
Created attachment 9114054 2019-12-05_21-09-44 3x identical to 1x.png In this screenshot, the first track is Chrome, 2nd track is Firefox at 3x, and 3rd track is Firefox at 1x. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
Created attachment 9114055 2019-12-05_21-14-30 missing samples.png Top is 3x. Bottom is 1x. Estimate of the amount of audio data that is skipped before waveforms align. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
I used MOZ_DUMP_AUDIO=1 to capture samples from 1x vs 3x. The waveforms at 3x are identical to 1x for about 45ms. Then it skips and copies another 45ms. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Plurtu
Created attachment 9115722 sequence-size-comparisons.zip (In reply to alex.korchemniy from comment #23) > The waveforms at 3x are identical to 1x for about 45ms. Then it skips and > copies another 45ms. This is because the default sequence size at 2x speed is 40ms with some variation due to

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Pulsebot
Pushed by pade...@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f21621632fac Improve libsoundtouch high playback rate speech clarity with pitch preservation by using a smaller time stretcher sequence size r=padenot -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Plurtu
Created attachment 9115728 Bug 1427267 - Improve libsoundtouch high playback rate speech clarity with pitch preservation by using a smaller time stretcher sequence size -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Alex Korchemniy
With the SoundTouch algorithm there isn't much improvement with a window size below 10ms. I found a quicker way to test various parameters using mpv, which uses same/similar algo. When I get some time I'll generate random samples with various parameters and do a blind perceptual test. mpv

[Desktop-packages] [Bug 1654480]

2019-12-19 Thread Ncsoregi
https://hg.mozilla.org/mozilla-central/rev/f21621632fac -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1654480 Title: HTML5 sound choppy when played at 4x Status in Mozilla Firefox:

[Desktop-packages] [Bug 1654480]

2019-09-02 Thread Toxicbubble
I also just want to clarify: I notice this at 1.5 and 1.75 and 2x speeds as well, it's just more subtle - definitely still there though. Since the title here is talking about the issue at higher speeds, just want to make sure that it's not ignored for speeds <2x. -- You received this bug

[Desktop-packages] [Bug 1654480]

2019-09-02 Thread Padenot
It would be 1383363, and it's not too hard for someone that knows how to write DSP code, but needs to be prioritized. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1654480 Title:

[Desktop-packages] [Bug 1654480]

2019-09-02 Thread Gabdaten
(In reply to Bryce Seager van Dyk (:bryce) from comment #7) > I've been unable to repro this on OSX and a couple of other systems I've > tested. > > Isaac, are you still seeing issue? If so, could you please gather a log > using MOZ_LOG=MediaFormatReader:5? What are the prospects of this bug

[Desktop-packages] [Bug 1654480]

2019-09-02 Thread Bvandyk-0
Paul, do you have any thoughts on the difficulty of a fix here and if there are any related audio bugs we should be aware of/link to this bug? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 1654480]

2019-05-06 Thread Christopher Lovejoy
I believe this is due to Firefox playing ~70ms samples of audio at original speed, and skipping between them. In my experience with a similar effect in mplayer (https://mplayerhq.hu/), blending samples of about 15ms produces quality comparable to Webkit (Chrome, Opera). To test this yourself in

[Desktop-packages] [Bug 1654480] Re: HTML5 sound choppy when played at 4x

2018-12-27 Thread Bug Watch Updater
Launchpad has imported 18 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1427267. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at

[Desktop-packages] [Bug 1654480] Re: HTML5 sound choppy when played at 4x

2018-12-19 Thread Paul White
** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=1427267 Importance: Unknown Status: Unknown ** Changed in: firefox (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 1654480] Re: HTML5 sound choppy when played at 4x

2018-07-15 Thread Alex Korchemniy
This bug should have been opened with Firefox instead. I found the ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1427267 ** Bug watch added: Mozilla Bugzilla #1427267 https://bugzilla.mozilla.org/show_bug.cgi?id=1427267 -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 1654480] Re: HTML5 sound choppy when played at 4x

2018-06-28 Thread Paul White
Thank you for taking the time to report this bug and helping to make Ubuntu better. We are sorry that we do not always have the capacity to look at all reported bugs in a timely manner. There have been many changes in Ubuntu since that time you reported the bug and your problem may have been fixed

[Desktop-packages] [Bug 1654480] [NEW] HTML5 sound choppy when played at 4x

2017-01-05 Thread Alex Korchemniy
Public bug reported: I use a bookmarklet to set the playback rate on the HTML5 player element to 4x (tested with YouTube). Chrome handles the audio flawlessly, but Firefox becomes choppy after 2x. Here's the bookmarklet. The following line may get mangled or removed...