[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-10-11 Thread Olivier Tilloy
The gtk-common-theme snap in the candidate channel has now been promoted to stable, so I'm closing this bug. ** Changed in: chromium-browser (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-10-11 Thread Olivier Tilloy
I am not sure exactly which commit fixed the problem, but I suspect it's an update in Yaru itself. Possibly one of those: https://github.com/ubuntu/yaru/commit/4a6484deaa19c284344923efb1ccdc1998325aef https://github.com/ubuntu/yaru/commit/a0ff34f379d2b2d4673f4910970fdb02756b03b3 -- You

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-10-11 Thread Olivier Tilloy
As pointed out by Nicolás in https://forum.snapcraft.io/t/call-for- testing-chromium-browser-deb-to-snap-transition/11772/14, the gtk- common-themes snap in the candidate channel appears to fix the problem. I am now trying to bisect what change fixed the problem, and I will talk to the

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-07-19 Thread Olivier Tilloy
I'm attaching a screenshot demonstrating my claim above, showing gnome- calculator as a snap on the left, and from the deb on the right. This is in a clean and up-to-date disco VM, with Adwaita as the default theme. Colours clearly aren't right with the snap. -- You received this bug

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-07-19 Thread Olivier Tilloy
(and both are focused, of course) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to chromium-browser in Ubuntu. https://bugs.launchpad.net/bugs/1800260 Title: [snap] with CSD and Yaru, background color of the header bar is incorrect

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-07-19 Thread Olivier Tilloy
** Attachment added: "left: snap / right: deb" https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1800260/+attachment/5278047/+files/gnome-calculator-left-snap-right-nonsnap-adwaita.png -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-07-19 Thread Olivier Tilloy
This doesn't appear to be chromium-specific, nor Yaru-specific. I initially thought that only Yaru was exhibiting an incorrect background color for the focused headerbar, but I am now seeing an incorrect color with the gnome-calculator snap when using Adwaita. -- You received this bug

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-07-19 Thread Olivier Tilloy
I tested in an XFCE/XUbuntu session, and the focused headerbar color was correct, so there's something specific to the Ubuntu/GNOME session. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to chromium-browser in Ubuntu.

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-07-19 Thread Olivier Tilloy
I tested a few more things, unsuccessfully: - I modified the Yaru theme css in gtk-common-themes to remove the ".titlebar:not(headerbar)," selector, keeping only the "headerbar" selector for header bars, but no difference - I modified the custom selector in gtk_ui.cc to be just "#headerbar"

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-06-28 Thread Olivier Tilloy
I modified Yaru in the gtk-common-themes snap with different, garish colors for the focused and unfocused headerbar. In other snaps such as gnome-calculator these new colors were picked up as expected. In chromium, only the unfocused color was applied, the focused one remained (242,242,242). --

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-06-27 Thread Olivier Tilloy
This is not a confinement problem, as the same happens when the snap is installed in devmode. Something must be missing, either in the gtk-common-themes snap or in the snapcraft-desktop-helpers desktop-launch script, but I don't know what yet. I straced the execution of the snap, and it locates

[Desktop-packages] [Bug 1800260] Re: [snap] with CSD and Yaru, background color of the header bar is incorrect

2019-06-26 Thread Olivier Tilloy
I updated the title to reflect the fact that only Yaru (or communitheme on older releases) seems to be affected. All the other themes that I tested behave correctly. ** Summary changed: - [snap] with CSD, minimize and maximize buttons are invisible until hovered + [snap] with CSD and Yaru,