[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-12-08 Thread Robie Basak
> 3) the other minor changes in the new upstream release all seemed conservative fixes addressing simple issues that seemed LTS worthy (some even seemed to border on improving the security of some functions) The catch is that these changes then need individual review and consideration as to

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-12-07 Thread Loïc Minier
Thanks for the review Robie! Agreed that verification makes sense with a program built against both libraries before and after this fix Why backport 2.14 rather than cherry-pick the corresponding change? It would be feasible to cherry-pick just the change to add symbol versioning (you can see

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-12-07 Thread Robie Basak
OK, so to make sure I understand: nothing in the archive is directly affected by this bug. But if a user builds their own thing with both jansson and json-c, then the symbol conflict arises. I think this is still fine in principle to SRU, but I would like your out-of-archive component (vvas)

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-10-12 Thread Hon Ming Hui
The package that will experience the symbol conflict and crash is called vvas. We package it for the Xilinx partner project. VVAS is a major video analytic component and it linked with both jansson and json-c . I have some test packages built in my own ppa https://launchpad.net/~hm-

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-10-12 Thread Loïc Minier
@Timo/SRU team: I think the debdiff you're seeing is between kinetic and jammy, and since it's essential a backport, it would indeed be trivially small. The debdiff between latest jammy and this SRU corresponds to the new upstream release, and that's the part I've carefully reviewed with Hon Ming

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-10-12 Thread Robie Basak
Is there a specific user story that you're looking to fix here? Eg. crash reports in specific apps? What are you planning to rebuild to use the newly versioned symbols? If possible, I'd like to see these verified in proposed at the same time. On the specific fix, there is quite a bit of noise

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-09-14 Thread Loïc Minier
** Changed in: jansson (Ubuntu Jammy) Assignee: (unassigned) => Loïc Minier (lool) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to jansson in Ubuntu. https://bugs.launchpad.net/bugs/1987678 Title: Backport jansson 2.14 to jammy

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-09-12 Thread Loïc Minier
** Changed in: jansson (Ubuntu Jammy) Status: New => Incomplete ** Changed in: jansson (Ubuntu Jammy) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to jansson in Ubuntu.

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-09-09 Thread Timo Aaltonen
somehow the diff on the sru queue only shows the changelog diff and nothing else ** Also affects: jansson (Ubuntu Jammy) Importance: Undecided Status: New ** Changed in: jansson (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are

[Desktop-packages] [Bug 1987678] Re: Backport jansson 2.14 to jammy from kinetic

2022-09-07 Thread Loïc Minier
I reviewed the diff between 2.14 in kinetic and this upload (just changelog), and I carefully reviewed the 2.13 + Ubuntu changes to 2.14 + Debian changes diff again; outside of some autotools noise, the changes were carefully adding symbol versioning, a few symbols for new functions, and on the