-- GitLab Migration Automatic Message --
This bug has been migrated to freedesktop.org's GitLab instance and has
been closed from further activity.
You can subscribe and participate further through the new bug through
this link to our GitLab instance:
** Changed in: poppler
Status: Confirmed => Unknown
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288
Title:
Evince doesn't handle columns properly
Status in Poppler:
Created attachment 121848
Cache result of inner loop in visitDepthFirst
This is an alternative to Brian's patch in comment 65. This speeds up
the visitDepthFirst function by caching the result in the inner loop.
This provides a similar speedup without changing the output of
pdftotext.
--
You
Comment on attachment 121848
Cache result of inner loop in visitDepthFirst
Looks good to me, pushed. Thanks!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288
Title:
Evince
I went through the patch written by me and unfortunately I can not make
it so that it returns the same result as before. I've separated axes in
which it searches for immediate up/down/left/right neighbours, sorted
them and found the neighbours by single pass (+ number of possible
neighbour
I just realized we never really followed up on the last two patches.
My concern is that they change the pdftotext output.
I though they where for a) speed b) text selection so i'd prefer if they
did not change pdftotext output.
I've checked a few files of the changed ones and the changes can be
Created attachment 97356
Improve efficiency of searching for tables
(In reply to comment #68)
Created attachment 40308 [details] [review]
optimization of search for tables
This is an updated version of the patch. It needs Brian's patch to be
already applied. (see #77087 for additional info)
(In reply to comment #70)
(I originally replied on launchpad, which is supposed to copy it through
to here, but it hasn't.)
Carlos: it isn't a regression that lines outside a rectangle formed by
the start and endpoints are included, it's the intent.
Consider selecting in a document with two
(oops, replied on launchpad, not sure if Carlos reads there. Repeating
for fdo)
Carlos: it isn't a regression that lines outside a rectangle formed by
the start and endpoints are included, it's the intent.
Consider selecting in a document with two columns, starting in the 1st
column 2/3 down the
Carlos: it isn't a regression that lines outside a rectangle formed by
the start and endpoints are included, it's the intent.
Consider selecting in a document with two columns, starting in the 1st
column 2/3 down the page, ending in the 2nd column 1/3 down the page. In
this case, the correct
While working on bug #71160 I've found another regression introduced by
this fix. In some cases, additional lines are added to the selection.
For example, open the hig document and go to the first page. Start
selecting the second line, but dragging from the margin, and you will
see that the first
(In reply to comment #42)
Created an attachment (id=31406) [details]
3/5 reading order (bug fixed)
It seems this bug introduced an important performance regression, see
the detailed analysis in poppler mailing list:
http://lists.freedesktop.org/archives/poppler/2010-October/006566.html
--
Correctness trumps performance, right?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288
Title:
Evince doesn't handle columns properly
Status in Poppler:
Confirmed
Status in
It should be possible to improve this substantially. When I wrote the
patch I was being very conservative with the existing poppler data
structures, so essentially that method is traversing an unordered list.
If the block list was in isBeforeByRule1 order most of those comparisons
would go away. I
Created attachment 40061
improved patch
Had another look and tidied the code a bit removing repeated page
orientation checks, and a redundant test for overlap in rule(2). This is
noticeably faster rendering the bus map. (down to ~14.8s)
--
You received this bug notification because you are a
Created attachment 40056
patch to fix performance regression
Here's what I've got so far. On my very slow VM, this renders the paris
bus map reported on the mailing list in ~15.2s, compared to ~60s without
the patch. YX-sorting alone got the time down to ~16.2s. Rendering on
other documents is as
Can you please attach a patch without unnecessary spacing changes like
-before = gTrue;
+ before = gTrue;
Thanks :-)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288
There are also 2 nested for cycles in the block preceded by this
comment:
/* set extended bounding boxes of all other blocks
* so that they extend in x without hitting neighbours
*/
I'm working on an optimization of it.
Marek
--
You received this bug notification because you are a
(In reply to comment #65)
Created an attachment (id=40124) [details]
patch without extraneous whitespace changes
Oops! Ok, here's the patch without the whitespace changes.
Tested with the new whitespace patch - renders the map PDFs much faster
in cairo, other PDFs aven't changed much.
--
Created attachment 40308
optimization of search for tables
Hi,
this patch improves efficiency of searching for blocks which belong to a table.
In the worst case it is still quadratic but it should be O(n*sqrt(n)) in
average case.
It creates a list of all y coordinates and then sort it. After
(In reply to comment #62)
Created an attachment (id=40061) [details]
improved patch
Had another look and tidied the code a bit removing repeated page orientation
checks, and a redundant test for overlap in rule(2). This is noticeably faster
rendering the bus map. (down to ~14.8s)
I tested
Brian, your patch changes the output of pdftotext in a file, is this to
be expected?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288
Title:
Evince doesn't handle columns
Created attachment 40124
patch without extraneous whitespace changes
Oops! Ok, here's the patch without the whitespace changes.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288
23 matches
Mail list logo
