[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2017-01-08 Thread Alex Valavanis
** Changed in: inkscape Milestone: 0.91.1 => 0.92 ** Changed in: inkscape Status: Fix Committed => Fix Released ** Changed in: inkscape (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-09-30 Thread ~suv
On 2015-04-27 18:04 (+0200), ScislaC wrote: > Will be backporting, please do not adjust milestone. @ScislaC - is it ok if I backport r14060? AFAICT the diff applies ok (one offset), and I'll run tests later tonight with latest 0.91.x builds. -- You received this bug notification because you are

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-09-30 Thread ~suv
Fix from trunk r14060 backported to 0.91.x in rev 13829. ** Changed in: inkscape Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title:

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-09-30 Thread Launchpad Bug Tracker
** Branch linked: lp:inkscape/0.91.x -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV in file_save() Status in Inkscape: Fix Committed

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-04-27 Thread ScislaC
Will be backporting, please do not adjust milestone. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV in file_save() Status in Inkscape:

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-04-27 Thread Launchpad Bug Tracker
** Branch linked: lp:inkscape -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV in file_save() Status in Inkscape: Vector Graphics Editor:

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-04-27 Thread ScislaC
Patch reviewed and tested successfully on Ubuntu Vivid. Fix committed in trunk r14060. ** Changed in: inkscape Assignee: (unassigned) = Mark Harmer (drivehappy) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu.

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-11 Thread jazzynico
Thanks for your analysis, Mark! If I understand correctly, checking a save (or extension) in progress status before quitting (or destroying the desktop) would fix the issue? I'm not entirely sure why there's a need for a Glib::MainLoop in the script It seems to be used to cancel the running

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-11 Thread Mark Harmer
@jazzynico Thanks, I think that would solve the crash, however some issues come to mind with that solution: 1. It would introduce some global state, which would be tricky to reason about for anyone not familiar with the specifics. This is particularly complicated since it appears from the

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-11 Thread Johan Engelen
I want to remind you all that the majority of Inkscape's code is not at all ready for multithreading. This save code, and all the code and data it needs for saving the document is certainly not thread safe. So the fix is to remove the _main_loop_run stuff, and just do the save right there and then

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-11 Thread Mark Harmer
I've attached a proposed patch. One thing of note is that this actually keeps the Glib::MainLoop, after reading more into it, it appears that a recursive call to running a main loop is supported. The actual problem is that this was reusing the default MainContext which had all of the original

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-11 Thread Ubuntu Foundations Team Bug Bot
The attachment bug967416.patch seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-11 Thread ~suv
On 2015-01-12 02:38 (+0100), Mark Harmer wrote: This causes the expected blocking UI behavior until the script has completed saving since the new context shouldn't have any other sources. Unfortunately this does cause the UI to appear to be hung until the script completes the save, but given

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2015-01-10 Thread Mark Harmer
I thought I might take a crack at this since it looked interesting. I apologize for the length, I've added debugging details so hopefully it's clear. I'm new to the codebase and GTK, so I've added a lot so it can be double-checked. I don't think this is a threading problem. Rather, it looks like

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-11-05 Thread ~suv
** Changed in: inkscape Milestone: 0.91 = 0.91.1 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV in file_save() Status in Inkscape: A

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-09-14 Thread Bryce Harrington
Do we have a plan for fixing this? Threading bugs can be so tricky... Would it make sense to have the save routine set a lock when it starts, and then have the exit thread check for existing locks and refuse or delay exiting until they've cleared? Perhaps the lock could be timestamped so that

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-08-20 Thread jazzynico
Reproduced on Windows XP, Inkscape trunk revision 13528. But Inkscape opens the 'Do you want to save this file as Inkscape SVG first, and then crashes if the XCF (or other format) save isn't done. Scislac, could you please confirm it crashed with no save dialog on your computer? -- You

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-08-20 Thread Liam P. White
@jazzynico Confirming this behavior -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV in file_save() Status in Inkscape: A Vector Drawing

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-08-17 Thread ScislaC
Someone who can reproduce this: Does it at least emergency save still when it crashes? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV in

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-08-17 Thread Liam P. White
Reproduced with lp:inkscape/experimental r13485. If you save as XCF and then e.g press Ctrl+Q quickly enough Inkscape will show a message about failed export and then abort. It does not make an emergency save. #4 0x004c5d26 in Inkscape::DocumentUndo::getUndoSensitive

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-08-17 Thread ScislaC
I was able to reproduce just now as well. Given the lack of emergency save, this is a data loss issue. We could get into nitpicking about should have saved in svg first, but it's data loss in the end. ** Changed in: inkscape Importance: High = Critical ** Changed in: inkscape Milestone:

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-06-30 Thread Tavmjong Bah
This may be a wider problem that just in saving a file. Take a large file (icons.svg) and apply one of the color extensions to one of the icons. There is a high probability of a crash. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-06-30 Thread ~suv
On 2014-06-30 09:53 +0100, Tavmjong Bah wrote: This may be a wider problem that just in saving a file. Take a large file (icons.svg) and apply one of the color extensions to one of the icons. There is a high probability of a crash. Tracked in: - Bug 1333445 “various crashes with color

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-06-29 Thread Johan Engelen
It depends on quick timing. When saving the document, control returns to the GUI before the save is complete. If inkscape is closed in that period: crash. It seems a ton of crashes can happen when the save is still happening while inkscape is closed. The code is not at all ready for

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-06-29 Thread Johan Engelen
So to fix this, the exit procedure should be able to figure out if some threads are running in the background (the saving thread), and wait for it to start destroying objects. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in

[Desktop-packages] [Bug 967416] Re: inkscape crashed with SIGSEGV in file_save()

2014-06-29 Thread Johan Engelen
wait for it to start destroying objects. wait for it before starting to destroy objects. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to inkscape in Ubuntu. https://bugs.launchpad.net/bugs/967416 Title: inkscape crashed with SIGSEGV