[Desktop-packages] [Bug 1051559]
I created https://bugzilla.mozilla.org/show_bug.cgi?id=853306 to track and land the whitelist patch. Looking at the test_buffered failure next. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
A fix for the test_buffered failure is in https://bugzilla.mozilla.org/show_bug.cgi?id=853325 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Created attachment 727111 gst codec whitelist This patch makes the gst backend stop in ReadMetadata if the stream being decoded includes unsupported codecs. I'm not sure it's stopping in the right place, it makes playing http://www.tools4movies.com/dvd_catalyst_profile_samples/Harold%20Kumar%203%20Christmas%20bionic%20fast.mp4 fail with a video has stopped playing since the file is corrupt message. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Chris Pearce (:cpearce) from comment #54) I built latest trunk on my Fedora box this morning with --enable-gstreamer, and I still get the following test failure in content/media/test/test_buffered.html: TEST-UNEXPECTED-FAIL| unknown test url | owl.mp3: First range end should be media end - got 3.368, expected 3.3698 I will look into this, but isn't the resolution we're checking a bit too high? Do all the backends report exactly that duration or is it just that the test written against a specific backend? (In reply to Henri Sivonen (:hsivonen) from comment #5) (In reply to Chris Double (:doublec) from comment #3) 5) Test that when both H.264 and AAC decoders are absent, canPlayType() behaves like in Firefox today even if an MP4 demuxer is present. I tested this, I removed by gstreamer plugins and test_can_play_type_mpeg.html fails across the board. Is it failing in the expected way? 6) Test that MPEG4 Visual, MPEG2 or other non-H.264, non-AAC encumbered codecs do not get exposed to the Web as a side effect. I'm not sure that this is the case. I see that 3gpp is listed in GStreamerFormatHelper::mCodecs, we don't want that being exposed in canPlayType or for it to be playable. Yes 3gpp was copied there from the list of codecs supported by GONK i think. I'll remove it. It's also doesn't look like the GStreamer backend is whitelisting only the codecs that we want to support though. We'd want to only support H264, AAC and MP3, so as to prevent further format proliferation. For example this video plays with GStreamer, but shouldn't: http://www.tools4movies.com/dvd_catalyst_profile_samples/ Harold%20Kumar%203%20Christmas%20bionic%20fast.mp4 The video stream here is MPEG-4 part 2. No other browsers play that file; we can but refuse to in the Windows Media Foudation backend (bug 839055). And we should also refuse to play the file if either the audio or video stream are present but of unsupported formats as well... Does our GStreamer backend already do this? Attachment #72711 does this, although i'm not sure the behaviour is 100% right. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
Sorry I'm late to the discussion. There's something that hasn't been said that I want to clarify: GStreamer does take ABI compatibility very seriously. 0.10 was released in 2005 and we broke ABI compatibility for the first time now with 1.0. When we do break ABI compatibility, we make sure that older and newer versions are parallel-installable. This was the case for 0.8 vs 0.10 and it's the case today with 0.10 vs 1.0. There's a patch in https://bugzilla.mozilla.org/show_bug.cgi?id=806917 to support GStreamer 1.0. I'm going to review it in the next few days and try to get it landed. Keeping compile time compatibility with 0.10 and 1.0 should be relatively easy. If people think that runtime compatibility with both 0.10 and 1.0 is essential, I can look into that too. We could dinamically probe and load GStreamer or even have two distinct backends using MPAPI. About the security concerns, the upstream gst community is fairly receptive to any kind of patches, and there's some overlap with debian/ubuntu/fedora developers, so those distro usually get the latest and greatest gst fairly quickly. In addition to that, we could potentially consider importing the ogg/webm/h264 gst plugins in m-c so there's even more control over those. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Chris Double (:doublec) from comment #51) (In reply to Alessandro Decina from comment #46) In addition to that, we could potentially consider importing the ogg/webm/h264 gst plugins in m-c so there's even more control over those. If this means we'd be shipping an H.264 decoder, we can't do that. Yeah sorry for not being more explicit. I meant only the gst side of the plugin, which is the part that wraps the actual codec implementation and just does setup, makes sure input isn't grossly malformed etc. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1051559]
(In reply to Chris Pearce (:cpearce) from comment #47) (In reply to Alessandro Decina from comment #46) In addition to that, we could potentially consider importing the ogg/webm/h264 gst plugins in m-c so there's even more control over those. I'd rather keep our existing backends/libraries for decoding Ogg and WebM unless there's a compelling reason to switch to using GStreamer for those formats. The only possible advantage I can see in using GStreamer for webm is performance on mobile platforms. I have seen ARM vendors spend time optimizing webm with their own codecs and some have announced webm hw support. GStreamer has pretty good support for vendor provided codecs in android/linux platforms. I do see your point though and realize that what I said above can be handled on a case by case basis with the media.prefer-gstreamer pref. Our Ogg and WebM libraries have been fuzzed pretty hard over the years, and our backends using those libraries have been well tested and are known to be robust and work well. We don't really want to redo all that robustification work for Ogg and WebM, we won't gain much by doing that now. Keeping our existing libraries also ensures Firefox's media playback behaviour is more likely to remain consistent across all platforms. This makes sense. FWIW I saw that the test suite includes some half broken/forged files. Last time I checked the gst backend did pretty well with those, with the exception of one theora file that caused a crash for which I have a patch laying somewhere. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “iceweasel” package in Debian: New Status in “firefox” package in Fedora: Unknown Bug description: Building Firefox with GStreamer support would provide support for a lot of websites that use h264. To build Firefox with GStreamer support you should use the --enable-gstreamer option. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
