(In reply to n...@parkwaycc.co.uk from comment #127)
(In reply to Josiah Bruner from comment #125)
- Customize From Address is confusing. “Enter a custom address” perhaps?
OK (but see below)
- If you choose a custom address (which focuses the field), and then you
deselect the field, and
Comment on attachment 8553148
Possible patch
Review of attachment 8553148:
-
Sorry for the delayed review!
UI-Review:
Minor Nits:
- Customize From Address is confusing. “Enter a custom address” perhaps?
- If you choose
Comment on attachment 8525381
Possible patch
Review of attachment 8525381:
-
Okay, I do like that addresses can be edited, and don't really have an
issue with it. However, it showing up when clicking the label isn't very
intuitive.
Created attachment 8544150
Example sketch.
Here's the example. In addition, if the user deselects the field without
inputting any text, we should revert the field back to being selectable
(with the options).
It would also be preferable to allow clicking the drop down icon to
always bring up the
(In reply to Ben Bucksch (:BenB) from comment #104)
josiah: Ping
The patch still doesn't work properly. On my machine absolute nothing changes.
I pinged Neil about this on IRC today.(In reply to Ben Bucksch (:BenB) from
comment #105)
As for UX, I agree with Neil: Most common action would be
*** Bug 1105724 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1347305
Title:
Address fields are grey when composing messages
Created attachment 8515389
WIP
Not even close to done, but I'm uploading my WIP for documentation.
(I'll go ahead and upload the screenshot as well)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Created attachment 8515395
WIP
Whoops, I messed up the padding of the toolbar on accident. This patch
corrects that and cleans up some other styling.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Created attachment 8515396
WIP screenshot.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1347305
Title:
Address fields are grey when composing messages
Status in Mozilla
Created attachment 8515397
Use -moz-mac-vibrancy-light screenshot
Also, here's an idea I had to add vibrancy to the OS X 10.10 version. I
think it looks pretty nice, but I'm not convinced it's worth it
considering the trouble it will be to obtain border colors for the
fields (which in this
Created attachment 8515391
WIP screenshot.
Screenshot.
Please, please, please don't comment on this with specific details you'd
like addressed, or other multi-page comments. :) I'm still working on
getting a basis, so limit comments to general ideas.
--
You received this bug notification
(In reply to Andrew Buehler from comment #67)
Based on comment 52, I'm presuming that this would be intended as a
cross-platform appearance (as much as possible given OS/toolkit
capabilities), not something Mac-specific despite the current screenshots?
Yes, it will be XP, though the current
(In reply to n...@parkwaycc.co.uk from comment #100)
Created attachment 8507858
87987.png
This is what I get locally... are you not seeing this?
No, hovering over the dropmarker doesn't do anything for me.
--
You received this bug notification because you are a member of Desktop
Packages,
Comment on attachment 8507858
87987.png
Ignoring the fact that the patch doesn't function properly for me, I'm
still not convinced this is the right approach.
I like that we're enabling custom editing, and am not against the
purpose of the bug, but I think this idea is putting too much emphasis
Created attachment 8507360
OS X 10.10 Compose Proposal
Alternatively, I would suggest following what OS X does now, and have
full lines with the header background the same color as the input area.
--
You received this bug notification because you are a member of Desktop
Packages, which is
First of all, I want to thank you for having an issue with the design
*and taking action* on it, it's very much appreciated, and a rare
quality. I actually am a fan of your idea, and think that if done
properly, could balance the cleaner design without having such a
radical change.
(In reply to
*** Bug 1084539 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1347305
Title:
Address fields are grey when composing messages
Although now the address can be edited (via keyboard), I can no longer
click on the header to select from my existing accounts as you can
currently.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Hmm... This completely removes the ability to choose from your accounts
though, and I don't think that's a good idea. This is significantly
harder to use. Was that your intent?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird
Comment on attachment 8377817
patch v5
Review of attachment 8377817:
-
I'm good with:
A subfolder with the name '%$1S' already exists in the folder '%2$S'.
Would you like to move this folder using the new name '%3$S'?
(So sans the
Err. Except in that while statement there should be a:
counter++
line right before we read new data.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a
No. The idea here is very similar to the common priming read concept
taught in introductory CS courses. Following such a pattern the code
here should be:
newFolderName.Assign(folderName);
bool containsChild = true;
int counter = 2;
//Priming Read
rv = ContainsChildNamed(newFolderName,
(In reply to Ulf Zibis from comment #108)
(In reply to n...@parkwaycc.co.uk from comment #107)
Hi, why not using for statements:
+newFolderName.Assign(folderName);
+bool containsChild = true;
+for (uint32_t i=2; ; i++) {
+ rv = ContainsChildNamed(newFolderName,
Comment on attachment 8370331
WIP patch 2
Review of attachment 8370331:
-
So this seems like a fine approach to me. I think that we should call
each folder folder(x) instead of folder-x, as it more clearly
indicates duplicates
Yeah, for trash moving automatically is fine.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the same
25 matches
Mail list logo
