[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-09-04 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-screensaver - 3.6.1-7ubuntu6 --- gnome-screensaver (3.6.1-7ubuntu6) artful; urgency=medium * Add support for Budgie Desktop (LP: #1703690) - enable support for gnome-control-center - style the lock-screen using the "Unity" patch-work

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-09-04 Thread Iain Lane
Sponsored, thanks. For gnome-desktop3, I merged your patch into the revert patch since I thought it made sense there. If that's too annoying in future, someone can split it back out. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-09-04 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-desktop3 - 3.25.91.1-0ubuntu2 --- gnome-desktop3 (3.25.91.1-0ubuntu2) artful; urgency=medium * debian/patches/git_revert_draw_background.patch: Check org.gnome.desktop.background explicitly, not via the passed-in GSettings. We're

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-31 Thread fossfreedom
please find enc two revised patches that hopefully take into account Laney and Lukasz comments. gnome-desktop3 is very much simplified to explicitly check the draw_background key from the background schema. Note - I haven't included a new changelog for this debdiff. gnome-screensaver reworks to

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-31 Thread fossfreedom
** Patch removed: "patch 1 of 2: patch for gnome-desktop3" https://bugs.launchpad.net/ubuntu/+source/gnome-desktop3/+bug/1703690/+attachment/4913063/+files/gnome-desktop3_3.24.2-0ubuntu2.debdiff ** Patch removed: "patch 2 of 2: patch for gnome-screensaver"

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-31 Thread fossfreedom
** Patch added: "gnome-desktop3_3.25.91.1-0ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/gnome-desktop3/+bug/1703690/+attachment/4942038/+files/gnome-desktop3_3.25.91.1-0ubuntu1.debdiff -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-24 Thread fossfreedom
additionally " two things on the gnome-screensaver one: in_desktop should probably use g_strv_contains instead of iterating the list and I think you should find (or create) a common file to contain that utility function rather than defining it multiple times" -- You received this bug

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-24 Thread fossfreedom
discussed on IRC with Laney - suggestion: make the is_enabled check use a new GSettings, like GSettings *background_settings; background_settings = g_settings_new ("org.gnome.desktop.background"); bg->is_enabled = g_settings_get_boolean (background_settings, BG_KEY_DRAW_BACKGROUND);

Re: [Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-03 Thread fossfreedom
Thanks Łukasz With regards to the gnome-desktop3 patch. I had a look through the gsettings API and there didnt seem to be a method to say "is this gsettings key you are about to use valid" - in fact all the documentation basically says it is up to the programmer to ensure that a key being used

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-08-03 Thread Łukasz Zemczak
Hello! Thanks for submitting the bug and patches! I looked briefly at the provided debdiffs and from the packaging POV they look good. I'm not sure about the contents though. I am not a GNOME developer so I'd like to get some opinion of someone that knows the code and would be able to say if it's

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-07-11 Thread fossfreedom
** Patch added: "patch 2 of 2: patch for gnome-screensaver" https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/1703690/+attachment/4913064/+files/gnome-screensaver_3.6.1-7ubuntu6.debdiff ** Tags added: patch -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 1703690] Re: Add support for Budgie Desktop using GNOME Screensaver

2017-07-11 Thread fossfreedom
** Patch added: "patch 1 of 2: patch for gnome-desktop3" https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/1703690/+attachment/4913063/+files/gnome-desktop3_3.24.2-0ubuntu2.debdiff -- You received this bug notification because you are a member of Desktop Packages, which is