[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-29 Thread Gunnar Hjalmarsson
Those strings are available in LP now. ** Changed in: ubuntu-translations Status: New => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-online-accounts in Ubuntu. https://bugs.launchpad.net/bugs/1759251

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-29 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-online-accounts - 3.27.92-1ubuntu3 --- gnome-online-accounts (3.27.92-1ubuntu3) bionic; urgency=medium * debian/rules: Make sure that gnome-online-accounts.pot is refreshed so the strings from 0001-ubuntu-sso-provider.patch are

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-29 Thread Sebastien Bacher
Let's upload your fix for now so we unblock the translators ** Changed in: gnome-online-accounts (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-online-accounts in Ubuntu.

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-28 Thread Gunnar Hjalmarsson
For test purposes I made this change: $ diff /usr/bin/dh_translations.orig /usr/bin/dh_translations 112c112 < @cmd=('make', $domain . '.pot'); --- > @cmd=('make', $domain . '.pot-update'); Then I built gnome-online-accounts locally, and the .pot file was nicely updated. So

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-28 Thread Gunnar Hjalmarsson
Actually I think that "make $(DOMAIN).pot-update" would have worked for gnome-online-accounts. From po/Makefile: # This rule has no dependencies: we don't need to update $(DOMAIN).pot # at every "make" invocation, only create it when it is missing. # Only "make $(DOMAIN).pot-update" or "make

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-28 Thread Sebastien Bacher
> Question: Does po/Makefile always understand "make $(DOMAIN).pot- update"? No, that's specific to meson project I think, "classic autotools based" GNOME components (or pre-conversion) just understand the "make $domain.pot" target The change is hackish but I don't see a better way at the

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-27 Thread Gunnar Hjalmarsson
Question: Does po/Makefile always understand "make $(DOMAIN).pot- update"? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-online-accounts in Ubuntu. https://bugs.launchpad.net/bugs/1759251 Title: Ubuntu Single Sign-On not

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-27 Thread Gunnar Hjalmarsson
Jeremy just let me know that "Hmm" means this: An alternative to the proposal in the debdiff might be to change line 112 in dh_translations from @cmd=('make', $domain . '.pot'); to @cmd=('make', $domain . '.pot-update'); in order to force an update without the rename trick. This might benefit

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-27 Thread Jeremy Bicha
Hmm -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-online-accounts in Ubuntu. https://bugs.launchpad.net/bugs/1759251 Title: Ubuntu Single Sign-On not translated Status in Ubuntu Translations: New Status in

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-27 Thread Gunnar Hjalmarsson
We need to ask dh_translations for an update of gnome-online- accounts.pot. ** Patch added: "gnome-online-accounts_build-pot.debdiff" https://bugs.launchpad.net/ubuntu/+source/gnome-online-accounts/+bug/1759251/+attachment/5092841/+files/gnome-online-accounts_build-pot.debdiff ** Changed in:

[Desktop-packages] [Bug 1759251] Re: Ubuntu Single Sign-On not translated

2018-03-27 Thread Jeremy Bicha
** No longer affects: gnome-control-center (Ubuntu) ** Also affects: ubuntu-translations Importance: Undecided Status: New ** Changed in: gnome-online-accounts (Ubuntu) Importance: Undecided => High ** Changed in: ubuntu-translations Importance: Undecided => High -- You