Comment on attachment 756209
fixed patch
Removing obsolete review request.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed
(In reply to Magnus Melin from comment #15)
Comment on attachment 756209
fixed patch
Review of attachment 756209:
-
Basically looks good, but i think we should skip warn on many for update
prompt. I suppose such cases exist
** Changed in: thunderbird
Status: Confirmed = Won't Fix
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed limit per
Comment on attachment 756209
fixed patch
Review of attachment 756209:
-
Basically looks good, but i think we should skip warn on many for update
prompt. I suppose such cases exist in theory, but if it's an evil feed
people would
The objective, per the title of the bug, is to handle an erroneous deluge, upon
update. Not to nag a user about a high count feed they've already
approved/subscribed. So while 1000 is a testable number, the final number
could be 5000 or 1. At that edge case, the user can cancel and
I still would like to know what choice this patch actually gives you.
(The string somewhat unhelpfully says Continue? which suggests that it
gives you the choice of using up lots of CPU and memory now or annoying
you with another prompt again in 100 minutes.)
--
You received this bug
Comment on attachment 755964
updated for comments
+ mLastModified: null,
Not sure how this change relates.
- win.updateStatusItem(statusText, message, aErrorCode);
+ let code = feed.url.startsWith(http) ? aErrorCode : null;
+ win.updateStatusItem(statusText, message, code);
Not
(In reply to alta88 from comment #6)
(Seems this patch needs bug 254231 applied first.)
it shouldn't be necessary; some minor checks/logs that happened to be there
because i did it first were moved here, to make that one simple for sec.
Doesn't apply without it...
--
You received this
(In reply to Magnus Melin from comment #4)
Comment on attachment 754287
patch
Review of attachment 754287:
-
Suite's newsblog.properties needs updating too.
(Seems this patch needs bug 254231 applied first.)
it
for suite/ strings.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed limit per download
Status in Mozilla Thunderbird Mail and
(In reply to n...@parkwaycc.co.uk from comment #10)
Comment on attachment 755964
updated for comments
+ mLastModified: null,
Not sure how this change relates.
it needs to be cached in case of a cancel, it would break new refreshes if set
prior to full completion.
-
Comment on attachment 754287
patch
Review of attachment 754287:
-
Suite's newsblog.properties needs updating too.
(Seems this patch needs bug 254231 applied first.)
:::
Created attachment 756209
fixed patch
wow, the patch got mangled along the way. sorry gents. built and tested with
this one.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Created attachment 755964
updated for comments
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed limit per download
Status in
Comment on attachment 755964
updated for comments
Review of attachment 755964:
-
::: mailnews/extensions/newsblog/content/utils.js
@@ +673,5 @@
+ * @param obj aFeed - the feed object.
+ * @param integer aCount - number of
Created attachment 754267
patch
Not testing for 0 or ∞ is never good.
This patch:
1. Prompts for confirmation on a new subscribe if the feed file item count
100.
2. Prompts if a feed update contains 1000 items; prompts are stacked.
3. Enables a cancel; fixes false prompt and non cancel on
good test feeds, with 1000 items:
https://jazz.net/library/rss/
http://www.livejournal.com/stats/latest-rss.bml
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Created attachment 754287
patch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed limit per download
Status in Mozilla
** Changed in: thunderbird
Status: New = Confirmed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006
Title:
Thunderbird RSS should have a per feed limit per download
19 matches
Mail list logo
