[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-21 Thread Adam Conrad
Promoted with slightly more gusto: Override component to main volume-key 0.3.9-4 in bionic: universe/misc -> main libvolume-key-dev 0.3.9-4 in bionic amd64: universe/libdevel/optional/100% -> main libvolume-key-dev 0.3.9-4 in bionic arm64: universe/libdevel/optional/100% -> main

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-20 Thread Steve Langasek
Override component to main volume-key 0.3.9-4 in bionic amd64: universe/utils/optional/100% -> main volume-key 0.3.9-4 in bionic arm64: universe/utils/optional/100% -> main volume-key 0.3.9-4 in bionic armhf: universe/utils/optional/100% -> main volume-key 0.3.9-4 in bionic i386:

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-17 Thread Mathieu Trudel-Lapierre
MIR approved. The new version synced from debian in bionic (UNAPPROVED) looks good now, and appears to have corrected test suite issues: 18057438 | X- | volume-key | 0.3.9-4 | 6 hours | * volume-key/0.3.9-4 Component: universe Section: misc ** Changed in:

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-17 Thread Iain Lane
it's synced now, so never mind "pre-upload" -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu. https://bugs.launchpad.net/bugs/1754422 Title: [MIR] volume-key Status in volume-key package in Ubuntu: In Progress

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-16 Thread Iain Lane
volume-key_0.3.9-4 is uploaded to unstable. Although I forgot to say it in the changelog, it runs the tests fatally. I'd still like some confirmation that my patch is OK, but assuming it is - it could be synced. cyphermox - any chance you could review it pre-upload and approve the MIR on the

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-16 Thread Iain Lane
umm, that's nonsense, try "just needed to have a writable home directory" -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu. https://bugs.launchpad.net/bugs/1754422 Title: [MIR] volume-key Status in volume-key

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-16 Thread Iain Lane
ok, just needed to be run as root, I asked jibel if he could test my proposed package in ppa:laney/ppa, just waiting to hear back -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu.

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-10 Thread Iain Lane
** Also affects: volume-key (Ubuntu Bionic) Importance: Undecided Assignee: Mathieu Trudel-Lapierre (cyphermox) Status: Incomplete ** Changed in: volume-key (Ubuntu Bionic) Assignee: Mathieu Trudel-Lapierre (cyphermox) => Iain Lane (laney) ** Changed in: volume-key (Ubuntu

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-10 Thread Iain Lane
nein, it still fails even with this from a package build, but works when you chroot in and run the test :( -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu. https://bugs.launchpad.net/bugs/1754422 Title: [MIR]

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-10 Thread Iain Lane
gpgme_set_pinentry_mode (ctx, GPGME_PINENTRY_MODE_LOOPBACK) fixes this, apparently this is required with newer gpg, not sure where the right place to put this is tho -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu.

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-09 Thread Mathieu Trudel-Lapierre
Have the tests been fixed? I really don't much like having things in main that run tests but don't use the result; is there any way to just ignore the test(s) that are really broken and otherwise keep the remaining tests failing the build if they fail, such that we can catch a possible regression?

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-04-05 Thread Jeremy Bicha
I think we're just waiting on final approval from cyphermox now. ** Changed in: volume-key (Ubuntu) Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu.

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-27 Thread Jeremy Bicha
> The tests shouldn't be failing in a brand-new project. Sadly, the project is not new at all (although it's only in Debian now because of udisks2). The current release packaged in Ubuntu, 0.3.9, was released in 2012. https://pagure.io/volume_key/commits/master -- You received this bug

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-27 Thread Seth Arnold
I reviewed volume-key version 0.3.9-3 as checked into bionic. This should not be considered a full security audit but rather a quick gauge of maintainability. - No CVEs in our database. - volume-key's main purpose is to provide some key escrow capabilities for encrypted storage -

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-27 Thread Seth Arnold
The security review is underway. I'm sad that tracking this test case failure down is as complicated as it is -- the code feels overly- generic, tracking call chains through to where anything is *done* is harder than other code bases. Each individual line of code looks fine but getting a handle on

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-27 Thread Jeremy Bicha
I reported the test failures upstream several days ago, but I haven't gotten a response yet. https://pagure.io/volume_key/issue/15 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu.

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-27 Thread Iain Lane
can you be extra clear with us please - are you saying that this test needs to be made to pass or we need to explain why it doesn't or what? Are you planning to perform a security review? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-22 Thread Mathieu Trudel-Lapierre
Wild guess is this is a test that expects user input, and the input never shows up? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in Ubuntu. https://bugs.launchpad.net/bugs/1754422 Title: [MIR] volume-key Status in

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-21 Thread Jeremy Bicha
- Why did this not fail the build? Because then the build wouldn't work! I mentioned this in the MIR description under Quality Assurance. - Why did this fail? I don't know. Once we know how to get the tests to pass, I'll be happy to make test failures fail the build. (Currently, they're ignored

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-21 Thread Jeremy Bicha
With this commit, I now get this error: "Error creating passphrase-encrypted packet: GPGME: Bad passphrase" https://salsa.debian.org/utopia-team/volume-key/commit/42207b3d -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to volume-key in

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-21 Thread Jeremy Bicha
I mean this part of the log seems like it's obviously not going to work. --- To begin, type keys on the keyboard until this progress meter is full. DO NOT USE THE AUTOREPEAT FUNCTION ON YOUR KEYBOARD! Continue typing until the

[Desktop-packages] [Bug 1754422] Re: [MIR] volume-key

2018-03-21 Thread Seth Arnold
The tests run during the build failed on my machine yet the build did not fail: Error creating passphrase-encrypted packet: Unknown error getting encryption result FAIL tests/packet_roundtrips.sh (exit status: 1)