---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24855/#review51310
---
Ship it!
Minor clarification. Otherwise, LGTM.
If you get an error from a BatchWriter, you pretty much have to throw
away that instance of the BatchWriter and make a new one. See
ACCUMULO-2990. If you want, you should be able to catch/recover from
this without having to restart the ingester.
If the session ID is invalid, my guess is that
Thanks Josh,
I understand about the session ID completely but the problem I have is that
the exact same client code worked, line for line, just fine in 1.4.4 and
it's acting up in 1.6.0. I also seem to remember the BatchWriter
automatically creating a new session when one expired without an
Don't mean to tell you that I don't think there might be a
bug/otherwise, that's pretty much just the limit of what I know about
the server-side sessions :)
If you have concrete this worked in 1.4.4 and this happens instead
with 1.6.0, that'd make a great ticket :D
The BatchWriter failure
Josh,
Your advice is definitely useful- I also thought about catching the
exception and retrying with a fresh batch writer but the fact that the
batch writer failure doesn't go away without being re-instantiated is
really only a nuisance. The TabletServerBatchWriter could be designed much
better,
