Re: Review Request 26153: ACCUMULO-3182 WAL recovery on empty files doesn't fail

2014-10-02 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26153/#review55209 --- Ship it!

Re: Review Request 26153: ACCUMULO-3182 WAL recovery on empty files doesn't fail

2014-10-02 Thread Josh Elser
On Oct. 2, 2014, 3:49 p.m., kturner wrote: test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java, line 75 https://reviews.apache.org/r/26153/diff/3-4/?file=709899#file709899line75 This is funny. Was this something you only saw after switching to

Jenkins now building pull-requests against apache/accumulo

2014-10-02 Thread Josh Elser
FYI, I just enabled a new Jenkins job that should see any pull-requests opened against http://github.com/apache/accumulo, build it, and share the results. * https://builds.apache.org/job/Accumulo%20Pull%20Requests/ * https://blogs.apache.org/infra/entry/github_pull_request_builds_now Feel

Accumulo Powered By Logo

2014-10-02 Thread Keith Turner
I was a looking at the new Accumulo powered logo [1] and thought that just an A[2] may be better. Any other thoughts on how to improve this? Someone mentioned that just the A[2] isn't as informative in the case where someone is completely unfamiliar w/ Accumulo. [1]:

Re: Accumulo Powered By Logo

2014-10-02 Thread Corey Nolet
I think a logo that's more friendly to place in a circle would be useful. The Accumulo logo is very squared off. On Thu, Oct 2, 2014 at 3:39 PM, Mike Drob mad...@cloudera.com wrote: Yea, as an outside observer, I would have no idea what Apache A is, nor any idea how to get more information.

Re: Accumulo Powered By Logo

2014-10-02 Thread Keith Turner
On Thu, Oct 2, 2014 at 3:39 PM, Mike Drob mad...@cloudera.com wrote: Yea, as an outside observer, I would have no idea what Apache A is, nor any idea how to get more information. Maybe we just need a different logo, One mitigating factor, is that if anyone used the logo on a web site I think

Re: Accumulo Powered By Logo

2014-10-02 Thread Keith Turner
On Thu, Oct 2, 2014 at 3:39 PM, Mike Drob mad...@cloudera.com wrote: Yea, as an outside observer, I would have no idea what Apache A is, nor any idea how to get more information. Maybe we just need a different logo, altogether, given the context of putting it in the PBA circle. Another

Re: Accumulo Powered By Logo

2014-10-02 Thread Billie Rinaldi
I would argue that the a logo is one of our official logos. It is in use as the favicon of the Accumulo monitor page, and on our Twitter account. On Oct 2, 2014 3:49 PM, Keith Turner ke...@deenlo.com wrote: On Thu, Oct 2, 2014 at 3:39 PM, Mike Drob mad...@cloudera.com wrote: Yea, as an

Re: Accumulo Powered By Logo

2014-10-02 Thread Keith Turner
On Thu, Oct 2, 2014 at 3:58 PM, Billie Rinaldi billie.rina...@gmail.com wrote: I would argue that the a logo is one of our official logos. It is in use as the favicon of the Accumulo monitor page, and on our Twitter account. ok. In that case the a by itself may be a better choice w/ for the

Re: Accumulo Powered By Logo

2014-10-02 Thread Keith Turner
On Thu, Oct 2, 2014 at 4:02 PM, Adam Fuchs afu...@apache.org wrote: I like the one with just the 'a', but I think we could make ~50% bigger. I agree. Adam On Thu, Oct 2, 2014 at 3:58 PM, Billie Rinaldi billie.rina...@gmail.com wrote: I would argue that the a logo is one of our

Re: Jenkins now building pull-requests against apache/accumulo

2014-10-02 Thread Josh Elser
(also, thank you for making the changes, don't want to appear snippy) Josh Elser wrote: Should we have a JDK 1.6 build against the 1.6 branch to catch things like JDK7 only constructs? I'm not entirely sure if that's possible with the new plugin or not. Christopher wrote: I bumped the JDK

Re: Jenkins now building pull-requests against apache/accumulo

2014-10-02 Thread Christopher
Nah, the maven-compiler-plugin configuration passes -source 1.6 -target 1.6 to javac, which will catch 99% of that. There's a few compile-time type safety stuff with generics that it won't catch, but these are fringe cases that are easily caught and fixed, so I don't think it's worth having two

Re: Jenkins now building pull-requests against apache/accumulo

2014-10-02 Thread Christopher
I'm not worried about this Jenkins job. I doubt this will introduce significant spam. I'm more worried about the spam from comments on pull requests/reviews on pull requests that might discourage pull requests in general, and reduce the likelihood of this Jenkins job getting much use. But, that's