---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29176/#review66882
---
On Dec. 30, 2014, 5:46 p.m., Christopher Tubbs wrote:
server/base/src/main/java/org/apache/accumulo/server/security/handler/KerberosAuthenticator.java,
line 41
https://reviews.apache.org/r/29386/diff/4/?file=803164#file803164line41
I don't think this should be so tightly coupled
On Dec. 18, 2014, 5:20 p.m., Christopher Tubbs wrote:
core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java,
line 34
https://reviews.apache.org/r/29176/diff/1/?file=795044#file795044line34
It'd be neat if there were a MetricsGatherer interface, which this
On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
On Dec. 18, 2014, 12:20 p.m., Christopher Tubbs wrote:
core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java,
line 34
https://reviews.apache.org/r/29176/diff/1/?file=795044#file795044line34
It'd be neat if there were a MetricsGatherer interface, which this
On Dec. 30, 2014, 5:46 p.m., Christopher Tubbs wrote:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java,
lines 71-79
https://reviews.apache.org/r/29386/diff/4/?file=803145#file803145line71
Why is this unsupported?
Josh Elser wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29230/#review66915
---
Nit: whitespace
Nit: single-line statements w/out braces
On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
On Dec. 30, 2014, 5:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29502/#review66908
---
test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java
On Dec. 30, 2014, 5:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
On Dec. 30, 2014, 5:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29176/#review66906
---
On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29386/
---
(Updated Jan. 6, 2015, 11:14 p.m.)
Review request for accumulo.
Changes
On Dec. 30, 2014, 7:39 p.m., kturner wrote:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java,
line 46
https://reviews.apache.org/r/29386/diff/4/?file=803145#file803145line46
This is adding UserGroupInformation to Accumulo API. Is that a
On Dec. 30, 2014, 5:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
On Dec. 30, 2014, 2:39 p.m., kturner wrote:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java,
line 46
https://reviews.apache.org/r/29386/diff/4/?file=803145#file803145line46
This is adding UserGroupInformation to Accumulo API. Is that a
On Jan. 5, 2015, 9:09 p.m., Christopher Tubbs wrote:
core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java,
line 63
https://reviews.apache.org/r/29502/diff/2/?file=804705#file804705line63
Should this be Authorizations.EMPTY? Or should it have a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29502/
---
(Updated Jan. 6, 2015, 3:44 p.m.)
Review request for accumulo, Christopher
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29502/
---
(Updated Jan. 6, 2015, 3:54 p.m.)
Review request for accumulo, Christopher
On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote:
core/src/main/java/org/apache/accumulo/core/conf/Property.java, lines
165-167
https://reviews.apache.org/r/29386/diff/4/?file=803146#file803146line165
I don't think we want to expose this. It's high risk. What is the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29386/
---
(Updated Jan. 7, 2015, 5:43 a.m.)
Review request for accumulo.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29386/
---
(Updated Jan. 7, 2015, 6:16 a.m.)
Review request for accumulo.
Changes
On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote:
shell/src/main/java/org/apache/accumulo/shell/ShellOptionsJC.java, line 210
https://reviews.apache.org/r/29386/diff/4/?file=803175#file803175line210
Why is username the short user name? Is that unique in Kerberos? If
not, the
On Jan. 5, 2015, 4:09 p.m., Christopher Tubbs wrote:
core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java,
line 63
https://reviews.apache.org/r/29502/diff/2/?file=804705#file804705line63
Should this be Authorizations.EMPTY? Or should it have a
27 matches
Mail list logo
