Github user dhutchis commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/122#discussion_r69675388
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/user/ColumnAgeOffFilter.java
---
@@ -43,6 +43,9 @@ public TTLSet(Map
I assume you mean pull request. (JIRA link is below). Will do.
On Tue, Jul 5, 2016, 19:43 Sean Busbey wrote:
> Sounds good. Please post a link here to the JIRA?
>
>
>
> On Tue, Jul 5, 2016 at 4:58 PM, Christopher wrote:
> > On Thu, Jun 30, 2016 at 5:43
On Thu, Jun 30, 2016 at 5:43 PM Christopher wrote:
> Hi all,
>
> I'd like to bring to your attention
> https://issues.apache.org/jira/browse/ACCUMULO-4356, for discussion. Feel
> free to comment here or on the issue.
>
Reading back through all the replies, I don't see a
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/122
ACCUMULO-1604: added check for negate option in ColumnAgeOffFilter anâ¦
â¦d new test in FilterTest
You can merge this pull request into a Git repository by running:
$ git pull
On Tue, Jul 5, 2016 at 11:50 AM Mike Miller
wrote:
> Is
> there a preferred technique of code submission for non-committers?
>
>
My personal preference: GitHub pull requests. :)
Feel free to use `git-am` to create a patch or just submit a
pull-request against the master branch of apache/accumulo on Github.
Mike Miller wrote:
OK since the problem is really with the ColumnAgeOffFilter, I will go with
the simple check in the constructor and not make any changes to
OK since the problem is really with the ColumnAgeOffFilter, I will go with
the simple check in the constructor and not make any changes to Filter. Is
there a preferred technique of code submission for non-committers?
On Fri, Jul 1, 2016 at 3:28 PM, Keith Turner wrote:
> On
Github user ShawnWalker commented on the issue:
https://github.com/apache/accumulo/pull/121
> The stop-here.sh command has the master unload the tablets I think. How
will this patch handle that case?
This patch won't handle such a case at all. I'm sure it shows my
inexperience