Re: [DISCUSS] Should we have Jekyll build directly to asf-site branch?

2023-04-17 Thread Daniel Roberts
Christopher, I added a containerized dev environment in #384 which uses Jekyll's polling option to dynamically pick up changes. Based on that change being included, I'm ok with removing the staging site as PRs can be reviewed locally with minimal concern for dev environment drift. Thanks, -

Re: [DISCUSS] Should we have Jekyll build directly to asf-site branch?

2023-04-17 Thread Christopher
Keith - If we made the change, the README would still exist, but it would get a bit smaller, as there would be fewer mandatory things to do. Dan - Streamlining would just remove the staging site as a mandatory step. It will still remain an optional step, following steps similar to what you

Re: [DISCUSS] Should we have Jekyll build directly to asf-site branch?

2023-04-17 Thread Daniel Roberts
Christopher, In your breakdown of my proposal, I think there's a miscommunication in regard to the number of build steps and branches needed to maintain. Looking back I should have used descriptors like Branch C, Branch S, Branch P vs main and staging due to the collision with the current branch

Re: [DISCUSS] Should we have Jekyll build directly to asf-site branch?

2023-04-17 Thread Keith Turner
On Wed, Apr 12, 2023 at 12:34 PM Christopher wrote: > > I don't think Dan's suggested flow is much different than what we have > now. In both cases, the steps are: > > 1. Initial PR to a branch (currently against main; Dan's approach > would be against a separate main-like staging branch) > 2.