[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77374539 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/145 @dhutchis even if a copy is done, if the API accepts ByteBuffers it can help avoid forcing intermediate copies. For example user has to copy ByteBuffer to byte array, pass that byte array to

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

Github user dhutchis commented on the issue: https://github.com/apache/accumulo/pull/145 Good point @keith-turner. I had a contract in mind to not change the state of the ByteBuffer. Here is a better idea: add methods to accept a byte[], offset, and length. Users of

Re: [VOTE] Accumulo 1.8.0-rc4

In case you want to see what changed between RC3 and RC4 you can use https://github.com/apache/accumulo/compare/1.8.0-rc3...1.8.0-rc4 or https://github.com/apache/accumulo/compare/1.8.0-rc3...1.8.0-rc4.diff Not planning to rerun the continuous integration tests based on these changes. Also,

[VOTE] Accumulo 1.8.0-rc4

Accumulo Developers, Please consider the following candidate for Accumulo 1.8.0. Git Commit: a8a6329576869ac9ed63e4eff577af1c1864f052 Branch: 1.8.0-rc4 If this vote passes, a gpg-signed tag will be created using: git tag -f -m 'Apache Accumulo 1.8.0' -s rel/1.8.0

Re: [VOTE] Accumulo 1.8.0-rc4

+1 * Manually inspected the diff and all looks as expected * Verified SIGs and hashes * Verified commit and branch match contents of src tarball * Verified jars in staging repo match what's in bin tarball * All ITs (periodic timeouts, as usual; work on retry) successfully (have another run

Re: [VOTE] Accumulo 1.8.0-rc4

+1 (binding) * xsums/sigs good * Can build from source * Verified changes from rc3 * can run from binary tarball * Verified `accumulo rfile-info` works (assuming all verifications from previous I'll try to spin up another cluster over the long weekend to do some randomwalk testing, but I do

Re: [VOTE] Accumulo 1.8.0-rc4

+1 Verified sigs Built Fluo and ran its ITs against staging repo rfile-info was fixed, did anyone verify that multiple tservers still works? Mike Wall looking at the diffs you linked too, I noticed that the fix for the first seen dead gc issue also made it in to this RC. Thats a nice bonus, I

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424180 --- Diff: core/src/main/java/org/apache/accumulo/core/data/Key.java --- @@ -51,6 +51,26 @@ protected long timestamp; protected boolean

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424108 --- Diff: core/src/test/java/org/apache/accumulo/core/data/KeyBuilderTest.java --- @@ -0,0 +1,239 @@ +package org.apache.accumulo.core.data; +

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424119 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424201 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/145 Thanks a bunch @melrief . This will be very nice to have. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/145 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on the issue: https://github.com/apache/accumulo/pull/145 The new `KeyBuilderImpl` now keeps not only the byte arrays but also offsets and lengths of each byte and each method now takes this offset and length as optional parameters. In this way we are

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424114 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424294 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424301 --- Diff: core/src/main/java/org/apache/accumulo/core/data/Key.java --- @@ -51,6 +51,26 @@ protected long timestamp; protected boolean

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424280 --- Diff: core/src/test/java/org/apache/accumulo/core/data/KeyBuilderTest.java --- @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424333 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77424318 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation

Re: [VOTE] Accumulo 1.8.0-rc4

I'd like to add info about sampling to the release notes. I can do that Tue morning. On Fri, Sep 2, 2016 at 1:22 PM, Michael Wall wrote: > Accumulo Developers, > > Please consider the following candidate for Accumulo 1.8.0. > > Git Commit: >

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

Github user melrief commented on the issue: https://github.com/apache/accumulo/pull/145 Tests are failing on both Travis and my computer but for different reasons. On my computer the tests failing are ```java Failed tests: