Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/35#discussion_r29801880
--- Diff: maven-plugin/src/it/plugin-test/pom.xml ---
@@ -113,6 +113,13 @@
/execution
/executions
/plugin
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/35#issuecomment-98865651
The plugin is configured to use the existing
`contrib/Eclipse-Accumulo-Codestyle.xml`. I will figure out a way to not
introduce lone-spaces...
---
If your project
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/35
ACCUMULO-3771 Configure automatic java code style formatting
Pull request for
[ACCUMULO-3771](https://issues.apache.org/jira/browse/ACCUMULO-3771)
To make code review easier, you should
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/35#issuecomment-99519198
I just pushed an updated PR with following changes:
* Modified the configuration of the maven-java-formatter-plugin in
`pom.xml` to use a newer version (3.10
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/111#discussion_r66497618
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ---
@@ -168,8 +168,8 @@ public static void init(VolumeManager fs
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/101#issuecomment-221920050
Created new issues for social buttons
https://issues.apache.org/jira/browse/ACCUMULO-4316
---
If your project is set up for it, you can reply to this email
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/101#issuecomment-221917395
I addressed all of @ctubbsii cons except for moving the social buttons to
the footer. While I agree with his view, this pull request is getting big
enough
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/99#issuecomment-221920976
master and 1.8 should be sufficient but adding it to more (like 1.7) would
be great.
---
If your project is set up for it, you can reply to this email and have your
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/92
ACCUMULO-4189 - Added direct links to documentation on Accumulo website
#91 should be reviewed/merged first before this PR
You can merge this pull request into a Git repository by running
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/98
ACCUMULO-4179 - Add GitHub badges to README.md
Did not add Travis CI badge as builds are not completing in time.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/99
ACCUMULO-4310 - User manual should mention accumulo-site.xml propertyâ¦
⦠in instructions to enable native maps
You can merge this pull request into a Git repository by running:
$ git
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/98#discussion_r62912259
--- Diff: README.md ---
@@ -113,3 +115,9 @@ with Accumulo 1.6.2 and 1.7.0 all API changes will
follow [semver 2.0][12]
[14]: examples/simple/src/main
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/92#issuecomment-210143136
In 17288b37bab2b42, I fixed the README to point to latest pages that
redirect to current version. I also made the links to the Accumulo website use
https
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/91#discussion_r60277119
--- Diff: examples/latest.md ---
@@ -0,0 +1,6 @@
+---
+title: Accumulo Examples
+redirect_to: https://accumulo.apache.org/1.7/examples
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/91#discussion_r60302551
--- Diff: _config.yml ---
@@ -26,3 +26,6 @@ defaults:
type: "pages"
values:
layout: "skeleton"
+
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/92#discussion_r60592421
--- Diff: README.md ---
@@ -101,14 +97,19 @@ The Accumulo project maintains binary compatibility
across this API within a
major release, as defined
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/101
ACCUMULO-4313 - Made several improvements to website:
* Put website in container
* Moved Accumulo logo to navbar
* Organized navbar
* Moved all ASF links to their own dropdown
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64605620
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyr
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64612755
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyr
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/102
ACCUMULO-4313 - Updated README text to mirror website changes. Also, â¦
â¦stopped using numbers
in README for link references. Added accumulo logo to README.
You can merge this pull
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/213
Closing for now. I want to add some more work to this and open up new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/213
ACCUMULO-4528 Accumulo scripts improvements
* Accumulo now determines hostname in Java
* Minimized use of environment variables
* Consolidated scripts by moving service.sh and cluster.sh
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo-testing/pull/4
ACCUMULO-4581 Fixing several bugs in agitator scripts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikewalch/accumulo-testing
Github user mikewalch closed the pull request at:
https://github.com/apache/accumulo/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo-testing/pull/3#discussion_r98955888
--- Diff: core/src/main/java/org/apache/accumulo/testing/core/TestEnv.java
---
@@ -96,15 +97,22 @@ public String getPid
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/205
ACCUMULO-4510 Removed continuous ingest code
* Code was moved to accumulo-testing repo
* Kept copy of ContinuousIngest class as its used by other tests
This PR will be merged after
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo-testing/pull/2
ACCUMULO-4510 Refactored Continous Ingest tests
* Continuous ingest applications can be launched locally or in YARN and
are now configured by accumulo-testing.properties file
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo-testing/pull/3
ACCUMULO-4579 Fixed hadoop config bug in accumulo-testing
* TestEnv now returns Hadoop configuration that is loaded from config files
but expects HADOOP_PREFIX to be set
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo-testing/pull/3#discussion_r98556591
--- Diff: core/src/main/java/org/apache/accumulo/testing/core/TestEnv.java
---
@@ -96,15 +97,22 @@ public String getPid
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo-testing/pull/2#discussion_r97820268
--- Diff:
core/src/main/java/org/apache/accumulo/testing/core/continuous/ContinuousIngest.java
---
@@ -183,8 +177,9 @@ private static long flush
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo-testing/pull/2#discussion_r97820053
--- Diff: README.md ---
@@ -46,9 +46,88 @@ walkers in 5 containers in YARN using the Image.xml
module.
./bin/accumulo-testing rw
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo-testing/pull/2#discussion_r97819994
--- Diff: README.md ---
@@ -32,9 +32,9 @@ on your machine as well as an Accumulo instance to use
for testing.
The random walk test generates
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101784185
--- Diff: assemble/conf/examples/generic_logger.properties ---
@@ -15,7 +15,7 @@
# Write out everything at the DEBUG level to the debug log
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101784212
--- Diff: assemble/conf/examples/generic_logger.properties ---
@@ -24,7 +24,7 @@ log4j.appender.A2.layout.ConversionPattern=%d{ISO8601}
[%-8c{2}] %-5p
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101785204
--- Diff: INSTALL.md ---
@@ -76,19 +76,18 @@ When configuring Accumulo the following information
about these dependencies
must be provided
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/218
Thanks everyone for reviewing! Your feedback resulted in a lot of changes
that made this PR better. I think I have addressed all comments. Unless
someone needs more time to review or wants
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101782473
--- Diff: INSTALL.md ---
@@ -40,13 +40,13 @@ Accumulo has some optional native code that improves
its performance and
stability. Before configuring
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/218
I talked to @milleruntime offline about accumulo-env.sh rename. For this
PR, I decided to not do the rename as concerns were brought up about changing
name to accumulo.conf. In the end, I
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/221
> One open-ended question: how can we make sure that log-forwarding works
with the removal of MonitorLoggingIT? Do we need to extend MAC to allow us to
configure log4j better and t
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/221
ACCUMULO-4588 Simplify Accumulo logging configuration
* Removed log4j config being done in Java but some remains
* Logging is now configured using standard log4j JVM property
'log4
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103003156
--- Diff:
start/src/test/java/org/apache/accumulo/start/util/AsyncSocketAppenderTest.java
---
@@ -36,7 +31,7 @@
@Before
public void
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103003251
--- Diff: assemble/conf/templates/accumulo-env.sh ---
@@ -25,6 +25,21 @@
# Variables that must be set
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103023673
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java ---
@@ -1,121 +0,0 @@
-/*
- * Licensed to the Apache
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103013232
--- Diff: assemble/conf/log4j-monitor.properties ---
@@ -36,6 +36,17 @@
log4j.appender.GUI=org.apache.accumulo.server.monitor.LogService
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103013138
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ---
@@ -108,69 +105,20 @@ public static synchronized Path
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103021273
--- Diff: assemble/conf/templates/accumulo-env.sh ---
@@ -25,6 +25,21 @@
# Variables that must be set
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r102999845
--- Diff: assemble/conf/log4j-service.properties ---
@@ -15,42 +15,48 @@
# Write out everything at the DEBUG level to the debug log
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103000929
--- Diff: assemble/conf/log4j-monitor.properties ---
@@ -36,6 +36,17 @@
log4j.appender.GUI=org.apache.accumulo.server.monitor.LogService
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103011353
--- Diff: assemble/conf/log4j-service.properties ---
@@ -15,42 +15,48 @@
# Write out everything at the DEBUG level to the debug log
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo-examples/pull/4
Updates due to tool.sh being moved to 'accumulo-util hadoop-jar' in Aâ¦
â¦CCUMULO-4528
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101530931
--- Diff: INSTALL.md ---
@@ -25,11 +25,11 @@ source code. Unpack as follows.
tar xzf /accumulo-X.Y.Z-bin.tar.gz
cd accumulo-X.Y.Z
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101609853
--- Diff: INSTALL.md ---
@@ -40,13 +40,13 @@ Accumulo has some optional native code that improves
its performance and
stability. Before configuring
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101610417
--- Diff: assemble/contrib/tool.sh ---
@@ -26,14 +26,21 @@ contrib=$( cd -P "$( dirname "$SOURCE" )" && pwd )
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/218
ACCUMULO-4528 Accumulo scripts improvements
* Accumulo now determines hostname in Java
* Minimized use of environment variables
* Consolidated scripts by moving service.sh and cluster.sh
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/218#discussion_r101365500
--- Diff: INSTALL.md ---
@@ -57,15 +57,15 @@ The script will ask you questions about your set up.
Below are some suggestions:
processes like
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103484745
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java ---
@@ -1,121 +0,0 @@
-/*
- * Licensed to the Apache
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/221
I would like to merge this today. Let me know if there is anything else
that needs to be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103496710
--- Diff: assemble/conf/log4j-monitor.properties ---
@@ -15,18 +15,18 @@
# Write out everything at the DEBUG level to the debug log
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103504035
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ---
@@ -108,69 +105,20 @@ public static synchronized Path
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103497233
--- Diff: assemble/conf/log4j-monitor.properties ---
@@ -15,18 +15,18 @@
# Write out everything at the DEBUG level to the debug log
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/226
ACCUMULO-4594 Fix Kerberos documentation
* Added documentation for configuring Kerberos using 2.0.0 scripts
* Removed kerberos config file references from accumulo command as
these can
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/223#discussion_r103702178
--- Diff: assemble/conf/log4j-monitor.properties ---
@@ -16,23 +16,21 @@
## Log4j 1.2 file that configures logging for Accumulo Monitor
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/223#discussion_r103705868
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ---
@@ -107,18 +104,6 @@ public static synchronized Path
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/223#discussion_r103707238
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/util/AccumuloMonitorAppender.java
---
@@ -0,0 +1,153 @@
+/*
+ * Licensed
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/223#discussion_r103706254
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/watcher/Log4jConfiguration.java
---
@@ -1,59 +0,0 @@
-/*
- * Licensed
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/223#discussion_r103702937
--- Diff: assemble/conf/log4j-service.properties ---
@@ -13,43 +13,47 @@
# See the License for the specific language governing permissions
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/223#discussion_r10370
--- Diff: assemble/conf/templates/accumulo-env.sh ---
@@ -53,20 +58,37 @@ shell) JAVA_OPTS=("${JAVA_OPTS[@]}"
${shellHig
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/225#discussion_r103942407
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java
---
@@ -148,46 +148,35 @@ public Configuration
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103227251
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java ---
@@ -1,121 +0,0 @@
-/*
- * Licensed to the Apache
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/146
ACCUMULO-4448 - Remove accumulo.policy.example
* Example file is no longer included in distribution tarball
* Updated accumulo-env.sh to not look for file or set security policy
You can
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/147
ACCUMULO-2884 Removed 'slave' terminology
* Replaced 'slave' with 'tserver' in most cases
* When referring to slave node, used the term 'worker'
* The 'slaves' configuration file is now
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
Below are the errors that are printed if `tservers` file is missing.
```
Starting monitor on localhost
Starting tablet servers ...egrep:
/install/accumulo-2.0.0-SNAPSHOT/conf
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
> Should probably rename this PR; it's ACCUMULO-2844, not ACCUMULO-2884.
Nice catch @dimaspivak. Will do
---
If your project is set up for it, you can reply to this email and have y
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
> This sounds OK to me. We have a bit more leeway with a "real" major
release than I'm used to. I think I would be OK with error'ing out of the
script in the case when only th
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
For testing, I built the Accumulo tarball and was able to start Accumulo
successfully using the scripts. I started Accumulo without the `tservers` and
error messages were printed
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/146
Great! Thanks @joshelser!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
Added checks to scripts in c182f806daa48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/160
Simplify Accumulo scripts and config files
See [JIRA issue](https://issues.apache.org/jira/browse/ACCUMULO-4490) for
background.
This pull request is not ready to be merged. I am
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/155
ACCUMULO-4475 User manual references 'admin start'
* Removed references as 'bin/accumulo admin start' command does not exist.
You can merge this pull request into a Git repository by running
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/156
ACCUMULO-4476 User manual references old version
* Changed version reference in installation instructions from 1.6.0
to X.Y.Z so that it doesn't need to be updated for each release.
You
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/157
ACCUMULO-4477 User manual version should 2.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikewalch/accumulo accumulo-4477
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/170
To be clear, this PR doesn't make releases Jekyll posts but I would like to
do this in a later PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r85158065
--- Diff: assemble/bin/accumulo-cluster ---
@@ -0,0 +1,97 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r85158086
--- Diff: assemble/bin/accumulo-service ---
@@ -0,0 +1,101 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r85158301
--- Diff: assemble/scripts/load-env.sh ---
@@ -0,0 +1,153 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/160
I tested the latest changes using Uno and was able to run on local machine.
Before this is merged, I would like to verify that the scripts still work on
cluster. I will modify Muchos
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/170
@joshelser, with this pull request, I am trying to mimic what has been done
on the Apache Fluo website. The Fluo website has two kinds of Jekyll posts
(blog and release). Blog posts are self
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r85157677
--- Diff: INSTALL.md ---
@@ -26,33 +25,50 @@ source code. Unpack as follows.
tar xzf /accumulo-X.Y.Z-bin.tar.gz
cd accumulo-X.Y.Z
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/171
Remove slash from links to news archive
It's causing page not found error in production.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mikewalch closed the pull request at:
https://github.com/apache/accumulo/pull/172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87013474
--- Diff: INSTALL.md ---
@@ -26,33 +25,50 @@ source code. Unpack as follows.
tar xzf /accumulo-X.Y.Z-bin.tar.gz
cd accumulo-X.Y.Z
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87013410
--- Diff: INSTALL.md ---
@@ -99,13 +114,43 @@ The initialization command will prompt for the
following information.
prompts for its password
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87011843
--- Diff: assemble/bin/accumulo-service ---
@@ -0,0 +1,104 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/160
@joshelser, Yes I am done. 4f42b79b3992b4 should be last commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87011875
--- Diff: assemble/bin/accumulo-service ---
@@ -0,0 +1,104 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87011817
--- Diff: assemble/bin/accumulo-cluster ---
@@ -0,0 +1,103 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87014185
--- Diff: docs/src/main/asciidoc/chapters/iterator_design.txt ---
@@ -37,8 +37,8 @@ pitfalls.
To invoke an Accumulo Iterator inside
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87013924
--- Diff: docs/src/main/asciidoc/chapters/clients.txt ---
@@ -32,16 +32,16 @@ classpath. For recent Zookeeper versions, you only need
to add
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/160
@joshelser, I think it's ready to go in. I would make sure your branch is
up to date before reviewing as I just rebased to fix the last commit message
and squash a few more updates
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/160#discussion_r87011488
--- Diff: assemble/bin/accumulo ---
@@ -15,173 +15,189 @@
# See the License for the specific language governing permissions and
# limitations
1 - 100 of 291 matches
Mail list logo
