FWIW, we use the animal-sniffer plugin to verify full Java 7 compatibility
to avoid those historical issues with simply setting the target JDK. But, I
also understand if that plugin does not instill sufficient confidence for
Java 7 compatibility. I can do the format-only-in-jdk8-profile strategy,
+1 to not changing min-Java on the release lines that supported Java 7.
Let's just cease activity on these branches instead :)
On 2/16/18 9:55 AM, Sean Busbey wrote:
I'm opposed to requiring Java 8 to build on branches that we claim support
running under Java 7. Historically relying on
I'm opposed to requiring Java 8 to build on branches that we claim support
running under Java 7. Historically relying on "compile for earlier target
JDK" has just led to pain down the road when it inevitably doesn't work.
Just make it a recommendation for contributions and have our precommit
> To: "accumulo-dev" <dev@accumulo.apache.org>
> Sent: 2/15/2018 11:24:31 PM
> Subject: [DISCUSS] Proposed formatter change: 100 char lines
>
> Primarily for accessibility reasons (screen space with a comfortable font),
>> but also to support readability for dev
..@apache.org>
To: "accumulo-dev" <dev@accumulo.apache.org>
Sent: 2/15/2018 11:24:31 PM
Subject: [DISCUSS] Proposed formatter change: 100 char lines
Primarily for accessibility reasons (screen space with a comfortable
font),
but also to support readability for devs working on sensibly-
Primarily for accessibility reasons (screen space with a comfortable font),
but also to support readability for devs working on sensibly-sized screens,
I want to change our formatter to format with 100 char line length instead
of its current 160.
Many of our files need to be reformatted anyway,
