Re: Proposal for splitting ACCUMULO-1242 into subtasks.

2014-05-13 Thread William Slacum
Sounds good, Ed. Just out of curiosity, are you planning on doing this with the goal of being able to swap out log4j for logback? In personal projects, I like slf4j solely for the message formatting feature. On Mon, May 12, 2014 at 10:45 PM, Sean Busbey bus...@cloudera.com wrote: +1 LGTM

RE: Proposal for splitting ACCUMULO-1242 into subtasks.

2014-05-13 Thread Ed Coleman
Originally, when I first started work on the ticket, using logback would have been my goal. After going through the code a few times, what is driving me now is really to clean things up a little and position things for an eventual ability to use logback or to upgrade to log4j-2. After

RE: Proposal for splitting ACCUMULO-1242 into subtasks.

2014-05-13 Thread Ed Coleman
Originally, when I first started work on the ticket, using logback would have been my goal. After going through the code a few times, what is driving me now is really to clean things up a little and position things for an eventual ability to use logback or to upgrade to log4j-2. After

Proposal for splitting ACCUMULO-1242 into subtasks.

2014-05-12 Thread Ed Coleman
I am willing to take another run at the Consistent Logging ticket, ACCUMULO-1242, but I'd like to achieve a consensus on an approach before starting. The tl;dr version - I would like to split ACCUMULO-1242 into subtasks. Target version would be 1.7.0 (or whatever it gets called, would not mind

Re: Proposal for splitting ACCUMULO-1242 into subtasks.

2014-05-12 Thread Mike Drob
+1. You've spent more time thinking about this than the rest of us combined, probably, so if you think this is the best approach I recommend just going for it. If we discover other issues as they crop up, then we can deal with them at that point. Mike On Mon, May 12, 2014 at 9:15 PM, Ed

Re: Proposal for splitting ACCUMULO-1242 into subtasks.

2014-05-12 Thread Sean Busbey
+1 LGTM Overall approach looks good, we can deal with details in review. -- Sean On May 12, 2014 8:49 PM, Mike Drob md...@mdrob.com wrote: +1. You've spent more time thinking about this than the rest of us combined, probably, so if you think this is the best approach I recommend just going