[GitHub] activemq-artemis pull request #944: ARTEMIS-904 - Remove cyclic dependencies...

2017-01-01 Thread bennetelli
Github user bennetelli closed the pull request at: https://github.com/apache/activemq-artemis/pull/944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/944 You'll need to close it. Here's a link to the checkstyle issues https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/2113/consoleFull --- If your project is set up for it, you can

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread bennetelli
Github user bennetelli commented on the issue: https://github.com/apache/activemq-artemis/pull/944 sh**. Created the branch from my previous ARTEMIS-903 branch. Would be good if we could close the second one (ARTEMIS-904) and I will open a new PR later. --- If your project is set up

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread bennetelli
Github user bennetelli commented on the issue: https://github.com/apache/activemq-artemis/pull/944 Can't find any checkstyle warnings. Where are you looking for it? The Jenkins build failed because of an error in LDAP stuff which I didn't touch with my new markdown documentation.

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/944 Also it looks like you have two PRs with the same changes now. We should merge one. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/944 Looks like some checkstyle issues in the CLI module, if you could fix those up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...

2017-01-01 Thread bennetelli
Github user bennetelli commented on the issue: https://github.com/apache/activemq-artemis/pull/944 @clebertsuconic argh. Thought another branch would result in a separate pull request. Let me know if you have trouble with it :/ --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis pull request #944: ARTEMIS-904 - Remove cyclic dependencies...

2017-01-01 Thread bennetelli
GitHub user bennetelli opened a pull request: https://github.com/apache/activemq-artemis/pull/944 ARTEMIS-904 - Remove cyclic dependencies from artemis-cli To ensure a maintainability in future I refactored the cli project and removed all cyclic dependencies between classes and

[GitHub] activemq-artemis issue #943: ARTEMIS-903 Add documentation for updating Arte...

2017-01-01 Thread bennetelli
Github user bennetelli commented on the issue: https://github.com/apache/activemq-artemis/pull/943 Happy new year, Clebert :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature