[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic sure I'll take care of it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @gaohoward actually, the example managmeent is broken after this. Can you look please? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @mtaylor I will let you merge this.. but this PR is +1 from me.. nice job @gaohoward --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #1209: ARTEMIS-1122 ActiveMQJAASSecurityManager class...

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1209 @jbertram Hi Justin can you review this pls? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...

2017-04-20 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1216 Merged now you can close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis pull request #1216: ARTEMIS-1124 JDBC Network Timeout confi...

2017-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #1218: Artemis 1125 - Implement JMS Bindings J...

2017-04-20 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1218 Artemis 1125 - Implement JMS Bindings JDBC Store You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis

[GitHub] activemq-artemis pull request #1217: ARTEMIS-1124 JDBC Network Timeout confi...

2017-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...

2017-04-20 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1216 @graben Thanks! Fixed in the 2.x fix too! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis issue #1217: ARTEMIS-1124 JDBC Network Timeout configuratio...

2017-04-20 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1217 @mtaylor I can change it now :) I've just arrived home :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #1217: ARTEMIS-1124 JDBC Network Timeout configuratio...

2017-04-20 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1217 yes please. Thanks Franz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] activemq-artemis issue #1217: ARTEMIS-1124 JDBC Network Timeout configuratio...

2017-04-20 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1217 @franz1981 two comments here. 1. The network time out should also be used on the page store. 2. The default timeout is 20seconds but the docs says 30s. I'll merge this

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 There might be a problem with Jenkins machine, the failure relates to 'memory allocation'. Not related to my PR. @clebertsuconic I ran the whole test suite on my local machine, there

[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...

2017-04-20 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1216 Well, 20s in impl is different to 30s in doc. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis pull request #1217: ARTEMIS-1124 JDBC Network Timeout confi...

2017-04-20 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1217 ARTEMIS-1124 JDBC Network Timeout configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis

[GitHub] activemq-artemis pull request #1216: ARTEMIS-1124 JDBC Network Timeout confi...

2017-04-20 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1216 ARTEMIS-1124 JDBC Network Timeout configuration (cherry picked from commit 256773206b75e6040d15cf06722843a7a9107ca8) You can merge this pull request into a Git repository by running:

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Please. While the whole testsuite ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 OK, I removed the garbage files and reverted AmqpSendReceiveTest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

2017-04-20 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1215#discussion_r112476953 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java --- @@ -53,38

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

2017-04-20 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1215#discussion_r112475520 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java --- @@ -53,38

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 guys please hold on this commit, I found some garbage files need to remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

2017-04-20 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor This is a resubmit of FQQN PR, with all tests fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

2017-04-20 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1215 ARTEMIS-1093 Full qualified queue name support Broker should support full qualified queue names (FQQN) as well as bare queue names. This means when clients access to a queue