Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
ok. strange. will check that. thanks for mertging @clebertsuconic ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1278
@clebertsuconic just seen this, rebased and re-raised against master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1282
@clebertsuconic re-pointed the PR to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
don't know.. perhaps you did on a wrong branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@clebertsuconic yep. thx. thought I would have fixed it myself..
the steps I did:
- git rebase -i HEAD~1
- change commit message
- git push --force
what
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1281
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
Wrong JIRA: it should be artemis-1174 and not 1147...
although I could fix it using ./scripts/checkout-PR.sh and
./scripts/merge-branch.sh.. so don't worry about it..
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1282
ARTEMIS-1129: Fixing tests after client all
To add ontop of the reduced-dependency.pom fix.
Clean up shaded jar
Ensure aggregated notice
Ensure correct license
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
in general.. it would be better to just send a link on Idea instead of
duplicating the steps...
it's minor though.. I'm not going to fight about it :)
---
If your
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@clebertsuconic why? do you mean specifics like version numbers or IntelliJ
specifics in general?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@bennetelli I will merge it as it's already done.. but I'm a bit concerned
to keep documenting idea specifics.. ;)
---
If your project is set up for it, you can reply to this
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
I won't merge it if it's referencing the wrong JIRA. However, it's easy to
change. Just rebase interactively, re-word the commit message, and push -f.
The PR will update
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
Argh.. So you need to reject it, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
You've transposed 4 and 7 in the JIRA reference of your commit message. It
should be ARTEMIS-1174.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1281
ARTEMIS-1147 Update Hacking Guide Documentation: IDE Integration
the IntelliJ import wizard doesn't contain a sentence like:"Select "Import
from existing model". This should be
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1278
@michaelandrepearce just saw your message after I merged it...
Send it to master... I needed to merge it so I could run tests again.
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user lulf opened a pull request:
https://github.com/apache/activemq-artemis/pull/1280
Don't set routing type if null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lulf/activemq-artemis ARTEMIS-1173
Alternatively you
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user iweiss commented on the issue:
https://github.com/apache/activemq-artemis/pull/1276
Although I agree, knowing what is necessary or not make this quite
challenging since what is needed for one is not needed for someone else.
My main concern was the cascade of
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1279
ARTEMIS-1169 - Implement Interceptors for the AMQP protocol
Add Outgoing call
https://issues.apache.org/jira/browse/ARTEMIS-1169
You can merge this pull request into a Git
22 matches
Mail list logo
