[GitHub] activemq-artemis pull request #1565: ARTEMIS-1443 Fix issue starting Artemis...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1565 ---

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @franz1981 we can have it back.. just would need to have it properly at Netty exposed.. either have your class, a super class we can easily extend.. or whatever is needed. ---

[GitHub] activemq-artemis pull request #1567: ARTEMIS-1397 Removing Netty Copied clas...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1567 ---

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @franz1981 i agree with you, any chance we can get netty guys, to either take your class, or to get netty to make the methods you use in UnsafeByteBufUtil set to public? So we

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @clebertsuconic @michaelandrepearce the reason behind that class was to have more stable latencies on hot paths with no data-sync enabled: if not reused it creates a big amount of

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @michaelandrepearce I think the right thing is to use the Netty Buffer Like I am doing now... reusing the instance.. just to call wrap.. not even Netty guys mind about that...

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @clebertsuconic just for record, i don't have issue with the class @franz1981 made, its more the very recent change that brought in the UnsafeByteBufUtil.java just so they

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @clebertsuconic yup lets, step me through the process, good chance to learn. ---

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @michaelandrepearce fancy doing your first merge? ---

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @michaelandrepearce this is following up after #1561 ---

[GitHub] activemq-artemis issue #1567: ARTEMIS-1397 Removing Netty Copied classes

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1567 @michaelandrepearce / @franz1981 I don't really see much gain on saving the ByteBuf instance. Maybe page.write would create a few more instances.. but I doubt it would really

[GitHub] activemq-artemis pull request #1567: ARTEMIS-1397 Removing Netty Copied clas...

GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1567 ARTEMIS-1397 Removing Netty Copied classes instead of duplicating a buffer from Netty, this will use an existing Wrapped Unpooled Buffer Which will in turn use Unsafe

[GitHub] activemq-artemis issue #1565: ARTEMIS-1443 Fix issue starting Artemis in OSG...

Github user ryeats commented on the issue: https://github.com/apache/activemq-artemis/pull/1565 If you add ?protocols=CORE to the artemis.xml rebuild and then run ArtemisFeatureTest it will fail because artemis doesn't start. Since I added that in this PR it will be tested going

[GitHub] activemq-artemis pull request #1565: ARTEMIS-1443 Fix issue starting Artemis...

Github user ryeats commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1565#discussion_r142204873 --- Diff: artemis-features/src/main/resources/artemis.xml --- @@ -22,28 +22,68 @@ under the License.

[GitHub] activemq-artemis pull request #1566: NO-JIRA fix groupID URL doc

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1566 ---

[GitHub] activemq-artemis issue #1565: ARTEMIS-1443 Fix issue starting Artemis in OSG...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1565 I believe this is fixing something.. but I need to how reproduce it exactly.. maybe add a test case... I will hold merging this until you provide me some details. ---

[GitHub] activemq-artemis pull request #1566: NO-JIRA fix groupID URL doc

GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1566 NO-JIRA fix groupID URL doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.1

Oops, forgot to include Robbie, the updated list is: Binding: +1 Timothy Bish +1 Christopher Shannon +1 Clebert Suconic Non-Binding +1 Jean-Baptiste Onofré +1 Robbie Gemmell On Mon, Oct 2, 2017 at 10:34 AM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Results of the Apache

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.1

On 2 October 2017 at 15:34, Christopher Shannon wrote: > Results of the Apache ActiveMQ 5.15.1 vote: > > Vote passes with 3 +1 binding votes. > > The following votes were received: > > Binding: > +1 Timothy Bish > +1 Christopher Shannon > +1 Clebert Suconic > >

[RESULT][VOTE] Apache ActiveMQ 5.15.1

Results of the Apache ActiveMQ 5.15.1 vote: Vote passes with 3 +1 binding votes. The following votes were received: Binding: +1 Timothy Bish +1 Christopher Shannon +1 Clebert Suconic Non-Binding +1 Jean-Baptiste Onofré I'll start pushing out the release bundles and update the Wiki.

[GitHub] activemq-artemis issue #1565: ARTEMIS-1443 Fix issue starting Artemis in OSG...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1565 How to reproduce the issue? ---

[GitHub] activemq-artemis pull request #1565: ARTEMIS-1443 Fix issue starting Artemis...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1565#discussion_r142150629 --- Diff: artemis-features/src/main/resources/artemis.xml --- @@ -22,28 +22,68 @@ under the License.

[GitHub] activemq-artemis issue #1561: ARTEMIS-1397 remove package private access to ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1561 @ryeats thanks a lot! ---

[GitHub] activemq-artemis pull request #1561: ARTEMIS-1397 remove package private acc...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1561 ---

[GitHub] activemq-artemis issue #1561: ARTEMIS-1397 remove package private access to ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1561 @michaelandrepearce It's not copying... @franz1981 had written a class extending a Netty Buffer, instead of using protected methods he named the package io.netty... I missed that

Re: [ANNOUNCE] Welcome Michael Andre Pearce as an Apache ActiveMQ Committer

Great job and well deserved Michael Il giorno lun 2 ott 2017 alle ore 15:37 Clebert Suconic < clebert.suco...@gmail.com> ha scritto: > On behalf of the Apache ActiveMQ PMC, I am very pleased to announce > that Michael Andre Pearce has accepted an invitation to become a > committer. We

Re: [ANNOUNCE] Welcome Michael Andre Pearce as an Apache ActiveMQ Committer

Nice work, Michael. Looking forward to future contributions! Justin On Mon, Oct 2, 2017 at 8:37 AM, Clebert Suconic wrote: > On behalf of the Apache ActiveMQ PMC, I am very pleased to announce > that Michael Andre Pearce has accepted an invitation to become a >

[ANNOUNCE] Welcome Michael Andre Pearce as an Apache ActiveMQ Committer

On behalf of the Apache ActiveMQ PMC, I am very pleased to announce that Michael Andre Pearce has accepted an invitation to become a committer. We greatly appreciate all of Michael's hard work and generous contributions to the project. We look forward to continue working with him. Welcome